Re: [PATCH v4 3/3] spi: cs42l43: Add bridged cs35l56 amplifiers

[kernel test robot <lkp@intel.com>]

Hi Charles,

kernel test robot noticed the following build errors:

[auto build test ERROR on broonie-spi/for-next]
[also build test ERROR on brgl/gpio/for-next linus/master v6.9-rc3 next-20240410]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Charles-Keepax/gpio-swnode-Add-ability-to-specify-native-chip-selects-for-SPI/20240409-212316
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
patch link:    https://lore.kernel.org/r/20240409132126.1117916-4-ckeepax%40opensource.cirrus.com
patch subject: [PATCH v4 3/3] spi: cs42l43: Add bridged cs35l56 amplifiers
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240410/202404101443.tYCaeZAm-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240410/202404101443.tYCaeZAm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404101443.tYCaeZAm-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/spi/spi-cs42l43.c: In function 'cs42l43_has_sidecar':
>> drivers/spi/spi-cs42l43.c:262:50: error: invalid use of undefined type 'struct acpi_device'
     262 |                 ret = acpi_get_local_address(adev->handle, &function);
         |                                                  ^~


vim +262 drivers/spi/spi-cs42l43.c

   247	
   248	static bool cs42l43_has_sidecar(struct fwnode_handle *fwnode)
   249	{
   250		static const u32 func_smart_amp = 0x1;
   251		struct fwnode_handle *child_fwnode, *ext_fwnode;
   252		unsigned int val;
   253		u32 function;
   254		int ret;
   255	
   256		fwnode_for_each_child_node(fwnode, child_fwnode) {
   257			struct acpi_device *adev = to_acpi_device_node(child_fwnode);
   258	
   259			if (!adev)
   260				continue;
   261	
 > 262			ret = acpi_get_local_address(adev->handle, &function);
   263			if (ret || function != func_smart_amp) {
   264				fwnode_handle_put(child_fwnode);
   265				continue;
   266			}
   267	
   268			ext_fwnode = fwnode_get_named_child_node(child_fwnode,
   269					"mipi-sdca-function-expansion-subproperties");
   270			if (!ext_fwnode) {
   271				fwnode_handle_put(child_fwnode);
   272				continue;
   273			}
   274	
   275			ret = fwnode_property_read_u32(ext_fwnode,
   276						       "01fa-cirrus-sidecar-instances",
   277						       &val);
   278	
   279			fwnode_handle_put(ext_fwnode);
   280			fwnode_handle_put(child_fwnode);
   281	
   282			if (!ret)
   283				return !!val;
   284		}
   285	
   286		return false;
   287	}
   288	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki