From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>, Ingo Molnar <mingo@redhat.com>,
Jiri Olsa <jolsa@kernel.org>, Marco Elver <elver@google.com>,
Mark Rutland <mark.rutland@arm.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH v3 2/4] perf: Enqueue SIGTRAP always via task_work.
Date: Wed, 10 Apr 2024 16:48:21 +0200 [thread overview]
Message-ID: <20240410144821.bVdBdVOR@linutronix.de> (raw)
In-Reply-To: <ZhalcBcd3w0w2HD_@localhost.localdomain>
On 2024-04-10 16:42:56 [+0200], Frederic Weisbecker wrote:
> > > Like this then?
> > >
> > > https://lore.kernel.org/all/202403310406.TPrIela8-lkp@intel.com/T/#m63c28147d8ac06b21c64d7784d49f892e06c0e50
> >
> > Kind of, yes. Do we have more than one waiter? If not, maybe that
> > rcuwait would work then.
>
> Indeed there is only one waiter so that should work. Would
> that be something you can call while preemption is disabled?
rcuwait_wake_up() does only wake_up_process() which is fine.
wake_up() does spin_lock_irqsave() which is a no.
On the other hand that preempt-disable needs to go anyway due to
perf_sigtrap(). But a slim wake is a slim wake ;)
> Thanks.
Sebastian
next prev parent reply other threads:[~2024-04-10 14:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 6:48 [PATCH v3 0/4] perf: Make SIGTRAP and __perf_pending_irq() work on RT Sebastian Andrzej Siewior
2024-03-22 6:48 ` [PATCH v3 1/4] perf: Move irq_work_queue() where the event is prepared Sebastian Andrzej Siewior
2024-03-22 6:48 ` [PATCH v3 2/4] perf: Enqueue SIGTRAP always via task_work Sebastian Andrzej Siewior
2024-04-08 21:29 ` Frederic Weisbecker
2024-04-09 8:57 ` Sebastian Andrzej Siewior
2024-04-09 12:36 ` Frederic Weisbecker
2024-04-09 13:47 ` Sebastian Andrzej Siewior
2024-04-10 11:37 ` Frederic Weisbecker
2024-04-10 13:47 ` Sebastian Andrzej Siewior
2024-04-10 14:00 ` Frederic Weisbecker
2024-04-10 14:06 ` Sebastian Andrzej Siewior
2024-04-10 14:42 ` Frederic Weisbecker
2024-04-10 14:48 ` Sebastian Andrzej Siewior [this message]
2024-04-10 14:50 ` Frederic Weisbecker
2024-03-22 6:48 ` [PATCH v3 3/4] perf: Remove perf_swevent_get_recursion_context() from perf_pending_task() Sebastian Andrzej Siewior
2024-04-08 22:06 ` Frederic Weisbecker
2024-04-09 6:25 ` Sebastian Andrzej Siewior
2024-04-09 10:35 ` Frederic Weisbecker
2024-04-09 10:54 ` Sebastian Andrzej Siewior
2024-04-09 12:00 ` Frederic Weisbecker
2024-04-09 13:33 ` Sebastian Andrzej Siewior
2024-04-10 10:38 ` Frederic Weisbecker
2024-04-10 12:51 ` Sebastian Andrzej Siewior
2024-04-10 13:58 ` Frederic Weisbecker
2024-03-22 6:48 ` [PATCH v3 4/4] perf: Split __perf_pending_irq() out of perf_pending_irq() Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410144821.bVdBdVOR@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=elver@google.com \
--cc=frederic@kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.