From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 4/4] net: dqs: make struct dql more cache efficient
Date: Wed, 10 Apr 2024 18:45:49 -0700 [thread overview]
Message-ID: <20240410184549.5e5f77f2@kernel.org> (raw)
In-Reply-To: <ZhaZuOjq+b5nzqcs@gmail.com>
On Wed, 10 Apr 2024 06:52:56 -0700 Breno Leitao wrote:
> > Doesn't this move the cache line bouncing problem to the other side?
>
> I think so. Looking at dql_check_stall(), it only uses fields in the
> second cache line, except now 'dql->stall_thrs' that is in the first
> cache line.
We do read num_queued at the beginning of dql_completed().
So maybe we we move the read of the threshold there we will be fine.
prev parent reply other threads:[~2024-04-11 1:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 17:25 [PATCH v2 0/4] net : dqs: optimize if stall threshold is not set Breno Leitao
2024-04-08 17:25 ` [PATCH net-next v2 1/4] net: dql: Avoid calling BUG() when WARN() is enough Breno Leitao
2024-04-08 17:25 ` [PATCH net-next v2 2/4] net: dql: Separate queue function responsibilities Breno Leitao
2024-04-08 17:25 ` [PATCH net-next v2 3/4] net: dql: Optimize stall information population Breno Leitao
2024-04-08 17:25 ` [PATCH net-next v2 4/4] net: dqs: make struct dql more cache efficient Breno Leitao
2024-04-10 0:21 ` Jakub Kicinski
2024-04-10 13:52 ` Breno Leitao
2024-04-11 1:45 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410184549.5e5f77f2@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.