From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B62A063D; Thu, 11 Apr 2024 06:55:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712818516; cv=none; b=aapPD4F7sH2+26H+pmEjPGOwMeWc511JkC5wsk2ZTMz0G/jmcz1eIwYEEzIrLJ9NDonJ3lgIh0OMvjhwr8oQ1Mj5zOOmoD4wr+mTOu2IogYZZOax+gkiNZCMZ1LyxuqwszVxfkv/aE0MSkY5xyd7maCSxm4tDiLT7PZEMP44Ifk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712818516; c=relaxed/simple; bh=g5uFzpLBD5mMvoeBx8hAdujf+J4m8llZ6LvgrHfw/qs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aq0Qop138Q7x/7X0ILv2SYOypie2nFIJy5hC2j0qHfZwdtM4go/3BB0BZ6U0rh1bTdO/bCPWyt+Hjcch07tOLdUsplQmcgjMaOQBgvm/f9ZHEaioeIoBlGaFYUFGrHbLYCdSuTkuh68IZyNMbiH9/ipXZQH0tpwjw/Ygp2krH1I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BvNxYyjs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BvNxYyjs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27F3AC433C7; Thu, 11 Apr 2024 06:55:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712818516; bh=g5uFzpLBD5mMvoeBx8hAdujf+J4m8llZ6LvgrHfw/qs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BvNxYyjsAvCfq31BNCEVkvEyXMKqXg17zoo7EoJSAq2MhkmyRtqBo2DG+2Ssxh0TN 0mtKRf7SNGnt4dwLynbgqlfJ2dgqXrwu52VMW6bXvShCdH7WF89v9WoNW3hj0nIzba jffDoK1d5Fp3YmDVOciJfQQlJ7HDJTgcCy4GQEHNv6vh9TR9kBTl3ngPRT5G69VI85 MXgiWEZTCbnWSyzbZzKDdGh/+g/HuUsPq6nz2DqeYu2PtRF7nf5GCpJGY6aUJJGuUN QU9Fww/Ln77Q3okVcn7v0WKeIXxi5fKU2aDYHErN5KaEOfszOylPhdAl1U8b3PPGjD 72xWSWZmp3Wig== Date: Thu, 11 Apr 2024 07:55:11 +0100 From: Lee Jones To: AngeloGioacchino Del Regno Cc: ChiaEn Wu , pavel@ucw.cz, matthias.bgg@gmail.com, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, peterwu.pub@gmail.com, cy_huang@richtek.com Subject: Re: [PATCH] leds: mt6360: Fix the second LED can not enable torch mode by V4L2 Message-ID: <20240411065511.GB6194@google.com> References: Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, 09 Apr 2024, AngeloGioacchino Del Regno wrote: Not sure why, but this mail was sent unthreaded from the original. > Il 09/04/24 12:21, ChiaEn Wu ha scritto: > > V4L2 will disable strobe mode of the LED device when enable torch mode, > > but this logic will conflict with the "priv->fled_torch_used" > > in "mt6360_strobe_set()". So after enabling torch mode of the first > > LED, the second LED will not be able to enable torch mode correctly. > > > > Therefore, at the beginning of "mt6360_strobe_set()", check whether the > > state of the upcoming change and the current LED device state are the > > same, so as to avoid the above problem. > > > > Signed-off-by: ChiaEn Wu > > --- > > drivers/leds/flash/leds-mt6360.c | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/leds/flash/leds-mt6360.c b/drivers/leds/flash/leds-mt6360.c > > index a90de82f4568..1b75b4d36834 100644 > > --- a/drivers/leds/flash/leds-mt6360.c > > +++ b/drivers/leds/flash/leds-mt6360.c > > @@ -241,10 +241,20 @@ static int mt6360_strobe_set(struct led_classdev_flash *fl_cdev, bool state) > > u32 enable_mask = MT6360_STROBEN_MASK | MT6360_FLCSEN_MASK(led->led_no); > > u32 val = state ? MT6360_FLCSEN_MASK(led->led_no) : 0; > > u32 prev = priv->fled_strobe_used, curr; > > - int ret; > > + int ret = 0; > > I prefer that you leave ret uninitialized here, and... What's the reason for this? > > mutex_lock(&priv->lock); > > + /* > > + * If the state of the upcoming change is the same as the current LED > > + * device state, then skip the subsequent code to avoid conflict > > + * with the flow of turning on LED torch mode in V4L2. > > + */ > > + if (state == !!(BIT(led->led_no) & prev)) { > > + dev_info(lcdev->dev, "No change in strobe state [0x%x]\n", prev); > > ...that you do here, instead > > ret = 0; > goto unlock; > > With that addressed, > > Reviewed-by: AngeloGioacchino Del Regno > > -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9029CD1292 for ; Thu, 11 Apr 2024 06:55:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LQQ8gCTyfDfVJCKemHMYXItDJNI/Q7KmlHVg7SdT/iQ=; b=cdHT/mvpCkogL/ 8+X1H6Q1vBjIX5NAXTQym1aLOFiSBNEQ/ltTpvcorqDn0zwKz2Zvoap9adiuD0vYKnkIgYn9/Dr3Q vxxYrrDX/J4E7fEKjrV8F2ImWM1IwjWv8Ph5N/ZCeuP1/mVQrs1Yd35kWAQGrYTQk5pCaZsZZF9Bm 2j7O/00NWIrPTiyNun1/VyN30Ux36KpXBU9cVaCbF65Flenq1qbGAw5JWIlHx3gX/bZTp9iq82BjT 9qaWjX293jemZw/1Kzcq/gLJhZZ360N7s/l8Z08PUU2eLIbxjF3NI5dLuxAXpE5j9zEZVH4remzT1 lnjlR1B5adAyR0h10fwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruoLC-0000000AgYh-1Mq4; Thu, 11 Apr 2024 06:55:22 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruoL9-0000000AgWf-0i1d; Thu, 11 Apr 2024 06:55:20 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E7603CE2A7E; Thu, 11 Apr 2024 06:55:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27F3AC433C7; Thu, 11 Apr 2024 06:55:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712818516; bh=g5uFzpLBD5mMvoeBx8hAdujf+J4m8llZ6LvgrHfw/qs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BvNxYyjsAvCfq31BNCEVkvEyXMKqXg17zoo7EoJSAq2MhkmyRtqBo2DG+2Ssxh0TN 0mtKRf7SNGnt4dwLynbgqlfJ2dgqXrwu52VMW6bXvShCdH7WF89v9WoNW3hj0nIzba jffDoK1d5Fp3YmDVOciJfQQlJ7HDJTgcCy4GQEHNv6vh9TR9kBTl3ngPRT5G69VI85 MXgiWEZTCbnWSyzbZzKDdGh/+g/HuUsPq6nz2DqeYu2PtRF7nf5GCpJGY6aUJJGuUN QU9Fww/Ln77Q3okVcn7v0WKeIXxi5fKU2aDYHErN5KaEOfszOylPhdAl1U8b3PPGjD 72xWSWZmp3Wig== Date: Thu, 11 Apr 2024 07:55:11 +0100 From: Lee Jones To: AngeloGioacchino Del Regno Cc: ChiaEn Wu , pavel@ucw.cz, matthias.bgg@gmail.com, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, peterwu.pub@gmail.com, cy_huang@richtek.com Subject: Re: [PATCH] leds: mt6360: Fix the second LED can not enable torch mode by V4L2 Message-ID: <20240411065511.GB6194@google.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_235519_554301_A801F20B X-CRM114-Status: GOOD ( 24.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAwOSBBcHIgMjAyNCwgQW5nZWxvR2lvYWNjaGlubyBEZWwgUmVnbm8gd3JvdGU6CgpO b3Qgc3VyZSB3aHksIGJ1dCB0aGlzIG1haWwgd2FzIHNlbnQgdW50aHJlYWRlZCBmcm9tIHRoZSBv cmlnaW5hbC4KCj4gSWwgMDkvMDQvMjQgMTI6MjEsIENoaWFFbiBXdSBoYSBzY3JpdHRvOgo+ID4g VjRMMiB3aWxsIGRpc2FibGUgc3Ryb2JlIG1vZGUgb2YgdGhlIExFRCBkZXZpY2Ugd2hlbiBlbmFi bGUgdG9yY2ggbW9kZSwKPiA+IGJ1dCB0aGlzIGxvZ2ljIHdpbGwgY29uZmxpY3Qgd2l0aCB0aGUg InByaXYtPmZsZWRfdG9yY2hfdXNlZCIKPiA+IGluICJtdDYzNjBfc3Ryb2JlX3NldCgpIi4gU28g YWZ0ZXIgZW5hYmxpbmcgdG9yY2ggbW9kZSBvZiB0aGUgZmlyc3QKPiA+IExFRCwgdGhlIHNlY29u ZCBMRUQgd2lsbCBub3QgYmUgYWJsZSB0byBlbmFibGUgdG9yY2ggbW9kZSBjb3JyZWN0bHkuCj4g PiAKPiA+IFRoZXJlZm9yZSwgYXQgdGhlIGJlZ2lubmluZyBvZiAibXQ2MzYwX3N0cm9iZV9zZXQo KSIsIGNoZWNrIHdoZXRoZXIgdGhlCj4gPiBzdGF0ZSBvZiB0aGUgdXBjb21pbmcgY2hhbmdlIGFu ZCB0aGUgY3VycmVudCBMRUQgZGV2aWNlIHN0YXRlIGFyZSB0aGUKPiA+IHNhbWUsIHNvIGFzIHRv IGF2b2lkIHRoZSBhYm92ZSBwcm9ibGVtLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBDaGlhRW4g V3UgPGNoaWFlbl93dUByaWNodGVrLmNvbT4KPiA+IC0tLQo+ID4gICBkcml2ZXJzL2xlZHMvZmxh c2gvbGVkcy1tdDYzNjAuYyB8IDEyICsrKysrKysrKysrLQo+ID4gICAxIGZpbGUgY2hhbmdlZCwg MTEgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9sZWRzL2ZsYXNoL2xlZHMtbXQ2MzYwLmMgYi9kcml2ZXJzL2xlZHMvZmxhc2gvbGVkcy1t dDYzNjAuYwo+ID4gaW5kZXggYTkwZGU4MmY0NTY4Li4xYjc1YjRkMzY4MzQgMTAwNjQ0Cj4gPiAt LS0gYS9kcml2ZXJzL2xlZHMvZmxhc2gvbGVkcy1tdDYzNjAuYwo+ID4gKysrIGIvZHJpdmVycy9s ZWRzL2ZsYXNoL2xlZHMtbXQ2MzYwLmMKPiA+IEBAIC0yNDEsMTAgKzI0MSwyMCBAQCBzdGF0aWMg aW50IG10NjM2MF9zdHJvYmVfc2V0KHN0cnVjdCBsZWRfY2xhc3NkZXZfZmxhc2ggKmZsX2NkZXYs IGJvb2wgc3RhdGUpCj4gPiAgIAl1MzIgZW5hYmxlX21hc2sgPSBNVDYzNjBfU1RST0JFTl9NQVNL IHwgTVQ2MzYwX0ZMQ1NFTl9NQVNLKGxlZC0+bGVkX25vKTsKPiA+ICAgCXUzMiB2YWwgPSBzdGF0 ZSA/IE1UNjM2MF9GTENTRU5fTUFTSyhsZWQtPmxlZF9ubykgOiAwOwo+ID4gICAJdTMyIHByZXYg PSBwcml2LT5mbGVkX3N0cm9iZV91c2VkLCBjdXJyOwo+ID4gLQlpbnQgcmV0Owo+ID4gKwlpbnQg cmV0ID0gMDsKPiAKPiBJIHByZWZlciB0aGF0IHlvdSBsZWF2ZSByZXQgdW5pbml0aWFsaXplZCBo ZXJlLCBhbmQuLi4KCldoYXQncyB0aGUgcmVhc29uIGZvciB0aGlzPwoKPiA+ICAgCW11dGV4X2xv Y2soJnByaXYtPmxvY2spOwo+ID4gKwkvKgo+ID4gKwkgKiBJZiB0aGUgc3RhdGUgb2YgdGhlIHVw Y29taW5nIGNoYW5nZSBpcyB0aGUgc2FtZSBhcyB0aGUgY3VycmVudCBMRUQKPiA+ICsJICogZGV2 aWNlIHN0YXRlLCB0aGVuIHNraXAgdGhlIHN1YnNlcXVlbnQgY29kZSB0byBhdm9pZCBjb25mbGlj dAo+ID4gKwkgKiB3aXRoIHRoZSBmbG93IG9mIHR1cm5pbmcgb24gTEVEIHRvcmNoIG1vZGUgaW4g VjRMMi4KPiA+ICsJICovCj4gPiArCWlmIChzdGF0ZSA9PSAhIShCSVQobGVkLT5sZWRfbm8pICYg cHJldikpIHsKPiA+ICsJCWRldl9pbmZvKGxjZGV2LT5kZXYsICJObyBjaGFuZ2UgaW4gc3Ryb2Jl IHN0YXRlIFsweCV4XVxuIiwgcHJldik7Cj4gCj4gLi4udGhhdCB5b3UgZG8gaGVyZSwgaW5zdGVh ZAo+IAo+IAkJcmV0ID0gMDsKPiAJCWdvdG8gdW5sb2NrOwo+IAo+IFdpdGggdGhhdCBhZGRyZXNz ZWQsCj4gCj4gUmV2aWV3ZWQtYnk6IEFuZ2Vsb0dpb2FjY2hpbm8gRGVsIFJlZ25vIDxhbmdlbG9n aW9hY2NoaW5vLmRlbHJlZ25vQGNvbGxhb2JyYS5jb20+Cj4gCj4gCgotLSAKTGVlIEpvbmVzIFvm nY7nkLzmlq9dCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==