From: Jakub Kicinski <kuba@kernel.org>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
Jacob Keller <jacob.e.keller@intel.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
donald.hunter@redhat.com
Subject: Re: [PATCH net-next v2 3/3] tools/net/ynl: Add multi message support to ynl
Date: Thu, 11 Apr 2024 10:25:22 -0700 [thread overview]
Message-ID: <20240411102522.4eceedb9@kernel.org> (raw)
In-Reply-To: <20240410221108.37414-4-donald.hunter@gmail.com>
On Wed, 10 Apr 2024 23:11:08 +0100 Donald Hunter wrote:
> - def do(self, method, vals, flags=None):
> + def _op(self, method, vals, flags):
> + ops = [(method, vals, flags)]
> + return self._ops(ops)[0]
> +
> + def do(self, method, vals, flags=[]):
> return self._op(method, vals, flags)
Commenting here instead of on my own series but there are already tests
using dump=True in net-next:
tools/testing/selftests/drivers/net/stats.py: stats = netfam.qstats_get({}, dump=True)
tools/testing/selftests/net/nl_netdev.py: devs = nf.dev_get({}, dump=True)
"flags=[Netlink.NLM_F_DUMP]" is going to be a lot less convenient
to write :( Maybe we can keep support for both?
next prev parent reply other threads:[~2024-04-11 17:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 22:11 [PATCH net-next v2 0/3] netlink: Add nftables spec w/ multi messages Donald Hunter
2024-04-10 22:11 ` [PATCH net-next v2 1/3] doc/netlink/specs: Add draft nftables spec Donald Hunter
2024-04-10 22:11 ` [PATCH net-next v2 2/3] netfilter: nfnetlink: Handle ACK flags for batch messages Donald Hunter
2024-04-10 23:13 ` Pablo Neira Ayuso
2024-04-11 10:03 ` Donald Hunter
2024-04-10 22:11 ` [PATCH net-next v2 3/3] tools/net/ynl: Add multi message support to ynl Donald Hunter
2024-04-11 17:25 ` Jakub Kicinski [this message]
2024-04-12 9:53 ` Donald Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411102522.4eceedb9@kernel.org \
--to=kuba@kernel.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=kadlec@netfilter.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.