All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: John Watts <contact@jookia.org>
Cc: Jagan Teki <jagan@amarulasolutions.com>,
	Tom Rini <trini@konsulko.com>,
	u-boot@lists.denx.de
Subject: Re: [PATCH 0/2] sunxi: Support UART1 and UART2 on the T113
Date: Thu, 11 Apr 2024 13:37:38 +0100	[thread overview]
Message-ID: <20240411133738.3209aa12@donnerap.manchester.arm.com> (raw)
In-Reply-To: <20240411-t113serial-v1-0-41ff858a1235@jookia.org>

On Thu, 11 Apr 2024 15:14:14 +1000
John Watts <contact@jookia.org> wrote:

Hi John,

> The T113 supports UART1 and UART2 on PG and PD pins respectively.
> Add support for these in U-Boot so we can use them.

So those bits are just for the *debug* UARTs. Traditionally this is UART0,
with some particular pinmux, sometimes UART2 on older SoCs.

So is there a board that uses those pins for a debug console? I want to
avoid making this code even messier than it already is, without good
reasons. Also please note that I tried to clean this up here:
https://patchwork.ozlabs.org/project/uboot/patch/20240103001239.17482-20-andre.przywara@arm.com/

> Note: I'm not entirely sure if the PD pins should be default, they
> overlap with the LCD pins. I am however using this on a real board.

Is this a custom board? Could you consider using UART0 for debug then?
This one doesn't support RTS/CTS, so you do not waste the more capable
UARTs for debug.

Cheers,
Andre

> Signed-off-by: John Watts <contact@jookia.org>
> ---
> John Watts (2):
>       sunxi: Support UART1 on the T113
>       sunxi: Support UART2 on the T113
> 
>  arch/arm/mach-sunxi/board.c | 9 +++++++--
>  include/sunxi_gpio.h        | 1 +
>  2 files changed, 8 insertions(+), 2 deletions(-)
> ---
> base-commit: 777c28460947371ada40868dc994dfe8537d7115
> change-id: 20240411-t113serial-a6e9ca8d8848
> 
> Best regards,


  parent reply	other threads:[~2024-04-11 12:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11  5:14 [PATCH 0/2] sunxi: Support UART1 and UART2 on the T113 John Watts
2024-04-11  5:14 ` [PATCH 1/2] sunxi: Support UART1 " John Watts
2024-04-11  5:14 ` [PATCH 2/2] sunxi: Support UART2 " John Watts
2024-04-11 12:37 ` Andre Przywara [this message]
2024-04-11 20:58   ` [PATCH 0/2] sunxi: Support UART1 and " Jookia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240411133738.3209aa12@donnerap.manchester.arm.com \
    --to=andre.przywara@arm.com \
    --cc=contact@jookia.org \
    --cc=jagan@amarulasolutions.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.