From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE0771D42B0; Thu, 11 Apr 2024 17:03:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712855031; cv=none; b=a3MGateQUzF5OqDeIFJTo1WfbuXd12UWadkk4dbcHpfy92wrRaiW/2kz6n9PQghg1Pj0MH1uUzoPIffu2LlQoyDR/mdZBk11fh2qPVYcXkUpZ7SBXmZvcBjuaa8NYElSZ2fa79QU3uWTEwRpm62I8sizLzjwZK+7hfsu3XBuxBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712855031; c=relaxed/simple; bh=lPpn/1lYAEX/RQWD3CCHP7J3qXj3FuqzX1qZWbKaxOg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iGT3btVJNOqc70s2iyC3yLD3pakyUxUgZAnuDFspaqTk3lPuPgYgQzlaUvzjaWVyOGB0p1EXgfCHwJM5oY++wVLrd3r/8H5uu0hl5Mz116goASDeVQv9rIw8zhTMyGPWdUvOu9MeoBdGaPCJdMNYevVUqm9Vlxe7YVGgtJSd71E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P5iM75U/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P5iM75U/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0F8DC072AA; Thu, 11 Apr 2024 17:03:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712855031; bh=lPpn/1lYAEX/RQWD3CCHP7J3qXj3FuqzX1qZWbKaxOg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P5iM75U/t7PYTCi8TtGpwLMD5ieVL5+YT9KZ46/LNzwwR/aSgh9Ar/RljmXmBIbRx QJF+cxKGcEZ8+6XvtS9lVsF0mWec4sC/zIzwY+Jp/UqoM7wDe1UTckiN/i0xCnd53F nwEpmQwFloWIRagKAy82womP1csk32tyu3WZ+EhQ3csrBQxD1JkN8ACQUuYCRMWx8T LOdUXHGCT9RH68HLn74m5fmPCuciByXi0Iu+3CczesHPrFrHNn9j2OB5NZ7L/586hO kfZsNw1fVw99FffvbS9aVrCE8fQtHnDo+c8/yHBApzPtpCB4ltNXG0xf9WhYs5w9eS d7oOYz+1dsWsQ== Date: Thu, 11 Apr 2024 18:03:44 +0100 From: Lee Jones To: Bhargav Raviprakash Cc: linux-kernel@vger.kernel.org, m.nirmaladevi@ltts.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jpanis@baylibre.com, devicetree@vger.kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, lgirdwood@gmail.com, broonie@kernel.org, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nm@ti.com, vigneshr@ti.com, kristo@kernel.org, eblanc@baylibre.com Subject: Re: [PATCH v6 03/11] mfd: tps6594: add regmap config in match data Message-ID: <20240411170344.GK2399047@google.com> References: <20240408124047.191895-1-bhargav.r@ltts.com> <20240408124047.191895-4-bhargav.r@ltts.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240408124047.191895-4-bhargav.r@ltts.com> On Mon, 08 Apr 2024, Bhargav Raviprakash wrote: > Introduces a new struct tps6594_match_data. This struct holds fields for > chip id and regmap config. Using this struct in of_device_id data field. > This helps in adding support for TPS65224 PMIC. > > Signed-off-by: Bhargav Raviprakash > Acked-by: Julien Panis > --- > drivers/mfd/tps6594-i2c.c | 24 ++++++++++++++++-------- > drivers/mfd/tps6594-spi.c | 24 ++++++++++++++++-------- > include/linux/mfd/tps6594.h | 11 +++++++++++ > 3 files changed, 43 insertions(+), 16 deletions(-) > > diff --git a/drivers/mfd/tps6594-i2c.c b/drivers/mfd/tps6594-i2c.c > index c125b474b..9e2ed48b7 100644 > --- a/drivers/mfd/tps6594-i2c.c > +++ b/drivers/mfd/tps6594-i2c.c > @@ -192,10 +192,16 @@ static const struct regmap_config tps6594_i2c_regmap_config = { > .write = tps6594_i2c_write, > }; > > +static const struct tps6594_match_data match_data[] = { > + [TPS6594] = {TPS6594, &tps6594_i2c_regmap_config}, > + [TPS6593] = {TPS6593, &tps6594_i2c_regmap_config}, > + [LP8764] = {LP8764, &tps6594_i2c_regmap_config}, Nit: There should be spaces after the '{' and before the '}'. > +}; > + > static const struct of_device_id tps6594_i2c_of_match_table[] = { > - { .compatible = "ti,tps6594-q1", .data = (void *)TPS6594, }, > - { .compatible = "ti,tps6593-q1", .data = (void *)TPS6593, }, > - { .compatible = "ti,lp8764-q1", .data = (void *)LP8764, }, > + { .compatible = "ti,tps6594-q1", .data = &match_data[TPS6594], }, > + { .compatible = "ti,tps6593-q1", .data = &match_data[TPS6593], }, > + { .compatible = "ti,lp8764-q1", .data = &match_data[LP8764], }, Not keen on this. Why do you pass the regmap data through here and leave everything else to be matched on device ID? It would be better to keep passing the device ID through and match everything off of that. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5001C4345F for ; Thu, 11 Apr 2024 17:04:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y0UWOuLGHjvdGpHrf3j/IG8P5k9C8h3GSY108xZEl9o=; b=ckP2Hk1PqO7d0H KMm2vYVMuQnOkl42ugCsL6sVOztfiynAvwkZUv4++ARDHR4MVbDcwIdURn3WGIaCP0pxZNuzV1+Hr vZyMs8I9l8U/AdDvVxmcwrcl+fG9D/GPANZF0owfQvngZqPeOMSB3r9f2lWVR5FtskpeLBrxDtRBn 8LuKXDBu9AyeFIsh4GbTHy2rWS6bIexAmtsjX19sM4l2A7mEALSJeiH+6pLYBE2hUo726b47ILUaB bTkNOTcrTwFDNuqiE38ZGhg0lRTEsW+Ex4IZ8pPnztQmF0RXK9EnRtMnwMmQpsZYWo6bdY554lISl hpuC3T+nM94RwU8PCQog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruxq8-0000000DFXO-40Wl; Thu, 11 Apr 2024 17:03:57 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruxq5-0000000DFW0-49TI for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2024 17:03:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1BB91CE19D0; Thu, 11 Apr 2024 17:03:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0F8DC072AA; Thu, 11 Apr 2024 17:03:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712855031; bh=lPpn/1lYAEX/RQWD3CCHP7J3qXj3FuqzX1qZWbKaxOg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P5iM75U/t7PYTCi8TtGpwLMD5ieVL5+YT9KZ46/LNzwwR/aSgh9Ar/RljmXmBIbRx QJF+cxKGcEZ8+6XvtS9lVsF0mWec4sC/zIzwY+Jp/UqoM7wDe1UTckiN/i0xCnd53F nwEpmQwFloWIRagKAy82womP1csk32tyu3WZ+EhQ3csrBQxD1JkN8ACQUuYCRMWx8T LOdUXHGCT9RH68HLn74m5fmPCuciByXi0Iu+3CczesHPrFrHNn9j2OB5NZ7L/586hO kfZsNw1fVw99FffvbS9aVrCE8fQtHnDo+c8/yHBApzPtpCB4ltNXG0xf9WhYs5w9eS d7oOYz+1dsWsQ== Date: Thu, 11 Apr 2024 18:03:44 +0100 From: Lee Jones To: Bhargav Raviprakash Cc: linux-kernel@vger.kernel.org, m.nirmaladevi@ltts.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jpanis@baylibre.com, devicetree@vger.kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, lgirdwood@gmail.com, broonie@kernel.org, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nm@ti.com, vigneshr@ti.com, kristo@kernel.org, eblanc@baylibre.com Subject: Re: [PATCH v6 03/11] mfd: tps6594: add regmap config in match data Message-ID: <20240411170344.GK2399047@google.com> References: <20240408124047.191895-1-bhargav.r@ltts.com> <20240408124047.191895-4-bhargav.r@ltts.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240408124047.191895-4-bhargav.r@ltts.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240411_100354_236731_EAE92AB7 X-CRM114-Status: GOOD ( 17.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAwOCBBcHIgMjAyNCwgQmhhcmdhdiBSYXZpcHJha2FzaCB3cm90ZToKCj4gSW50cm9k dWNlcyBhIG5ldyBzdHJ1Y3QgdHBzNjU5NF9tYXRjaF9kYXRhLiBUaGlzIHN0cnVjdCBob2xkcyBm aWVsZHMgZm9yCj4gY2hpcCBpZCBhbmQgcmVnbWFwIGNvbmZpZy4gVXNpbmcgdGhpcyBzdHJ1Y3Qg aW4gb2ZfZGV2aWNlX2lkIGRhdGEgZmllbGQuCj4gVGhpcyBoZWxwcyBpbiBhZGRpbmcgc3VwcG9y dCBmb3IgVFBTNjUyMjQgUE1JQy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBCaGFyZ2F2IFJhdmlwcmFr YXNoIDxiaGFyZ2F2LnJAbHR0cy5jb20+Cj4gQWNrZWQtYnk6IEp1bGllbiBQYW5pcyA8anBhbmlz QGJheWxpYnJlLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9tZmQvdHBzNjU5NC1pMmMuYyAgIHwgMjQg KysrKysrKysrKysrKysrKy0tLS0tLS0tCj4gIGRyaXZlcnMvbWZkL3RwczY1OTQtc3BpLmMgICB8 IDI0ICsrKysrKysrKysrKysrKystLS0tLS0tLQo+ICBpbmNsdWRlL2xpbnV4L21mZC90cHM2NTk0 LmggfCAxMSArKysrKysrKysrKwo+ICAzIGZpbGVzIGNoYW5nZWQsIDQzIGluc2VydGlvbnMoKyks IDE2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC90cHM2NTk0LWky Yy5jIGIvZHJpdmVycy9tZmQvdHBzNjU5NC1pMmMuYwo+IGluZGV4IGMxMjViNDc0Yi4uOWUyZWQ0 OGI3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWZkL3RwczY1OTQtaTJjLmMKPiArKysgYi9kcml2 ZXJzL21mZC90cHM2NTk0LWkyYy5jCj4gQEAgLTE5MiwxMCArMTkyLDE2IEBAIHN0YXRpYyBjb25z dCBzdHJ1Y3QgcmVnbWFwX2NvbmZpZyB0cHM2NTk0X2kyY19yZWdtYXBfY29uZmlnID0gewo+ICAJ LndyaXRlID0gdHBzNjU5NF9pMmNfd3JpdGUsCj4gIH07Cj4gIAo+ICtzdGF0aWMgY29uc3Qgc3Ry dWN0IHRwczY1OTRfbWF0Y2hfZGF0YSBtYXRjaF9kYXRhW10gPSB7Cj4gKwlbVFBTNjU5NF0gPSB7 VFBTNjU5NCwgJnRwczY1OTRfaTJjX3JlZ21hcF9jb25maWd9LAo+ICsJW1RQUzY1OTNdID0ge1RQ UzY1OTMsICZ0cHM2NTk0X2kyY19yZWdtYXBfY29uZmlnfSwKPiArCVtMUDg3NjRdID0ge0xQODc2 NCwgJnRwczY1OTRfaTJjX3JlZ21hcF9jb25maWd9LAoKTml0OiBUaGVyZSBzaG91bGQgYmUgc3Bh Y2VzIGFmdGVyIHRoZSAneycgYW5kIGJlZm9yZSB0aGUgJ30nLgoKPiArfTsKPiArCj4gIHN0YXRp YyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIHRwczY1OTRfaTJjX29mX21hdGNoX3RhYmxlW10g PSB7Cj4gLQl7IC5jb21wYXRpYmxlID0gInRpLHRwczY1OTQtcTEiLCAuZGF0YSA9ICh2b2lkICop VFBTNjU5NCwgfSwKPiAtCXsgLmNvbXBhdGlibGUgPSAidGksdHBzNjU5My1xMSIsIC5kYXRhID0g KHZvaWQgKilUUFM2NTkzLCB9LAo+IC0JeyAuY29tcGF0aWJsZSA9ICJ0aSxscDg3NjQtcTEiLCAg LmRhdGEgPSAodm9pZCAqKUxQODc2NCwgIH0sCj4gKwl7IC5jb21wYXRpYmxlID0gInRpLHRwczY1 OTQtcTEiLCAuZGF0YSA9ICZtYXRjaF9kYXRhW1RQUzY1OTRdLCB9LAo+ICsJeyAuY29tcGF0aWJs ZSA9ICJ0aSx0cHM2NTkzLXExIiwgLmRhdGEgPSAmbWF0Y2hfZGF0YVtUUFM2NTkzXSwgfSwKPiAr CXsgLmNvbXBhdGlibGUgPSAidGksbHA4NzY0LXExIiwgIC5kYXRhID0gJm1hdGNoX2RhdGFbTFA4 NzY0XSwgfSwKCk5vdCBrZWVuIG9uIHRoaXMuICBXaHkgZG8geW91IHBhc3MgdGhlIHJlZ21hcCBk YXRhIHRocm91Z2ggaGVyZSBhbmQKbGVhdmUgZXZlcnl0aGluZyBlbHNlIHRvIGJlIG1hdGNoZWQg b24gZGV2aWNlIElEPyAgSXQgd291bGQgYmUgYmV0dGVyIHRvCmtlZXAgcGFzc2luZyB0aGUgZGV2 aWNlIElEIHRocm91Z2ggYW5kIG1hdGNoIGV2ZXJ5dGhpbmcgb2ZmIG9mIHRoYXQuCgoKLS0gCkxl ZSBKb25lcyBb5p2O55C85pavXQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=