From: kernel test robot <lkp@intel.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [axboe-block:rw_iter 232/415] drivers/watchdog/pc87413_wdt.c:340: warning: Function parameter or struct member 'iocb' not described in 'pc87413_write'
Date: Thu, 11 Apr 2024 17:25:50 +0800 [thread overview]
Message-ID: <202404111744.mJS15EMo-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git rw_iter
head: 2cdbd541e4481cb9cbd08913e0586dc8a2570aec
commit: cb5e015fa89ea7fba300ff06cd6be7c3572ee42d [232/415] watchdog: pc87413_wdt: convert to read/write iterators
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240411/202404111744.mJS15EMo-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240411/202404111744.mJS15EMo-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404111744.mJS15EMo-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/watchdog/pc87413_wdt.c:340: warning: Function parameter or struct member 'iocb' not described in 'pc87413_write'
>> drivers/watchdog/pc87413_wdt.c:340: warning: Function parameter or struct member 'from' not described in 'pc87413_write'
>> drivers/watchdog/pc87413_wdt.c:340: warning: Excess function parameter 'file' description in 'pc87413_write'
>> drivers/watchdog/pc87413_wdt.c:340: warning: Excess function parameter 'data' description in 'pc87413_write'
>> drivers/watchdog/pc87413_wdt.c:340: warning: Excess function parameter 'len' description in 'pc87413_write'
>> drivers/watchdog/pc87413_wdt.c:340: warning: Excess function parameter 'ppos' description in 'pc87413_write'
vim +340 drivers/watchdog/pc87413_wdt.c
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 327
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 328 /**
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 329 * pc87413_write:
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 330 * @file: file handle to the watchdog
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 331 * @data: data buffer to write
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 332 * @len: length in bytes
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 333 * @ppos: pointer to the position to write. No seeks allowed
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 334 *
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 335 * A write to a watchdog device is defined as a keepalive signal. Any
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 336 * write of data will do, as we we don't define content meaning.
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 337 */
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 338
cb5e015fa89ea7 drivers/watchdog/pc87413_wdt.c Jens Axboe 2024-04-08 339 static ssize_t pc87413_write(struct kiocb *iocb, struct iov_iter *from)
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 @340 {
cb5e015fa89ea7 drivers/watchdog/pc87413_wdt.c Jens Axboe 2024-04-08 341 size_t len = iov_iter_count(from);
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 342 /* See if we got the magic character 'V' and reload the timer */
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 343 if (len) {
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 344 if (!nowayout) {
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 345 size_t i;
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 346
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 347 /* reset expect flag */
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 348 expect_close = 0;
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 349
aee334c23c9a55 drivers/watchdog/pc87413_wdt.c Alan Cox 2008-05-19 350 /* scan to see whether or not we got the
aee334c23c9a55 drivers/watchdog/pc87413_wdt.c Alan Cox 2008-05-19 351 magic character */
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 352 for (i = 0; i != len; i++) {
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 353 char c;
cb5e015fa89ea7 drivers/watchdog/pc87413_wdt.c Jens Axboe 2024-04-08 354 if (get_iter(c, from))
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 355 return -EFAULT;
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 356 if (c == 'V')
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 357 expect_close = 42;
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 358 }
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 359 }
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 360
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 361 /* someone wrote to us, we should reload the timer */
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 362 pc87413_refresh();
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 363 }
00b3b3e6605d74 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-10-16 364 return len;
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 365 }
789fc0adbaf3a3 drivers/char/watchdog/pc87413_wdt.c Sven Anders & Marcus Junker 2006-08-24 366
:::::: The code at line 340 was first introduced by commit
:::::: 789fc0adbaf3a3ca95a3894aedacfc01863e8ae3 [WATCHDOG] NS pc87413-wdt Watchdog driver
:::::: TO: Sven Anders & Marcus Junker <anders@anduras.de, junker@anduras.de>
:::::: CC: Wim Van Sebroeck <wim@iguana.be>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-04-11 9:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202404111744.mJS15EMo-lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.