From: Jakub Kicinski <kuba@kernel.org>
To: Suman Ghosh <sumang@marvell.com>,
Sunil Goutham <sgoutham@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
hariprasad <hkelam@marvell.com>
Cc: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Subbaraya Sundeep" <sbhatta@marvell.com>
Subject: Re: [PATCH net] octeontx2-pf: fix FLOW_DIS_IS_FRAGMENT implementation
Date: Thu, 11 Apr 2024 19:59:47 -0700 [thread overview]
Message-ID: <20240411195947.54e9cebc@kernel.org> (raw)
In-Reply-To: <20240410134303.21560-1-ast@fiberby.net>
On Wed, 10 Apr 2024 13:43:01 +0000 Asbjørn Sloth Tønnesen wrote:
> Upon reviewing the flower control flags handling in
> this driver, I notice that the key wasn't being used,
> only the mask.
>
> Ie. `tc flower ... ip_flags nofrag` was hardware
> offloaded as `... ip_flags frag`.
>
> Only compile tested, no access to HW.
>
> Fixes: c672e3727989 ("octeontx2-pf: Add support to filter packet based on IP fragment")
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Marvell folks, please provide timely review.
It is your duty as documented in
Documentation/maintainer/feature-and-driver-maintainers.rst
next prev parent reply other threads:[~2024-04-12 2:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 13:43 [PATCH net] octeontx2-pf: fix FLOW_DIS_IS_FRAGMENT implementation Asbjørn Sloth Tønnesen
2024-04-10 22:33 ` Jacob Keller
2024-04-12 2:59 ` Jakub Kicinski [this message]
2024-04-12 5:34 ` [EXTERNAL] " Suman Ghosh
2024-04-12 9:01 ` Asbjørn Sloth Tønnesen
2024-04-12 10:25 ` Asbjørn Sloth Tønnesen
2024-04-12 11:18 ` Asbjørn Sloth Tønnesen
2024-04-12 11:52 ` Sunil Kovvuri Goutham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411195947.54e9cebc@kernel.org \
--to=kuba@kernel.org \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.