From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thorsten Leemhuis <linux@leemhuis.info>
Cc: Sasha Levin <sashal@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
stable@vger.kernel.org, workflows@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/4] docs: stable-kernel-rules: mention "no semi-automatic backport"
Date: Thu, 11 Apr 2024 09:40:25 +0200 [thread overview]
Message-ID: <2024041123-earthling-primarily-4656@gregkh> (raw)
In-Reply-To: <3f395eca-fc24-469b-b5fc-de47ab2a6861@leemhuis.info>
On Thu, Apr 11, 2024 at 08:59:39AM +0200, Thorsten Leemhuis wrote:
> On 11.04.24 07:29, Greg Kroah-Hartman wrote:
> > On Thu, Apr 11, 2024 at 07:25:04AM +0200, Thorsten Leemhuis wrote:
> >> Some developers deliberately steer clear of 'Fixes:' tags to prevent
> >> changes from being backported semi-automatically by the stable team.
> >> That somewhat undermines the reason for the existence of the Fixes: tag,
> >> hence point out there is an alternative to reach the same effect.
> >>
> >> Link: https://lore.kernel.org/all/dfd87673-c581-4b4b-b37a-1cf5c817240d@leemhuis.info/
> >> Signed-off-by: Thorsten Leemhuis <linux@leemhuis.info>
> >> ---
> >> Documentation/process/stable-kernel-rules.rst | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/Documentation/process/stable-kernel-rules.rst b/Documentation/process/stable-kernel-rules.rst
> >> index 7bb16d42a51833..ebd57cb9277f7b 100644
> >> --- a/Documentation/process/stable-kernel-rules.rst
> >> +++ b/Documentation/process/stable-kernel-rules.rst
> >> @@ -117,6 +117,12 @@ comment to pass arbitrary or predefined notes:
> >> Note, such tagging is unnecessary if the stable team can derive the
> >> appropriate versions from Fixes: tags.
> >>
> >> + * Prevent semi-automatic backporting of changes carrying a 'Fixes:' tag:
> >> +
> >> + .. code-block:: none
> >> +
> >> + Cc: <stable@vger.kernel.org> # no semi-automatic backport
> >
> > I do not understand, why are you saying "cc: stable" here if you do NOT
> > want it backported?
>
> Because the only alternative the developers have to make the stable team
> not pick a single patch[1] is to deliberately omit a Fixes: tag even if
> the patch normally should have one. Like it was done here:
> https://lore.kernel.org/all/cover.1712226175.git.antony.antony@secunet.com/
That feels odd, but ok I now see the need for this for some minor set of
changes (i.e. this has rarely come up in the past 15+ years)
> And that somehow felt wrong to me, as discussed earlier in
> https://lore.kernel.org/all/dfd87673-c581-4b4b-b37a-1cf5c817240d@leemhuis.info/
>
> [1] e.g. if they don't have or want their whole subsystem marked as
> 'ignore for the AUTOSEL and the "Fixes tag only" tools'
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/ignore_list
>
> > And what do you mean by "semi-automatic"?
>
> E.g. 'ignore for the AUTOSEL and the "Fixes tag only" tools'. That was
> the best term I came up with.
Thinking about it more, I think we need to be much more explicit, and
provide the reason why.
How about:
cc: <do-not-apply-to-stable@kernel.org> # Reason goes here, and must be present
and we can make that address be routed to /dev/null just like
<stable@kernel.org> is?
thanks,
greg k-h
next prev parent reply other threads:[~2024-04-11 7:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 5:25 [PATCH v1 0/4] docs: stable-kernel-rules: fine-tuning and 'no semi-automatic backport' Thorsten Leemhuis
2024-04-11 5:25 ` [PATCH v1 1/4] docs: stable-kernel-rules: reduce redundancy Thorsten Leemhuis
2024-04-11 5:27 ` Greg Kroah-Hartman
2024-04-11 5:25 ` [PATCH v1 2/4] docs: stable-kernel-rules: mention "no semi-automatic backport" Thorsten Leemhuis
2024-04-11 5:29 ` Greg Kroah-Hartman
2024-04-11 6:59 ` Thorsten Leemhuis
2024-04-11 7:40 ` Greg Kroah-Hartman [this message]
2024-04-11 7:50 ` Thorsten Leemhuis
2024-04-11 9:13 ` Greg Kroah-Hartman
2024-04-11 9:19 ` Geert Uytterhoeven
2024-04-11 9:53 ` Greg Kroah-Hartman
2024-04-11 9:57 ` Thorsten Leemhuis
2024-04-11 15:12 ` Greg Kroah-Hartman
2024-04-11 5:25 ` [PATCH v1 3/4] docs: stable-kernel-rules: call mainline by its name and change example Thorsten Leemhuis
2024-04-11 5:30 ` Greg Kroah-Hartman
2024-04-11 5:50 ` Thorsten Leemhuis
2024-04-11 6:10 ` Greg Kroah-Hartman
2024-04-11 6:50 ` Thorsten Leemhuis
2024-04-11 6:56 ` Greg Kroah-Hartman
2024-04-11 7:18 ` Thorsten Leemhuis
2024-04-11 5:25 ` [PATCH v1 4/4] docs: stable-kernel-rules: remove code-labels tags Thorsten Leemhuis
2024-04-11 5:31 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024041123-earthling-primarily-4656@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.