From: Yuntao Wang <ytcoode@gmail.com>
To: mhiramat@kernel.org
Cc: akpm@linux-foundation.org, arnd@arndb.de,
christophe.leroy@csgroup.eu, geert@linux-m68k.org,
jpoimboe@kernel.org, kjlx@templeofstupid.com,
linux-kernel@vger.kernel.org, ndesaulniers@google.com,
peterz@infradead.org, rppt@kernel.org, tglx@linutronix.de,
tj@kernel.org, ytcoode@gmail.com
Subject: [PATCH v2 1/2] init/main.c: Fix potential static_command_line memory overflow
Date: Fri, 12 Apr 2024 16:17:32 +0800 [thread overview]
Message-ID: <20240412081733.35925-2-ytcoode@gmail.com> (raw)
In-Reply-To: <20240412081733.35925-1-ytcoode@gmail.com>
We allocate memory of size 'xlen + strlen(boot_command_line) + 1' for
static_command_line, but the strings copied into static_command_line are
extra_command_line and command_line, rather than extra_command_line and
boot_command_line.
When strlen(command_line) > strlen(boot_command_line), static_command_line
will overflow.
This patch just recovers strlen(command_line) which was miss-consolidated
with strlen(boot_command_line) in the commit f5c7310ac73e ("init/main: add
checks for the return value of memblock_alloc*()")
Fixes: f5c7310ac73e ("init/main: add checks for the return value of memblock_alloc*()")
Signed-off-by: Yuntao Wang <ytcoode@gmail.com>
---
init/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/init/main.c b/init/main.c
index 881f6230ee59..5dcf5274c09c 100644
--- a/init/main.c
+++ b/init/main.c
@@ -636,6 +636,8 @@ static void __init setup_command_line(char *command_line)
if (!saved_command_line)
panic("%s: Failed to allocate %zu bytes\n", __func__, len + ilen);
+ len = xlen + strlen(command_line) + 1;
+
static_command_line = memblock_alloc(len, SMP_CACHE_BYTES);
if (!static_command_line)
panic("%s: Failed to allocate %zu bytes\n", __func__, len);
--
2.44.0
next prev parent reply other threads:[~2024-04-12 8:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 3:21 [PATCH] init/main.c: Fix potential static_command_line memory overflow Yuntao Wang
2024-04-11 7:23 ` Geert Uytterhoeven
2024-04-11 13:21 ` Mike Rapoport
2024-04-11 14:27 ` Yuntao Wang
2024-04-11 15:08 ` Masami Hiramatsu
2024-04-11 15:47 ` Yuntao Wang
2024-04-12 3:51 ` Yuntao Wang
2024-04-12 5:15 ` Masami Hiramatsu
2024-04-12 8:17 ` [PATCH v2 0/2] " Yuntao Wang
2024-04-12 8:17 ` Yuntao Wang [this message]
2024-04-12 8:17 ` [PATCH v2 2/2] init/main.c: Minor cleanup for the setup_command_line() function Yuntao Wang
2024-04-12 15:58 ` [PATCH v2 0/2] Fix potential static_command_line memory overflow Masami Hiramatsu
2024-04-11 14:29 ` [PATCH] init/main.c: " Masami Hiramatsu
2024-04-11 14:59 ` Yuntao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412081733.35925-2-ytcoode@gmail.com \
--to=ytcoode@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=christophe.leroy@csgroup.eu \
--cc=geert@linux-m68k.org \
--cc=jpoimboe@kernel.org \
--cc=kjlx@templeofstupid.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.