All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [l1k:spdm-future 22/46] lib/spdm/req-sysfs.c:176:55: warning: omitting the parameter name in a function definition is a C2x extension
Date: Fri, 12 Apr 2024 18:56:41 +0800	[thread overview]
Message-ID: <202404121811.DTbeyf2a-lkp@intel.com> (raw)

tree:   https://github.com/l1k/linux spdm-future
head:   04f0af4bcc5b52f17682de7c27eb469f6f794197
commit: f94b1e338bc3a4fc1bdc262899734d0699b9a747 [22/46] PCI/CMA: Expose in sysfs a log of received signatures
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240412/202404121811.DTbeyf2a-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240412/202404121811.DTbeyf2a-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404121811.DTbeyf2a-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> lib/spdm/req-sysfs.c:176:55: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
     176 | static ssize_t spdm_read_combined_prefix(struct file *, struct kobject *,
         |                                                       ^
   lib/spdm/req-sysfs.c:176:73: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
     176 | static ssize_t spdm_read_combined_prefix(struct file *, struct kobject *,
         |                                                                         ^
   2 warnings generated.


vim +176 lib/spdm/req-sysfs.c

   175	
 > 176	static ssize_t spdm_read_combined_prefix(struct file *, struct kobject *,
   177						 struct bin_attribute *attr,
   178						 char *buf, loff_t off, size_t count)
   179	{
   180		struct spdm_log_entry *log = attr->private;
   181	
   182		/*
   183		 * SPDM 1.0 and 1.1 do not add a combined prefix to the hash
   184		 * before computing the signature, so return an empty file.
   185		 */
   186		if (log->version <= 0x11)
   187			return 0;
   188	
   189		void *tmp __free(kfree) = kmalloc(SPDM_COMBINED_PREFIX_SZ, GFP_KERNEL);
   190		if (!tmp)
   191			return -ENOMEM;
   192	
   193		spdm_create_combined_prefix(log->version, log->spdm_context.var, tmp);
   194		memcpy(buf, tmp + off, count);
   195		return count;
   196	}
   197	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-04-12 10:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202404121811.DTbeyf2a-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=lukas@wunner.de \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.