All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Kan Liang <kan.liang@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: [PATCH 0/4] perf annotate-data: A couple of small updates
Date: Fri, 12 Apr 2024 11:33:06 -0700	[thread overview]
Message-ID: <20240412183310.2518474-1-namhyung@kernel.org> (raw)

Hello,

I am working on improving quality of the data type profiling and I
found some issues.  One is when more than one variables are placed at
the same location.  Then it should find the correct one based on the
given info rather than checking the first one and bailing out.  This
one (patch 2) can go to the perf-tools tree.

Another issue is use of the stack pointe register when it's not the
frame base register.  I found a case where rbp is used as the frame
base but rsp is also used to point some stack variables.  And it
confuses itself how to interpret the type of the variable.

I think these are rare cases but it would depends on the code pattern
and compiler behavior.  Anyway I can see a tiny improvement in my data
with this change. :)

Thanks,
Namhyung


Namhyung Kim (4):
  perf annotate-data: Improve debug message with location info
  perf dwarf-aux: Check pointer offset when checking variables
  perf dwarf-aux: Check variable address range properly
  perf annotate-data: Handle RSP if it's not the FB register

 tools/perf/util/annotate-data.c | 126 +++++++++++++++++++++++++-------
 tools/perf/util/dwarf-aux.c     |  35 ++++++---
 2 files changed, 125 insertions(+), 36 deletions(-)


base-commit: 0ffc8fca5c15a70f32c8aff12c566bbd3991bd0a
-- 
2.44.0.683.g7961c838ac-goog


             reply	other threads:[~2024-04-12 18:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12 18:33 Namhyung Kim [this message]
2024-04-12 18:33 ` [PATCH 1/4] perf annotate-data: Improve debug message with location info Namhyung Kim
2024-04-16 14:23   ` Arnaldo Carvalho de Melo
2024-04-12 18:33 ` [PATCH 2/4] perf dwarf-aux: Check pointer offset when checking variables Namhyung Kim
2024-04-12 18:33 ` [PATCH 3/4] perf dwarf-aux: Check variable address range properly Namhyung Kim
2024-04-12 18:33 ` [PATCH 4/4] perf annotate-data: Handle RSP if it's not the FB register Namhyung Kim
2024-04-16 21:06 ` [PATCH 0/4] perf annotate-data: A couple of small updates Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240412183310.2518474-1-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.