From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [broonie-sound:for-next 12/13] sound/soc/codecs/cs35l41.c:1129 cs35l41_dsp_init() warn: missing error code 'ret'
Date: Sat, 13 Apr 2024 17:59:37 +0800 [thread overview]
Message-ID: <202404131743.unitkCiT-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Stefan Binding <sbinding@opensource.cirrus.com>
CC: Mark Brown <broonie@kernel.org>
CC: Richard Fitzgerald <rf@opensource.cirrus.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
head: 47c44619b51cb0367249a1f5c53afd28cfd9dd82
commit: eefb831d2e4dd58d58002a2ef75ff989e073230d [12/13] ASoC: cs35l41: Update DSP1RX5/6 Sources for DSP config
:::::: branch date: 22 hours ago
:::::: commit date: 2 days ago
config: mips-randconfig-r071-20240413 (https://download.01.org/0day-ci/archive/20240413/202404131743.unitkCiT-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 13.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202404131743.unitkCiT-lkp@intel.com/
smatch warnings:
sound/soc/codecs/cs35l41.c:1129 cs35l41_dsp_init() warn: missing error code 'ret'
vim +/ret +1129 sound/soc/codecs/cs35l41.c
6450ef55905688 David Rhodes 2021-09-07 1093
bae9e13fc55cbc David Rhodes 2021-10-29 1094 static int cs35l41_dsp_init(struct cs35l41_private *cs35l41)
bae9e13fc55cbc David Rhodes 2021-10-29 1095 {
bae9e13fc55cbc David Rhodes 2021-10-29 1096 struct wm_adsp *dsp;
eefb831d2e4dd5 Stefan Binding 2024-04-11 1097 uint32_t dsp1rx5_src;
bae9e13fc55cbc David Rhodes 2021-10-29 1098 int ret;
bae9e13fc55cbc David Rhodes 2021-10-29 1099
bae9e13fc55cbc David Rhodes 2021-10-29 1100 dsp = &cs35l41->dsp;
bae9e13fc55cbc David Rhodes 2021-10-29 1101 dsp->part = "cs35l41";
bae9e13fc55cbc David Rhodes 2021-10-29 1102 dsp->fw = 9; /* 9 is WM_ADSP_FW_SPK_PROT in wm_adsp.c */
f517ba4924ad02 Charles Keepax 2022-01-07 1103 dsp->toggle_preload = true;
0db99577c4cddc Stefan Binding 2022-05-09 1104
0db99577c4cddc Stefan Binding 2022-05-09 1105 cs35l41_configure_cs_dsp(cs35l41->dev, cs35l41->regmap, &dsp->cs_dsp);
bae9e13fc55cbc David Rhodes 2021-10-29 1106
ff8aad072e6388 Stefan Binding 2022-05-09 1107 ret = cs35l41_write_fs_errata(cs35l41->dev, cs35l41->regmap);
ff8aad072e6388 Stefan Binding 2022-05-09 1108 if (ret < 0)
bae9e13fc55cbc David Rhodes 2021-10-29 1109 return ret;
bae9e13fc55cbc David Rhodes 2021-10-29 1110
bae9e13fc55cbc David Rhodes 2021-10-29 1111 ret = wm_halo_init(dsp);
bae9e13fc55cbc David Rhodes 2021-10-29 1112 if (ret) {
bae9e13fc55cbc David Rhodes 2021-10-29 1113 dev_err(cs35l41->dev, "wm_halo_init failed: %d\n", ret);
bae9e13fc55cbc David Rhodes 2021-10-29 1114 return ret;
bae9e13fc55cbc David Rhodes 2021-10-29 1115 }
bae9e13fc55cbc David Rhodes 2021-10-29 1116
eefb831d2e4dd5 Stefan Binding 2024-04-11 1117 switch (cs35l41->hw_cfg.bst_type) {
eefb831d2e4dd5 Stefan Binding 2024-04-11 1118 case CS35L41_INT_BOOST:
eefb831d2e4dd5 Stefan Binding 2024-04-11 1119 case CS35L41_SHD_BOOST_ACTV:
eefb831d2e4dd5 Stefan Binding 2024-04-11 1120 dsp1rx5_src = CS35L41_INPUT_SRC_VPMON;
eefb831d2e4dd5 Stefan Binding 2024-04-11 1121 break;
eefb831d2e4dd5 Stefan Binding 2024-04-11 1122 case CS35L41_EXT_BOOST:
eefb831d2e4dd5 Stefan Binding 2024-04-11 1123 case CS35L41_SHD_BOOST_PASS:
eefb831d2e4dd5 Stefan Binding 2024-04-11 1124 dsp1rx5_src = CS35L41_INPUT_SRC_VBSTMON;
eefb831d2e4dd5 Stefan Binding 2024-04-11 1125 break;
eefb831d2e4dd5 Stefan Binding 2024-04-11 1126 default:
eefb831d2e4dd5 Stefan Binding 2024-04-11 1127 dev_err(cs35l41->dev, "wm_halo_init failed - Invalid Boost Type: %d\n",
eefb831d2e4dd5 Stefan Binding 2024-04-11 1128 cs35l41->hw_cfg.bst_type);
eefb831d2e4dd5 Stefan Binding 2024-04-11 @1129 goto err_dsp;
eefb831d2e4dd5 Stefan Binding 2024-04-11 1130 }
eefb831d2e4dd5 Stefan Binding 2024-04-11 1131
eefb831d2e4dd5 Stefan Binding 2024-04-11 1132 ret = regmap_write(cs35l41->regmap, CS35L41_DSP1_RX5_SRC, dsp1rx5_src);
bae9e13fc55cbc David Rhodes 2021-10-29 1133 if (ret < 0) {
eefb831d2e4dd5 Stefan Binding 2024-04-11 1134 dev_err(cs35l41->dev, "Write DSP1RX5_SRC: %d failed: %d\n", dsp1rx5_src, ret);
bae9e13fc55cbc David Rhodes 2021-10-29 1135 goto err_dsp;
bae9e13fc55cbc David Rhodes 2021-10-29 1136 }
eefb831d2e4dd5 Stefan Binding 2024-04-11 1137 ret = regmap_write(cs35l41->regmap, CS35L41_DSP1_RX6_SRC, CS35L41_INPUT_SRC_VBSTMON);
bae9e13fc55cbc David Rhodes 2021-10-29 1138 if (ret < 0) {
eefb831d2e4dd5 Stefan Binding 2024-04-11 1139 dev_err(cs35l41->dev, "Write CS35L41_INPUT_SRC_VBSTMON failed: %d\n", ret);
bae9e13fc55cbc David Rhodes 2021-10-29 1140 goto err_dsp;
bae9e13fc55cbc David Rhodes 2021-10-29 1141 }
bae9e13fc55cbc David Rhodes 2021-10-29 1142 ret = regmap_write(cs35l41->regmap, CS35L41_DSP1_RX7_SRC,
bae9e13fc55cbc David Rhodes 2021-10-29 1143 CS35L41_INPUT_SRC_TEMPMON);
bae9e13fc55cbc David Rhodes 2021-10-29 1144 if (ret < 0) {
bae9e13fc55cbc David Rhodes 2021-10-29 1145 dev_err(cs35l41->dev, "Write INPUT_SRC_TEMPMON failed: %d\n", ret);
bae9e13fc55cbc David Rhodes 2021-10-29 1146 goto err_dsp;
bae9e13fc55cbc David Rhodes 2021-10-29 1147 }
bae9e13fc55cbc David Rhodes 2021-10-29 1148 ret = regmap_write(cs35l41->regmap, CS35L41_DSP1_RX8_SRC,
bae9e13fc55cbc David Rhodes 2021-10-29 1149 CS35L41_INPUT_SRC_RSVD);
bae9e13fc55cbc David Rhodes 2021-10-29 1150 if (ret < 0) {
bae9e13fc55cbc David Rhodes 2021-10-29 1151 dev_err(cs35l41->dev, "Write INPUT_SRC_RSVD failed: %d\n", ret);
bae9e13fc55cbc David Rhodes 2021-10-29 1152 goto err_dsp;
bae9e13fc55cbc David Rhodes 2021-10-29 1153 }
bae9e13fc55cbc David Rhodes 2021-10-29 1154
bae9e13fc55cbc David Rhodes 2021-10-29 1155 return 0;
bae9e13fc55cbc David Rhodes 2021-10-29 1156
bae9e13fc55cbc David Rhodes 2021-10-29 1157 err_dsp:
bae9e13fc55cbc David Rhodes 2021-10-29 1158 wm_adsp2_remove(dsp);
bae9e13fc55cbc David Rhodes 2021-10-29 1159
bae9e13fc55cbc David Rhodes 2021-10-29 1160 return ret;
bae9e13fc55cbc David Rhodes 2021-10-29 1161 }
bae9e13fc55cbc David Rhodes 2021-10-29 1162
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-04-13 9:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 9:59 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-13 12:26 [broonie-sound:for-next 12/13] sound/soc/codecs/cs35l41.c:1129 cs35l41_dsp_init() warn: missing error code 'ret' Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202404131743.unitkCiT-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.