From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4ECFDC4345F for ; Mon, 15 Apr 2024 12:50:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=K99PBdnezqUUF0tBzx6+TqnTAZLBzfaP3KzhICCh4Ao=; b=bcGZFSCwEHARgkPkVSmRslFh3o bLqb3kgeOpGfev6GI91409RgU4Q8vzz1g/j/tnvyGV3XskTiW5Kj2hvptJ1rSjwuWVKPkrmK80sJZ C1AN1mcF5eJYQnBlg/Dd86Ao0xxPJHlNbrfCdMf9ODLbJhrviGiYl0hKaWTwGRepSE7InUK7mZ5dG SLDLYnaWe6ppqgnW7yoj1SK0cHgiKqVC20e3YyhJ6eblps1vkCV6HmyHBc71aUW9VyCvQh6I5Sh6I fHq/vEIz0xXe+vwMTlBSVa5X3J/amj+O9AOkwEmlzYXANzleBk2mHQc0sHH/3p2aUkIjAFZbA5m4w dfWqA9cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwLnJ-00000008HZm-3hr4; Mon, 15 Apr 2024 12:50:45 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwLn5-00000008HQ9-0xGM; Mon, 15 Apr 2024 12:50:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7C50D60BF9; Mon, 15 Apr 2024 12:50:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 102D4C32783; Mon, 15 Apr 2024 12:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713185430; bh=bICUhdhTI38MAzCw4mVv4RoCssKzD+vHemV7hYPVRqM=; h=From:To:Cc:Subject:Date:From; b=W0SD7SWzocBNOOmI+ckB3Bhw59lSHtrPA+W96l+o1XUFrjIPOJ9K9G9llNOEDJ2Pc 6R0jK8UD4fvXpkyBOHo9QLRPeLjanmixK8BzzdPJeTpA+8qDjJfZbXarQb03DPdLgL yYmPTQaV1FL/EhdCEUS8mxRWoY+3kjIYucLvX6pb7ENQlq++goxUKptPsoGGXZ/D5k UMp/rRjjquwhWvQdaBzrYoXiGqTFEsOptf6gfal2TbY2EBnd7zvczBMBO8qiZPMzao iLctHeBT+Tcrlw/c0ri/3k9BYAJehh3Gyt7ggvzHsIk8XoLeufjQMXAWmgi6eR8VV3 LiTen96vItGCw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Peter Wang , Bart Van Assche , "Martin K . Petersen" , Sasha Levin , jejb@linux.ibm.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, stanley.chu@mediatek.com, quic_cang@quicinc.com, avri.altman@wdc.com, quic_nguyenb@quicinc.com, manivannan.sadhasivam@linaro.org, beanhuo@micron.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH AUTOSEL 6.1 1/6] scsi: ufs: core: WLUN suspend dev/link state error recovery Date: Mon, 15 Apr 2024 06:04:22 -0400 Message-ID: <20240415100433.3127434-1-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.86 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_055031_586463_A1E35B75 X-CRM114-Status: GOOD ( 13.58 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: Peter Wang [ Upstream commit 6bc5e70b1c792b31b497e48b4668a9a2909aca0d ] When wl suspend error occurs, for example BKOP or SSU timeout, the host triggers an error handler and returns -EBUSY to break the wl suspend process. However, it is possible for the runtime PM to enter wl suspend again before the error handler has finished, and return -EINVAL because the device is in an error state. To address this, ensure that the rumtime PM waits for the error handler to finish, or trigger the error handler in such cases, because returning -EINVAL can cause the I/O to hang. Signed-off-by: Peter Wang Link: https://lore.kernel.org/r/20240329015036.15707-1-peter.wang@mediatek.com Reviewed-by: Bart Van Assche Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/ufs/core/ufshcd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index f3c25467e571f..948449a13247c 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -9044,7 +9044,10 @@ static int __ufshcd_wl_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op) /* UFS device & link must be active before we enter in this function */ if (!ufshcd_is_ufs_dev_active(hba) || !ufshcd_is_link_active(hba)) { - ret = -EINVAL; + /* Wait err handler finish or trigger err recovery */ + if (!ufshcd_eh_in_progress(hba)) + ufshcd_force_error_recovery(hba); + ret = -EBUSY; goto enable_scaling; } -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 683DDC04FFF for ; Mon, 15 Apr 2024 12:50:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=IYovAL3gg9WnFpwk4ebQqeIYYJkqVra9FRZKMT+30i8=; b=jDAkwscsGWE5IB j3uFP1FQk+Mr5ZFZyN/cQ5YQ6tUFcOSgqts/SeZiyAY5378ws6933zg+HMggGkMe2FPA0/s1l6sBJ NEK2HQQwzHQOf5NvuSobsWM2Wx+UNa7gNi9NSotgt1mMui2mujS4RFdQrBt7eOb/AUT5NQwCrp8B/ xyXX59/jVRJ1caM+FCDm3DeIWtUL/Tagseek/6ixgSjd5IIUHUWKzhp6fPoHB/SufVflAffMJ12MX jWvSxQi/4/DaoEtWZfy3wSaoBN/5DKW8rlOuTVsAUwRJtPtebZfMVpMmx7LHH2QnFT4ZlWhRpBJZC ULz53UptLLew+br9KPrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwLnH-00000008HXX-1sDn; Mon, 15 Apr 2024 12:50:43 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwLn5-00000008HQ9-0xGM; Mon, 15 Apr 2024 12:50:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7C50D60BF9; Mon, 15 Apr 2024 12:50:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 102D4C32783; Mon, 15 Apr 2024 12:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713185430; bh=bICUhdhTI38MAzCw4mVv4RoCssKzD+vHemV7hYPVRqM=; h=From:To:Cc:Subject:Date:From; b=W0SD7SWzocBNOOmI+ckB3Bhw59lSHtrPA+W96l+o1XUFrjIPOJ9K9G9llNOEDJ2Pc 6R0jK8UD4fvXpkyBOHo9QLRPeLjanmixK8BzzdPJeTpA+8qDjJfZbXarQb03DPdLgL yYmPTQaV1FL/EhdCEUS8mxRWoY+3kjIYucLvX6pb7ENQlq++goxUKptPsoGGXZ/D5k UMp/rRjjquwhWvQdaBzrYoXiGqTFEsOptf6gfal2TbY2EBnd7zvczBMBO8qiZPMzao iLctHeBT+Tcrlw/c0ri/3k9BYAJehh3Gyt7ggvzHsIk8XoLeufjQMXAWmgi6eR8VV3 LiTen96vItGCw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Peter Wang , Bart Van Assche , "Martin K . Petersen" , Sasha Levin , jejb@linux.ibm.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, stanley.chu@mediatek.com, quic_cang@quicinc.com, avri.altman@wdc.com, quic_nguyenb@quicinc.com, manivannan.sadhasivam@linaro.org, beanhuo@micron.com, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH AUTOSEL 6.1 1/6] scsi: ufs: core: WLUN suspend dev/link state error recovery Date: Mon, 15 Apr 2024 06:04:22 -0400 Message-ID: <20240415100433.3127434-1-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.86 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_055031_586463_A1E35B75 X-CRM114-Status: GOOD ( 13.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Peter Wang [ Upstream commit 6bc5e70b1c792b31b497e48b4668a9a2909aca0d ] When wl suspend error occurs, for example BKOP or SSU timeout, the host triggers an error handler and returns -EBUSY to break the wl suspend process. However, it is possible for the runtime PM to enter wl suspend again before the error handler has finished, and return -EINVAL because the device is in an error state. To address this, ensure that the rumtime PM waits for the error handler to finish, or trigger the error handler in such cases, because returning -EINVAL can cause the I/O to hang. Signed-off-by: Peter Wang Link: https://lore.kernel.org/r/20240329015036.15707-1-peter.wang@mediatek.com Reviewed-by: Bart Van Assche Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/ufs/core/ufshcd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index f3c25467e571f..948449a13247c 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -9044,7 +9044,10 @@ static int __ufshcd_wl_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op) /* UFS device & link must be active before we enter in this function */ if (!ufshcd_is_ufs_dev_active(hba) || !ufshcd_is_link_active(hba)) { - ret = -EINVAL; + /* Wait err handler finish or trigger err recovery */ + if (!ufshcd_eh_in_progress(hba)) + ufshcd_force_error_recovery(hba); + ret = -EBUSY; goto enable_scaling; } -- 2.43.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel