From: Simon Horman <horms@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Andrew Lunn <andrew@lunn.ch>,
nex.sw.ncis.osdt.itp.upstreaming@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC net-next 5/7] netdev_features: convert NETIF_F_HIGHDMA to priv_flag IFF_HIGHDMA
Date: Mon, 15 Apr 2024 15:35:10 +0100 [thread overview]
Message-ID: <20240415143510.GA3545293@kernel.org> (raw)
In-Reply-To: <20240405133731.1010128-6-aleksander.lobakin@intel.com>
On Fri, Apr 05, 2024 at 03:37:29PM +0200, Alexander Lobakin wrote:
> The ability to send bufferst from the high memory is rather an
> attribute, not a feature. It can't be toggled via Ethtool and
> is constant for the whole interface lifetime.
> Convert it to a private flag, carrying necessary inheritance for
> lower interfaces.
>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
...
> index f57c29de3a91..78e749f6b91f 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -3007,6 +3007,7 @@ struct ieee80211_hw {
> s16 accuracy;
> } radiotap_timestamp;
> netdev_features_t netdev_features;
> + u64 netdev_priv_flags;
> u8 uapsd_queues;
> u8 uapsd_max_sp_len;
> u8 max_nan_de_entries;
nit: please add netdev_features to the kernel-doc for struct ieee80211_hw.
Flagged by ./scripts/kernel-doc -none
...
next prev parent reply other threads:[~2024-04-15 14:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 13:37 [PATCH RFC net-next 0/7] netdev_features: start cleaning netdev_features_t up Alexander Lobakin
2024-04-05 13:37 ` [PATCH RFC net-next 1/7] netdev_features: remove unused __UNUSED_NETIF_F_1 Alexander Lobakin
2024-04-05 14:12 ` Andrew Lunn
2024-04-05 15:15 ` Alexander Lobakin
2024-04-05 15:41 ` Andrew Lunn
2024-04-05 13:37 ` [PATCH RFC net-next 2/7] netdev_features: convert NETIF_F_LLTX to priv_flag IFF_LLTX Alexander Lobakin
2024-04-15 14:37 ` Simon Horman
2024-04-16 12:39 ` Alexander Lobakin
2024-04-05 13:37 ` [PATCH RFC net-next 3/7] netdevice: introduce IFF_LOGICAL as (IFF_NO_QUEUE | IFF_LLTX) Alexander Lobakin
2024-04-09 2:32 ` Jakub Kicinski
2024-04-11 10:29 ` Alexander Lobakin
2024-04-05 13:37 ` [PATCH RFC net-next 4/7] netdev_features: convert NETIF_F_NETNS_LOCAL to IFF_NETNS_LOCAL Alexander Lobakin
2024-04-05 13:37 ` [PATCH RFC net-next 5/7] netdev_features: convert NETIF_F_HIGHDMA to priv_flag IFF_HIGHDMA Alexander Lobakin
2024-04-15 14:35 ` Simon Horman [this message]
2024-04-05 13:37 ` [PATCH RFC net-next 6/7] netdev_features: convert NETIF_F_VLAN_CHALLENGED to IFF_VLAN_CHALLENGED Alexander Lobakin
2024-04-05 13:37 ` [PATCH RFC net-next 7/7] netdev_features: convert NETIF_F_FCOE_MTU to IFF_FCOE_MTU Alexander Lobakin
2024-04-09 2:38 ` Jakub Kicinski
2024-04-11 10:28 ` Alexander Lobakin
2024-04-11 14:20 ` Andrew Lunn
2024-04-11 14:47 ` Jakub Kicinski
2024-04-16 12:45 ` Alexander Lobakin
2024-04-16 14:19 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415143510.GA3545293@kernel.org \
--to=horms@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=pabeni@redhat.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.