From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C50451D52B; Mon, 15 Apr 2024 15:48:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713196141; cv=none; b=kv6vuFQo+yg/KSIONDpkuHojMiwABvG9KZ71BKWRVV7Gjb7hume2jnFb2DLMYQaZcS26Sz7GBR0JdXS10+VRbwdKAOWo2VVWQuotkEHXC8YdCxv18XhI9QiaSUGGBVyebz3kn0WKw68A+BtbyUabJlaIDV+SBDDKhOgHzksVijE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713196141; c=relaxed/simple; bh=vckgdI60nnlCSg5BIZOilFflwMtdNqSLeCq6LHe17G4=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Nxou5yB91ZyU38w0fNJ4ha8l6slTVlUMlrbVL418EZzC9FXMNMn6RkB22L5dMdsR6guAJ1bwsFeJ6fviNMo7EJMaCnIUDHeCJlQOaMXtd6ftaXfCFx7oOPtZ0i2K+Lo8s96YsVk4uKFL7u9e/+8dhSXNwD3A1vMRbfFEnSTc3SY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VJBPK5lr5z6D8gk; Mon, 15 Apr 2024 23:47:01 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 5D426140CF4; Mon, 15 Apr 2024 23:48:56 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 15 Apr 2024 16:48:55 +0100 Date: Mon, 15 Apr 2024 16:48:54 +0100 From: Jonathan Cameron To: "Rafael J. Wysocki" CC: , , , , , , , , Russell King , Miguel Luis , James Morse , Salil Mehta , "Jean-Philippe Brucker" , Catalin Marinas , Will Deacon , , , Subject: Re: [PATCH v5 02/18] ACPI: processor: Set the ACPI_COMPANION for the struct cpu instance Message-ID: <20240415164854.0000264f@Huawei.com> In-Reply-To: References: <20240412143719.11398-1-Jonathan.Cameron@huawei.com> <20240412143719.11398-3-Jonathan.Cameron@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) On Fri, 12 Apr 2024 20:10:54 +0200 "Rafael J. Wysocki" wrote: > On Fri, Apr 12, 2024 at 4:38=E2=80=AFPM Jonathan Cameron > wrote: > > > > The arm64 specific arch_register_cpu() needs to access the _STA > > method of the DSDT object so make it available by assigning the > > appropriate handle to the struct cpu instance. > > > > Signed-off-by: Jonathan Cameron > > --- > > drivers/acpi/acpi_processor.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processo= r.c > > index 7a0dd35d62c9..93e029403d05 100644 > > --- a/drivers/acpi/acpi_processor.c > > +++ b/drivers/acpi/acpi_processor.c > > @@ -235,6 +235,7 @@ static int acpi_processor_get_info(struct acpi_devi= ce *device) > > union acpi_object object =3D { 0 }; > > struct acpi_buffer buffer =3D { sizeof(union acpi_object), &obj= ect }; > > struct acpi_processor *pr =3D acpi_driver_data(device); > > + struct cpu *c; > > int device_declaration =3D 0; > > acpi_status status =3D AE_OK; > > static int cpu0_initialized; > > @@ -314,6 +315,8 @@ static int acpi_processor_get_info(struct acpi_devi= ce *device) > > cpufreq_add_device("acpi-cpufreq"); > > } > > > > + c =3D &per_cpu(cpu_devices, pr->id); > > + ACPI_COMPANION_SET(&c->dev, device); =20 >=20 > This is also set for per_cpu(cpu_sys_devices, pr->id) in > acpi_processor_add(), via acpi_bind_one(). Hi Rafael, cpu_sys_devices gets filled with a pointer to this same structure. The contents gets set in register_cpu() so at this point it doesn't point anywhere. As a side note register_cpu() memsets to zero the value I set it to in the code above which isn't great, particularly as I want to use this in post_eject for arm64. We could make a copy of the handle and put it back after the memset in register_cpu() but that is also ugly. It's the best I've come up with to make sure this is still set come remove time but is rather odd. >=20 > Moreover, there is some pr->id validation in acpi_processor_add(), so > it seems premature to use it here this way. >=20 > I think that ACPI_COMPANION_SET() should be called from here on > per_cpu(cpu_sys_devices, pr->id) after validating pr->id (so the > pr->id validation should all be done here) and then NULL can be passed > as acpi_dev to acpi_bind_one() in acpi_processor_add(). Then, there > will be one physical device corresponding to the processor ACPI device > and no confusion. I'm fairly sure this is pointing to the same device but agreed this is a tiny bit confusing. However we can't use cpu_sys_devices at this point so I'm not immediately seeing a cleaner solution :( Jonathan >=20 > > /* > > * Extra Processor objects may be enumerated on MP systems with > > * less than the max # of CPUs. They should be ignored _iff > > -- > > 2.39.2 > > =20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98457C4345F for ; Mon, 15 Apr 2024 15:49:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ynsru8LfXcMu/Nr/kvlkDRHG3xi9PvMlmJ5o5rPWB+U=; b=poco8ZTQwtHsEX 8ngjK+klu36GDqYjqDAnGLMr922p1/6iHmm5d6fZKRXjwbTnEhl4F73wgJHrth6uP99aVkRUaR25o /DnZKQBpXYaRqX/B6D6LVcowlztLaATMZyX5qE0Jivh4Po+nTBGI1PJ+2FP5feZybgpHjsrpcEZIi GaKlngncJ3bxBWg1cRut4PDsUBxBbHG5tf19GRyz75MtBc5WOoH3euj8Oxd1rnpaSBkrf9XRAXkPf GqENl5bz98eoAeuZR7afBFbtwUMeogYt/Sn1W6igUC7QvuyzMlJFpZMbLqH08gxs4106vqyt5YRPn NOzZNrCgOYzi015WypLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwOZv-00000008wd4-0eEY; Mon, 15 Apr 2024 15:49:07 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwOZr-00000008wcD-1cke for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 15:49:05 +0000 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VJBPK5lr5z6D8gk; Mon, 15 Apr 2024 23:47:01 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 5D426140CF4; Mon, 15 Apr 2024 23:48:56 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 15 Apr 2024 16:48:55 +0100 Date: Mon, 15 Apr 2024 16:48:54 +0100 From: Jonathan Cameron To: "Rafael J. Wysocki" CC: , , , , , , , , Russell King , Miguel Luis , James Morse , Salil Mehta , "Jean-Philippe Brucker" , Catalin Marinas , Will Deacon , , , Subject: Re: [PATCH v5 02/18] ACPI: processor: Set the ACPI_COMPANION for the struct cpu instance Message-ID: <20240415164854.0000264f@Huawei.com> In-Reply-To: References: <20240412143719.11398-1-Jonathan.Cameron@huawei.com> <20240412143719.11398-3-Jonathan.Cameron@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_084903_733908_143F32F5 X-CRM114-Status: GOOD ( 29.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxMiBBcHIgMjAyNCAyMDoxMDo1NCArMDIwMAoiUmFmYWVsIEouIFd5c29ja2kiIDxy YWZhZWxAa2VybmVsLm9yZz4gd3JvdGU6Cgo+IE9uIEZyaSwgQXByIDEyLCAyMDI0IGF0IDQ6Mzji gK9QTSBKb25hdGhhbiBDYW1lcm9uCj4gPEpvbmF0aGFuLkNhbWVyb25AaHVhd2VpLmNvbT4gd3Jv dGU6Cj4gPgo+ID4gVGhlIGFybTY0IHNwZWNpZmljIGFyY2hfcmVnaXN0ZXJfY3B1KCkgbmVlZHMg dG8gYWNjZXNzIHRoZSBfU1RBCj4gPiBtZXRob2Qgb2YgdGhlIERTRFQgb2JqZWN0IHNvIG1ha2Ug aXQgYXZhaWxhYmxlIGJ5IGFzc2lnbmluZyB0aGUKPiA+IGFwcHJvcHJpYXRlIGhhbmRsZSB0byB0 aGUgc3RydWN0IGNwdSBpbnN0YW5jZS4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBKb25hdGhhbiBD YW1lcm9uIDxKb25hdGhhbi5DYW1lcm9uQGh1YXdlaS5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJz L2FjcGkvYWNwaV9wcm9jZXNzb3IuYyB8IDMgKysrCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5z ZXJ0aW9ucygrKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2FjcGkvYWNwaV9wcm9jZXNz b3IuYyBiL2RyaXZlcnMvYWNwaS9hY3BpX3Byb2Nlc3Nvci5jCj4gPiBpbmRleCA3YTBkZDM1ZDYy YzkuLjkzZTAyOTQwM2QwNSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvYWNwaS9hY3BpX3Byb2Nl c3Nvci5jCj4gPiArKysgYi9kcml2ZXJzL2FjcGkvYWNwaV9wcm9jZXNzb3IuYwo+ID4gQEAgLTIz NSw2ICsyMzUsNyBAQCBzdGF0aWMgaW50IGFjcGlfcHJvY2Vzc29yX2dldF9pbmZvKHN0cnVjdCBh Y3BpX2RldmljZSAqZGV2aWNlKQo+ID4gICAgICAgICB1bmlvbiBhY3BpX29iamVjdCBvYmplY3Qg PSB7IDAgfTsKPiA+ICAgICAgICAgc3RydWN0IGFjcGlfYnVmZmVyIGJ1ZmZlciA9IHsgc2l6ZW9m KHVuaW9uIGFjcGlfb2JqZWN0KSwgJm9iamVjdCB9Owo+ID4gICAgICAgICBzdHJ1Y3QgYWNwaV9w cm9jZXNzb3IgKnByID0gYWNwaV9kcml2ZXJfZGF0YShkZXZpY2UpOwo+ID4gKyAgICAgICBzdHJ1 Y3QgY3B1ICpjOwo+ID4gICAgICAgICBpbnQgZGV2aWNlX2RlY2xhcmF0aW9uID0gMDsKPiA+ICAg ICAgICAgYWNwaV9zdGF0dXMgc3RhdHVzID0gQUVfT0s7Cj4gPiAgICAgICAgIHN0YXRpYyBpbnQg Y3B1MF9pbml0aWFsaXplZDsKPiA+IEBAIC0zMTQsNiArMzE1LDggQEAgc3RhdGljIGludCBhY3Bp X3Byb2Nlc3Nvcl9nZXRfaW5mbyhzdHJ1Y3QgYWNwaV9kZXZpY2UgKmRldmljZSkKPiA+ICAgICAg ICAgICAgICAgICAgICAgICAgIGNwdWZyZXFfYWRkX2RldmljZSgiYWNwaS1jcHVmcmVxIik7Cj4g PiAgICAgICAgIH0KPiA+Cj4gPiArICAgICAgIGMgPSAmcGVyX2NwdShjcHVfZGV2aWNlcywgcHIt PmlkKTsKPiA+ICsgICAgICAgQUNQSV9DT01QQU5JT05fU0VUKCZjLT5kZXYsIGRldmljZSk7ICAK PiAKPiBUaGlzIGlzIGFsc28gc2V0IGZvciBwZXJfY3B1KGNwdV9zeXNfZGV2aWNlcywgcHItPmlk KSBpbgo+IGFjcGlfcHJvY2Vzc29yX2FkZCgpLCB2aWEgYWNwaV9iaW5kX29uZSgpLgoKSGkgUmFm YWVsLAoKY3B1X3N5c19kZXZpY2VzIGdldHMgZmlsbGVkIHdpdGggYSBwb2ludGVyIHRvIHRoaXMg c2FtZSBzdHJ1Y3R1cmUuClRoZSBjb250ZW50cyBnZXRzIHNldCBpbiByZWdpc3Rlcl9jcHUoKSBz byBhdCB0aGlzIHBvaW50Cml0IGRvZXNuJ3QgcG9pbnQgYW55d2hlcmUuICBBcyBhIHNpZGUgbm90 ZSByZWdpc3Rlcl9jcHUoKQptZW1zZXRzIHRvIHplcm8gdGhlIHZhbHVlIEkgc2V0IGl0IHRvIGlu IHRoZSBjb2RlIGFib3ZlIHdoaWNoIGlzbid0CmdyZWF0LCBwYXJ0aWN1bGFybHkgYXMgSSB3YW50 IHRvIHVzZSB0aGlzIGluIHBvc3RfZWplY3QgZm9yCmFybTY0LgoKV2UgY291bGQgbWFrZSBhIGNv cHkgb2YgdGhlIGhhbmRsZSBhbmQgcHV0IGl0IGJhY2sgYWZ0ZXIKdGhlIG1lbXNldCBpbiByZWdp c3Rlcl9jcHUoKSBidXQgdGhhdCBpcyBhbHNvIHVnbHkuCkl0J3MgdGhlIGJlc3QgSSd2ZSBjb21l IHVwIHdpdGggdG8gbWFrZSBzdXJlIHRoaXMgaXMgc3RpbGwgc2V0CmNvbWUgcmVtb3ZlIHRpbWUg YnV0IGlzIHJhdGhlciBvZGQuCgo+IAo+IE1vcmVvdmVyLCB0aGVyZSBpcyBzb21lIHByLT5pZCB2 YWxpZGF0aW9uIGluIGFjcGlfcHJvY2Vzc29yX2FkZCgpLCBzbwo+IGl0IHNlZW1zIHByZW1hdHVy ZSB0byB1c2UgaXQgaGVyZSB0aGlzIHdheS4KPiAKPiBJIHRoaW5rIHRoYXQgQUNQSV9DT01QQU5J T05fU0VUKCkgc2hvdWxkIGJlIGNhbGxlZCBmcm9tIGhlcmUgb24KPiBwZXJfY3B1KGNwdV9zeXNf ZGV2aWNlcywgcHItPmlkKSBhZnRlciB2YWxpZGF0aW5nIHByLT5pZCAoc28gdGhlCj4gcHItPmlk IHZhbGlkYXRpb24gc2hvdWxkIGFsbCBiZSBkb25lIGhlcmUpIGFuZCB0aGVuIE5VTEwgY2FuIGJl IHBhc3NlZAo+IGFzIGFjcGlfZGV2IHRvIGFjcGlfYmluZF9vbmUoKSBpbiBhY3BpX3Byb2Nlc3Nv cl9hZGQoKS4gIFRoZW4sIHRoZXJlCj4gd2lsbCBiZSBvbmUgcGh5c2ljYWwgZGV2aWNlIGNvcnJl c3BvbmRpbmcgdG8gdGhlIHByb2Nlc3NvciBBQ1BJIGRldmljZQo+IGFuZCBubyBjb25mdXNpb24u CgpJJ20gZmFpcmx5IHN1cmUgdGhpcyBpcyBwb2ludGluZyB0byB0aGUgc2FtZSBkZXZpY2UgYnV0 IGFncmVlZCB0aGlzCmlzIGEgdGlueSBiaXQgY29uZnVzaW5nLiBIb3dldmVyIHdlIGNhbid0IHVz ZSBjcHVfc3lzX2RldmljZXMgYXQgdGhpcyBwb2ludApzbyBJJ20gbm90IGltbWVkaWF0ZWx5IHNl ZWluZyBhIGNsZWFuZXIgc29sdXRpb24gOigKCkpvbmF0aGFuCgo+IAo+ID4gICAgICAgICAvKgo+ ID4gICAgICAgICAgKiAgRXh0cmEgUHJvY2Vzc29yIG9iamVjdHMgbWF5IGJlIGVudW1lcmF0ZWQg b24gTVAgc3lzdGVtcyB3aXRoCj4gPiAgICAgICAgICAqICBsZXNzIHRoYW4gdGhlIG1heCAjIG9m IENQVXMuIFRoZXkgc2hvdWxkIGJlIGlnbm9yZWQgX2lmZgo+ID4gLS0KPiA+IDIuMzkuMgo+ID4g IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK