From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1552B171D2 for ; Tue, 16 Apr 2024 04:41:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713242493; cv=none; b=WG04lOqFHo/ua1h9m4YrVXOSG2TWjFaAVloKcRMFPUPXH5jcU2HZR9CBjU5j/zSsfKdG9XGlTAYocj5vBIMO4hwVS7VIlC4uYFVIdR+LOydG1THM32Hlj95Sz+cIcWT+orfAs7CY/hGUkYJMgheSpFci1QTJHQ8R5gbDlroRsqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713242493; c=relaxed/simple; bh=DqDyd4MpI+rvYMYAT3Ft5xs95IMJydJhHOHuJjyBxW4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pPbY9i7b0NYgOJOCirJ49oR/xn6/+uXcJBKZSuNZjNtjIfoGZ7hiMENDQMMmTjQNJ/+IW9pDUm7B0A7Ta/A4bGglLNGXNLo9LDElbjL0M35vLlgy1wbugVVsOFAnJzrg+susjv0iADBvxWkaN9U0e9m1SLcQKYJqw7ZyTPx+fLo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=QA+XMZEQ; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QA+XMZEQ" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-3c38eced701so1612249b6e.1 for ; Mon, 15 Apr 2024 21:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713242490; x=1713847290; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zlvfKPvFfqMVTjgmkdQ2dgHupdBvuhJAjVeekD23sMY=; b=QA+XMZEQ4TSKlDwKnkstTwNqATtBiFbsIwW6mmZH78ughkAzpgyenMvV1Lpd/vMyHP 7NTsFHch3jvOiJ+obKYa+FzwWUXuVaEChF4zTRRV/GQklNftpHjFe/lFZUezfns1dkt4 k677k7WQs69PISiVPzIYtOUUow0YCd559kxZ8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713242490; x=1713847290; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zlvfKPvFfqMVTjgmkdQ2dgHupdBvuhJAjVeekD23sMY=; b=oKbocXHrFkY1w1il/bKDi+cSArEFznev6227Kl3UnREASXw18JJok4gRDuMZNryKq7 iX4b0w7NcLXSXULo6WjFGAa3cin/jRrDwsoAWv/qDVFpG+TZk1zlIRxfH5vzgyYFGndQ 9YvXVOp6iR29j5/C2JeOTPCiBaXuqFrasQWc/VwNjeFzXO4kIpQbga52OgdvMVE2nNez pIhiFTH5qxw3U1iuZ9KeaCimmSgZxqG3ViVJYxhyvNZrueDEDWqT3Hi4bXe8/I6rRQ3r kstwD7AXzneoEn3fXU2AMm6KeCY+uRA+AsXlru70sFi5WZTQ9Z956gWQaDF3ijPXpwTn Nggw== X-Forwarded-Encrypted: i=1; AJvYcCXyIsYFbxseNFPieroaIBSPoisDKMuLUAidCErN3MeA9SuXXBLpkU+of0aHib7/UxmaNdgHmUNpQjYxmaA6u1enfdI6i2GGKW/dmCLiPw== X-Gm-Message-State: AOJu0YwtBre96jOVqtY747CKGRC3FASGoyRhi4kxnq4kt7bn75wa/5pa +sZd1TLWCPD+UJc90zdtZNvvZRGCp1WCtM9lAHAd8li0jIveg9eqNodFu1tf5w== X-Google-Smtp-Source: AGHT+IFGNPBipDIE0AiNQc/Cqlxd5431Vef5ObfevA6hF44fnzurKBxD1B4lS2oVTJREu9b1YFAdCg== X-Received: by 2002:a05:6870:89a4:b0:22d:fcf9:bd97 with SMTP id f36-20020a05687089a400b0022dfcf9bd97mr15408827oaq.26.1713242490147; Mon, 15 Apr 2024 21:41:30 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:1137:d3d7:a09d:5379]) by smtp.gmail.com with ESMTPSA id r4-20020a056a00216400b006edd05e3751sm8284703pff.176.2024.04.15.21.41.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 21:41:29 -0700 (PDT) Date: Tue, 16 Apr 2024 13:41:19 +0900 From: Sergey Senozhatsky To: Ricardo Ribalda Cc: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?iso-8859-1?Q?S=F6derlund?= , Pavel Machek , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 04/35] media: uvcvideo: Use max() macro Message-ID: <20240416044119.GB14947@google.com> References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> <20240415-fix-cocci-v1-4-477afb23728b@chromium.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240415-fix-cocci-v1-4-477afb23728b@chromium.org> On (24/04/15 19:34), Ricardo Ribalda wrote: > It makes the code slightly more clear and makes cocci incredibly happy: > > drivers/media/usb/uvc/uvc_ctrl.c:839:22-23: WARNING opportunity for max() > > Signed-off-by: Ricardo Ribalda Reviewed-by: Sergey Senozhatsky From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83D41C4345F for ; Tue, 16 Apr 2024 04:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X/fyFQmmFRinZ3uJESfhxkSBYfYhSEA+nTj2gxR603w=; b=y2JStwwl+kpDgs 3w/KiGKewfg+akXrlX0TDNgysKucsTsicvoNKdfDFHT4RuQEcbjbC43o12IWLASfXzNruOVTk4cfs 5UgUUjmvtg6JiWrYLDpvkvXe+XxTIJfi+SHqBlyNMXJYaqTWOjGRjUQzovK4YQiciCY0cf0NrO2PX 2Xz1zroS9nFGhiWPx8KwPvwy1l9Xkamd5R1SUFdjN6t+tod2GmrsprK9JRjdErdUM98c/o5zW5j9F bHLR7Nwjaj6Mq3fX1Z5ShSal0Xw721bGsBptNkEnW5gm7tvJFXozNtFBV0Dr+xS8h0drnjiFzKWRD +lIfMn/wsTb5nxlb9ZNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwadR-0000000Aqf1-45ld; Tue, 16 Apr 2024 04:41:33 +0000 Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwadP-0000000AqeH-3B85 for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2024 04:41:33 +0000 Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3c721df4adeso84398b6e.0 for ; Mon, 15 Apr 2024 21:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713242490; x=1713847290; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zlvfKPvFfqMVTjgmkdQ2dgHupdBvuhJAjVeekD23sMY=; b=JhJY7w2oL4mBNW5VxtE6nozJsAmd/0VMPASmNkZSqGd9MRQQAEyXHQxI3tG7kUFErR 9V4bDIKF+rlVP3Kw2fT+m39fhetfMmhJ/9W0Js9J8i4PLEDSFrN/05bmBuFLBb7vo4QI 3ss81EyrKx906ephBdq6f9inAJmEr/0ZCJV3E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713242490; x=1713847290; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zlvfKPvFfqMVTjgmkdQ2dgHupdBvuhJAjVeekD23sMY=; b=Chpa2K3vrvAm+92kd6DgB51vZzuaiOa36FE0vIAmy1VKEmaXrM4llqxUzIJLhkkhgp fzpc9AZDP1AF1cIOxFG8NYYjlggza75u/OD5NOutvSVkJDyLdPDoAo78VmSwzyoBTvvH P3hz0KAfUtGr1O0SDBn2w88wyrdZxMC7iIUaJb+F3+RhaWLkACbYwLoYGeWa94B/GAZM 68wN/lrqvpY0EhWwyb8II5W8AbXNgEdgWizW91hxUcb1bowFywG0Us7gBQfSNZiaAPbz Sa7wosX0ELgVh7CCdZt51MWuaDpLDaDRtGc67gJmdOMnxENSgkMtxT5VzhvYbJ6ayrur lpvw== X-Forwarded-Encrypted: i=1; AJvYcCViDl0V3xujGMKa1qn6lj3f0Sm0XR98FR046RlLb8/b+OF6DxPnzu07TPWTsbwGF2r4CLbSpUYMnNmTYoRaFNIWEeu2YlNnWclqXhbzTCS0O/fzpuI= X-Gm-Message-State: AOJu0Yytj4u6FMAeMohSDrzOc8DmzXN+giBR9BlDUx0gimCGohHIoENH Zbn4aTBH2EqtkqBdX29yeWbixK4ByI0Te5wyBKCVbADU/qH2Aw0gcTOPMn+Mvg== X-Google-Smtp-Source: AGHT+IFGNPBipDIE0AiNQc/Cqlxd5431Vef5ObfevA6hF44fnzurKBxD1B4lS2oVTJREu9b1YFAdCg== X-Received: by 2002:a05:6870:89a4:b0:22d:fcf9:bd97 with SMTP id f36-20020a05687089a400b0022dfcf9bd97mr15408827oaq.26.1713242490147; Mon, 15 Apr 2024 21:41:30 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:1137:d3d7:a09d:5379]) by smtp.gmail.com with ESMTPSA id r4-20020a056a00216400b006edd05e3751sm8284703pff.176.2024.04.15.21.41.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 21:41:29 -0700 (PDT) Date: Tue, 16 Apr 2024 13:41:19 +0900 From: Sergey Senozhatsky To: Ricardo Ribalda Cc: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?iso-8859-1?Q?S=F6derlund?= , Pavel Machek , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 04/35] media: uvcvideo: Use max() macro Message-ID: <20240416044119.GB14947@google.com> References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> <20240415-fix-cocci-v1-4-477afb23728b@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240415-fix-cocci-v1-4-477afb23728b@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_214131_803746_AD7A9793 X-CRM114-Status: UNSURE ( 9.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On (24/04/15 19:34), Ricardo Ribalda wrote: > It makes the code slightly more clear and makes cocci incredibly happy: > > drivers/media/usb/uvc/uvc_ctrl.c:839:22-23: WARNING opportunity for max() > > Signed-off-by: Ricardo Ribalda Reviewed-by: Sergey Senozhatsky _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel