From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 227B339FCF for ; Tue, 16 Apr 2024 05:08:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713244116; cv=none; b=tJeB50iD3lsvMYUiWO262XXfC9PlP5COtKYJ68K7E1xfetJgUa7GMp7u5Tl4B7JtspS0cUoLwUJmhxqxdGeYQ9/q0SgbNVFkOUDLi4+Mr6b+ceLtdHrn4nCTSHf/RvlgYLvYNnpqo8CxqBzhNoENxQ0r6FzuZWk7/nvLVVFHABE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713244116; c=relaxed/simple; bh=ogTb/EY/IFRV9I9Ma1QpOc93lubjjzj7VSkmXIhlhHw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W1hDIK4UPgUdb5LePdkpeJOpwGV/AJ4GpgG3xV2NNTyfvGFi+S82mO1XCYBAeq6mPrCYGRCeiUYtxcmDihGmE+u91ve47IhYYuCtknWhKqdQ9Lupp+OpFuZOR3yqxAyo1rja1ziNQifzBpp9HC5kelL8YY0Rgut//zmV2bpv670= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=SM5m0z7T; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="SM5m0z7T" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6ed5109d924so3367807b3a.0 for ; Mon, 15 Apr 2024 22:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713244114; x=1713848914; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+oFRnUlIWAVoS2ogvawh6UrIJvrJD5mfVByWfU6FCcs=; b=SM5m0z7TFXqS1fvrFLpjthozuB3gYh9BICiGe5y2jmmTEXs8Y8YyQVSh5PFffZuR8D PoiUM0NwyhYDaQzIbHuNkYJhC9nPR6ZGoRc1RlFbDdmJrjFuiwvt/Z6VnaInmRBMWe0x DWbbbcz77heOx0YuxJBU2qFq4+LMKKKklfP0I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713244114; x=1713848914; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+oFRnUlIWAVoS2ogvawh6UrIJvrJD5mfVByWfU6FCcs=; b=PULsKmzWX/T+Q4i6imvwbkdQ0M/pqxGo+29Yjn8JymA1dM2kSAEwaQl9rxqNw/FTWp YU0Nk2rIi6GZE3/Qb1OeRKZ8JcXTlhfWtjvdS7hPM2D76a6AC8jA4Z/wUVncYasN/Pfj yRTQUkMQyE4rBbFi7gpzhojY10+Qw8MT2f4F5VmuWkL6FKdOoDJHB/XlvSX/wHcWLM5D /r0X6CK/lTf7M1WiuAyEcO0uywawGcf4jcknscGiFIrAifKCeztHFSXFmSBwOC6cHbf1 GUZRK0OWf8jJb1wTPf76T+bsL++b9Q9j52ViwthePNW40UZ1diSzz/7nY0Lxv2aVwELX arag== X-Forwarded-Encrypted: i=1; AJvYcCWmcCucclmX7fA0DrHnJUDOWhqk6strgjlqk9wZLF11gw/g81evGA3uIUCc8/ka9GRHpGsYybEQkqrcFonnAhMqU/prRt+WAPTyR65lnA== X-Gm-Message-State: AOJu0YymNQ71ZClIjmIjjt8NO8XjTC4Y02597CyuAkaC1gm51UAuvyYt tnI8X9nzPVLBLjspQELz7qQfsgh9ftLLwI3fkQHIyjzGW6k9sq/fWrC8JthkdQ== X-Google-Smtp-Source: AGHT+IHdeyQZ3pISdOfe7kK+Dd6aJIUpN4QAP3YPL9N18bYFaJvtwg0bTY9a/3ZlCCWhymzrgDPW+Q== X-Received: by 2002:a05:6a21:2d85:b0:1a9:c13e:f211 with SMTP id ty5-20020a056a212d8500b001a9c13ef211mr8124701pzb.47.1713244114400; Mon, 15 Apr 2024 22:08:34 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:1137:d3d7:a09d:5379]) by smtp.gmail.com with ESMTPSA id ju17-20020a170903429100b001e49428f313sm8835349plb.261.2024.04.15.22.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 22:08:33 -0700 (PDT) Date: Tue, 16 Apr 2024 14:08:23 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: Ricardo Ribalda , Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?iso-8859-1?Q?S=F6derlund?= , Pavel Machek , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 03/35] media: uvcvideo: Refactor iterators Message-ID: <20240416050823.GC14947@google.com> References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> <20240415-fix-cocci-v1-3-477afb23728b@chromium.org> <20240416043916.GA14947@google.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240416043916.GA14947@google.com> On (24/04/16 13:39), Sergey Senozhatsky wrote: > On (24/04/15 19:34), Ricardo Ribalda wrote: > [..] > > @@ -2165,7 +2167,7 @@ static int uvc_ctrl_init_xu_ctrl(struct uvc_device *dev, > > int uvc_xu_ctrl_query(struct uvc_video_chain *chain, > > struct uvc_xu_control_query *xqry) > > { > > - struct uvc_entity *entity; > > + struct uvc_entity *entity, *iter; > > struct uvc_control *ctrl; > > unsigned int i; > > bool found; > > Is `found` still used? It is. Never mind. FWIW Reviewed-by: Sergey Senozhatsky From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CCD7C04FF6 for ; Tue, 16 Apr 2024 05:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sCgYvzitLk11c69Jov53ttgYEwBzeid3G9jHLs9d/eY=; b=SDvqVN+zjCGCn7 rCIp9KecF+yVs0/7sGckH7gZVeAPQmhPTCRyHSQhJ3LF77KWSgS9mat31kXzfzp+0re/5/4tl/Igo /5DcQ9Ov9wMiPLS8+uEa98qq2E+ihe0j6vCif/L0Boyv92q+zeJ1n6p1NeyPSkn04jkA5qbuP0SJu bpVQrov6h6C01Zkc2/7XTeyNbAOX0xE+b0Q9ygnprO3Y3mTGJ3avwlhNtGkvVxz66jBkUwzltXVH8 dbhv73qQdTgF70q4hk6ckNhhiv1gjaKjRAoYFgQQCwxG8akmL9WhG3T07GQREPzKVpsLUxkitCk+l XvtcTnHdbQbNz3dRdL5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwb3g-0000000AtjY-1Lmh; Tue, 16 Apr 2024 05:08:40 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwb3b-0000000Atfu-1bK7 for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2024 05:08:36 +0000 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6ed5109d924so3367808b3a.0 for ; Mon, 15 Apr 2024 22:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713244114; x=1713848914; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+oFRnUlIWAVoS2ogvawh6UrIJvrJD5mfVByWfU6FCcs=; b=hih+pxOkFgda4/Jje/5VoO7lYDKbSrGhSwIWMXoKDovNvrKU27vkvXObnCPXB9/krU BJC8SfT06fuciCYDTywKCWKNusQd/t3fF/ONr+grjt7WSP/MmnLu/BjHCo30FH8D36fG NDe6no675UOhJCU2lZ/bN8yA1Pt1A/qJddrgA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713244114; x=1713848914; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+oFRnUlIWAVoS2ogvawh6UrIJvrJD5mfVByWfU6FCcs=; b=NZ2AnqW1bX1D4apB5KoVPRj+bDDDBo03Ba/Uja3xLbkdyTLM5OMPiUYTeagA01U5ys XhLWQaUGHAMQkQGHnyyhgUtNgeYL74pm24Cc55RPSOIkYiH1ufqgFQvXiFpTj+Dh6hpm uyD0x0pVEJFEHRiQCdfD/dbrhIoWRcPv6J2wpv4Pc4zVwAzfLm/GVoJc+dAuUwlGzuPR 1HFDk4Upa+No5CDJcpLMaR6n57NfB5Z+xu/PdexbXvLXj31Wd4Sjh3ooXe28oRuHH6bV 9MDP8ngsTsBPMNjxGeiNMt/wHIPjq78cVKSC+7+chgicc/C3ehLAxcAf7srB+DBxWYYj 0x8g== X-Forwarded-Encrypted: i=1; AJvYcCV/3Ybe1GZByvvcHMf8gLCfOmyNnNtkPNGWN0gPHYHs9at+I+2yiH42oIJRORv1bZTnzF4SZB5eMyxd58+VeyEgqiZhT/J/aIjp7yJBWy2162DwNzA= X-Gm-Message-State: AOJu0YwixNrTJkns/IWuy00A97mz86T7XrKcXp+p8Abliw74JKuTp6Ql rdnckdiw5RFGMNBMc+EdvEBdoT6nexF3HeL8MiFhcRNidhnnqLJ9gDga1+yQtw== X-Google-Smtp-Source: AGHT+IHdeyQZ3pISdOfe7kK+Dd6aJIUpN4QAP3YPL9N18bYFaJvtwg0bTY9a/3ZlCCWhymzrgDPW+Q== X-Received: by 2002:a05:6a21:2d85:b0:1a9:c13e:f211 with SMTP id ty5-20020a056a212d8500b001a9c13ef211mr8124701pzb.47.1713244114400; Mon, 15 Apr 2024 22:08:34 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:1137:d3d7:a09d:5379]) by smtp.gmail.com with ESMTPSA id ju17-20020a170903429100b001e49428f313sm8835349plb.261.2024.04.15.22.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 22:08:33 -0700 (PDT) Date: Tue, 16 Apr 2024 14:08:23 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: Ricardo Ribalda , Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?iso-8859-1?Q?S=F6derlund?= , Pavel Machek , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 03/35] media: uvcvideo: Refactor iterators Message-ID: <20240416050823.GC14947@google.com> References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> <20240415-fix-cocci-v1-3-477afb23728b@chromium.org> <20240416043916.GA14947@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240416043916.GA14947@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_220835_476007_9A6F88B6 X-CRM114-Status: GOOD ( 10.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On (24/04/16 13:39), Sergey Senozhatsky wrote: > On (24/04/15 19:34), Ricardo Ribalda wrote: > [..] > > @@ -2165,7 +2167,7 @@ static int uvc_ctrl_init_xu_ctrl(struct uvc_device *dev, > > int uvc_xu_ctrl_query(struct uvc_video_chain *chain, > > struct uvc_xu_control_query *xqry) > > { > > - struct uvc_entity *entity; > > + struct uvc_entity *entity, *iter; > > struct uvc_control *ctrl; > > unsigned int i; > > bool found; > > Is `found` still used? It is. Never mind. FWIW Reviewed-by: Sergey Senozhatsky _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel