From: Simon Horman <horms@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: elder@kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] net: ipa: Remove unnecessary print function dev_err()
Date: Tue, 16 Apr 2024 11:50:35 +0100 [thread overview]
Message-ID: <20240416105035.GJ2320920@kernel.org> (raw)
In-Reply-To: <20240415031456.10805-1-jiapeng.chong@linux.alibaba.com>
On Mon, Apr 15, 2024 at 11:14:56AM +0800, Jiapeng Chong wrote:
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
>
> ./drivers/net/ipa/ipa_interrupt.c:300:2-9: line 300 is redundant because platform_get_irq() already prints an error.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8756
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Hi Jiapeng Chong,
I don't think that you need to repost because of this,
but when sending Networking patches please specify the target tree
in the subject; net for fixes, and net-next for other patches.
e.g.
Subject: [PATCH net-next] ...
That notwithstanding, this patch looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-04-16 10:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 3:14 [PATCH] net: ipa: Remove unnecessary print function dev_err() Jiapeng Chong
2024-04-16 10:50 ` Simon Horman [this message]
2024-04-17 0:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416105035.GJ2320920@kernel.org \
--to=horms@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.