From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32FFC12A172; Tue, 16 Apr 2024 12:25:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713270312; cv=none; b=Qe5J1eNSOSqBwscL+8IEhnl9NCKmewC+awJiclVuDx+xUa7UK4Pf/20YC0bxlccLdECXO9NmAhbCu0zsDORi/aZu7/GwDKImMx5UWz0m0FE9mfRmJZYyP0ghzgTHp32a3SsGbYQXRNfpNOLNR5wkDasidj+Vz8Vpr4QxkO4EaiM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713270312; c=relaxed/simple; bh=SCges8dT7+vStvKdwldW6puBln6FxrIx8NsJAHgA4dU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tNYm8ufJuJN+AH3w4DrNDr89FfVakeI3R/dvZRa07QZNzhAWpf4gquWKLi/ir7xdscGggddLZjxtqCWo8z9vyl8Y4VOqSrAovEjbHyeI2/pkzi0O6kFa9s5yiWKLFonfPRpS11iPwTpQjFwnWCVnEEgPzxGF2TbpjBbhB8lR0Yw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dLELNjgk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dLELNjgk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94C9BC113CE; Tue, 16 Apr 2024 12:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713270311; bh=SCges8dT7+vStvKdwldW6puBln6FxrIx8NsJAHgA4dU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dLELNjgkJ8uBxjq5d2HVAG08umXZz/asximy7u3HShHBTFfgOWEGJQWA622y7ObRc zwYF9hPOT7NdQVDUdTZwnZ1xUGEDJTt9WeKDhPBm2C+kJz7+p+7x2pc/bVZZfhh39w sodPEU/xXGMH/4wjk2TIC360/+5OSZjMVgcQSDXQoftnCch459y7MjvWxHg6SXTi7c YLTbZdm75kYJJ0x8sCY+evcTzIqg3sx6JX6+3Mbm/ESrqflBuZ1zzQcoJFy9bIW9IL 312F2PowTrdWU8sOy1ILgv0n0T23QKhxjaiL3QhoxHsk6qBYb2iiw5lq+CCjmxRENe W//ndQe/2SA0A== Date: Tue, 16 Apr 2024 13:25:04 +0100 From: Lee Jones To: Bhargav Raviprakash Cc: arnd@arndb.de, broonie@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, eblanc@baylibre.com, gregkh@linuxfoundation.org, jpanis@baylibre.com, kristo@kernel.org, krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, m.nirmaladevi@ltts.com, nm@ti.com, robh+dt@kernel.org, vigneshr@ti.com, khilman@kernel.org Subject: Re: [RESEND PATCH v1 05/13] mfd: tps6594-spi: Add TI TPS65224 PMIC SPI Message-ID: <20240416122504.GV2399047@google.com> References: <20240411170344.GK2399047@google.com> <0109018ee1e1d91a-d3a0a73a-548d-4b9c-a6a5-a4f375c3adf3-000000@ap-south-1.amazonses.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0109018ee1e1d91a-d3a0a73a-548d-4b9c-a6a5-a4f375c3adf3-000000@ap-south-1.amazonses.com> On Mon, 15 Apr 2024, Bhargav Raviprakash wrote: > Hello, > > On Wed, 14 Feb 2024 10:10:17 -0800, Lee Jones wrote: > > On Mon, 08 Apr 2024, Bhargav Raviprakash wrote: > > > > > Introduces a new struct tps6594_match_data. This struct holds fields for > > > chip id and regmap config. Using this struct in of_device_id data field. > > > This helps in adding support for TPS65224 PMIC. > > > > > > Signed-off-by: Bhargav Raviprakash > > > Acked-by: Julien Panis > > > --- > > > drivers/mfd/tps6594-i2c.c | 24 ++++++++++++++++-------- > > > drivers/mfd/tps6594-spi.c | 24 ++++++++++++++++-------- > > > include/linux/mfd/tps6594.h | 11 +++++++++++ > > > 3 files changed, 43 insertions(+), 16 deletions(-) > > > > > > diff --git a/drivers/mfd/tps6594-i2c.c b/drivers/mfd/tps6594-i2c.c > > > index c125b474b..9e2ed48b7 100644 > > > --- a/drivers/mfd/tps6594-i2c.c > > > +++ b/drivers/mfd/tps6594-i2c.c > > > @@ -192,10 +192,16 @@ static const struct regmap_config tps6594_i2c_regmap_config = { > > > .write = tps6594_i2c_write, > > > }; > > > > > > +static const struct tps6594_match_data match_data[] = { > > > + [TPS6594] = {TPS6594, &tps6594_i2c_regmap_config}, > > > + [TPS6593] = {TPS6593, &tps6594_i2c_regmap_config}, > > > + [LP8764] = {LP8764, &tps6594_i2c_regmap_config}, > > > > Nit: There should be spaces after the '{' and before the '}'. > > > > Sure! will fix it in the next version. > > > > +}; > > > + > > > static const struct of_device_id tps6594_i2c_of_match_table[] = { > > > - { .compatible = "ti,tps6594-q1", .data = (void *)TPS6594, }, > > > - { .compatible = "ti,tps6593-q1", .data = (void *)TPS6593, }, > > > - { .compatible = "ti,lp8764-q1", .data = (void *)LP8764, }, > > > + { .compatible = "ti,tps6594-q1", .data = &match_data[TPS6594], }, > > > + { .compatible = "ti,tps6593-q1", .data = &match_data[TPS6593], }, > > > + { .compatible = "ti,lp8764-q1", .data = &match_data[LP8764], }, > > > > Not keen on this. Why do you pass the regmap data through here and > > leave everything else to be matched on device ID? It would be better to > > keep passing the device ID through and match everything off of that. > > > > > > -- > > Lee Jones [李琼斯] > > Thanks for the feedback! > > These changes were made because of the following message: > https://lore.kernel.org/all/7hcysy6ho6.fsf@baylibre.com/ > > Please let us know which one to follow. Right, except this doesn't eliminate "any \"if (chip_id)\" checking". Instead you have a hodge-podge of passing a little bit of (Regmap) data via match and the rest via "if (chip_id)". So either pass all platform type data via .data or just the chip ID. My suggestion 99% of the time is the latter. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87774C4345F for ; Tue, 16 Apr 2024 12:25:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Onm6899nb7RD5mVM/m81tJO2t6hzc1LILkSXplUSZWw=; b=q8gAyda0e0IJQ5 N9bPDlCLGYZYwDpUnpY3Xk6OsWTpIR7CsGiYIBVDDZzjiboaUns36nl52uULiysyBImLmMIBQmDiE 0aCkE1lDF+VE4rvXkPgs4YG4cQKGUbNdzXAE1JAG8nVGBkDXLoAzj3Xtn5Szby4vVCqsUFxxDz/yI 8rznguyWZ9q2yl7Bsr1pDNPxZnof61/qjaks34hLpwT1LrkESKr/bJc16JXzgZBhQnHGTqCGbE3ev T5KOEAJRhOOLQXIlGnB9RcfHlhBe3QV/YRGzRsJM1iTtWmSraum/eqeCzU75pLnafzKawcwptEZNY XJg1wqdUaLiGm3jCI+HA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwhsD-0000000C7q3-2zdt; Tue, 16 Apr 2024 12:25:17 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwhsA-0000000C7pc-3NhK for linux-arm-kernel@lists.infradead.org; Tue, 16 Apr 2024 12:25:16 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 0BB82CE103B; Tue, 16 Apr 2024 12:25:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94C9BC113CE; Tue, 16 Apr 2024 12:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713270311; bh=SCges8dT7+vStvKdwldW6puBln6FxrIx8NsJAHgA4dU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dLELNjgkJ8uBxjq5d2HVAG08umXZz/asximy7u3HShHBTFfgOWEGJQWA622y7ObRc zwYF9hPOT7NdQVDUdTZwnZ1xUGEDJTt9WeKDhPBm2C+kJz7+p+7x2pc/bVZZfhh39w sodPEU/xXGMH/4wjk2TIC360/+5OSZjMVgcQSDXQoftnCch459y7MjvWxHg6SXTi7c YLTbZdm75kYJJ0x8sCY+evcTzIqg3sx6JX6+3Mbm/ESrqflBuZ1zzQcoJFy9bIW9IL 312F2PowTrdWU8sOy1ILgv0n0T23QKhxjaiL3QhoxHsk6qBYb2iiw5lq+CCjmxRENe W//ndQe/2SA0A== Date: Tue, 16 Apr 2024 13:25:04 +0100 From: Lee Jones To: Bhargav Raviprakash Cc: arnd@arndb.de, broonie@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, eblanc@baylibre.com, gregkh@linuxfoundation.org, jpanis@baylibre.com, kristo@kernel.org, krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, m.nirmaladevi@ltts.com, nm@ti.com, robh+dt@kernel.org, vigneshr@ti.com, khilman@kernel.org Subject: Re: [RESEND PATCH v1 05/13] mfd: tps6594-spi: Add TI TPS65224 PMIC SPI Message-ID: <20240416122504.GV2399047@google.com> References: <20240411170344.GK2399047@google.com> <0109018ee1e1d91a-d3a0a73a-548d-4b9c-a6a5-a4f375c3adf3-000000@ap-south-1.amazonses.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0109018ee1e1d91a-d3a0a73a-548d-4b9c-a6a5-a4f375c3adf3-000000@ap-south-1.amazonses.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240416_052515_238809_398514E8 X-CRM114-Status: GOOD ( 25.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAxNSBBcHIgMjAyNCwgQmhhcmdhdiBSYXZpcHJha2FzaCB3cm90ZToKCj4gSGVsbG8s Cj4gCj4gT24gV2VkLCAxNCBGZWIgMjAyNCAxMDoxMDoxNyAtMDgwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+ID4gT24gTW9uLCAwOCBBcHIgMjAyNCwgQmhhcmdhdiBSYXZpcHJha2FzaCB3cm90ZToKPiA+ IAo+ID4gPiBJbnRyb2R1Y2VzIGEgbmV3IHN0cnVjdCB0cHM2NTk0X21hdGNoX2RhdGEuIFRoaXMg c3RydWN0IGhvbGRzIGZpZWxkcyBmb3IKPiA+ID4gY2hpcCBpZCBhbmQgcmVnbWFwIGNvbmZpZy4g VXNpbmcgdGhpcyBzdHJ1Y3QgaW4gb2ZfZGV2aWNlX2lkIGRhdGEgZmllbGQuCj4gPiA+IFRoaXMg aGVscHMgaW4gYWRkaW5nIHN1cHBvcnQgZm9yIFRQUzY1MjI0IFBNSUMuCj4gPiA+IAo+ID4gPiBT aWduZWQtb2ZmLWJ5OiBCaGFyZ2F2IFJhdmlwcmFrYXNoIDxiaGFyZ2F2LnJAbHR0cy5jb20+Cj4g PiA+IEFja2VkLWJ5OiBKdWxpZW4gUGFuaXMgPGpwYW5pc0BiYXlsaWJyZS5jb20+Cj4gPiA+IC0t LQo+ID4gPiAgZHJpdmVycy9tZmQvdHBzNjU5NC1pMmMuYyAgIHwgMjQgKysrKysrKysrKysrKysr Ky0tLS0tLS0tCj4gPiA+ICBkcml2ZXJzL21mZC90cHM2NTk0LXNwaS5jICAgfCAyNCArKysrKysr KysrKysrKysrLS0tLS0tLS0KPiA+ID4gIGluY2x1ZGUvbGludXgvbWZkL3RwczY1OTQuaCB8IDEx ICsrKysrKysrKysrCj4gPiA+ICAzIGZpbGVzIGNoYW5nZWQsIDQzIGluc2VydGlvbnMoKyksIDE2 IGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL3RwczY1 OTQtaTJjLmMgYi9kcml2ZXJzL21mZC90cHM2NTk0LWkyYy5jCj4gPiA+IGluZGV4IGMxMjViNDc0 Yi4uOWUyZWQ0OGI3IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL21mZC90cHM2NTk0LWkyYy5j Cj4gPiA+ICsrKyBiL2RyaXZlcnMvbWZkL3RwczY1OTQtaTJjLmMKPiA+ID4gQEAgLTE5MiwxMCAr MTkyLDE2IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmVnbWFwX2NvbmZpZyB0cHM2NTk0X2kyY19y ZWdtYXBfY29uZmlnID0gewo+ID4gPiAgCS53cml0ZSA9IHRwczY1OTRfaTJjX3dyaXRlLAo+ID4g PiAgfTsKPiA+ID4gIAo+ID4gPiArc3RhdGljIGNvbnN0IHN0cnVjdCB0cHM2NTk0X21hdGNoX2Rh dGEgbWF0Y2hfZGF0YVtdID0gewo+ID4gPiArCVtUUFM2NTk0XSA9IHtUUFM2NTk0LCAmdHBzNjU5 NF9pMmNfcmVnbWFwX2NvbmZpZ30sCj4gPiA+ICsJW1RQUzY1OTNdID0ge1RQUzY1OTMsICZ0cHM2 NTk0X2kyY19yZWdtYXBfY29uZmlnfSwKPiA+ID4gKwlbTFA4NzY0XSA9IHtMUDg3NjQsICZ0cHM2 NTk0X2kyY19yZWdtYXBfY29uZmlnfSwKPiA+IAo+ID4gTml0OiBUaGVyZSBzaG91bGQgYmUgc3Bh Y2VzIGFmdGVyIHRoZSAneycgYW5kIGJlZm9yZSB0aGUgJ30nLgo+ID4gCj4gCj4gU3VyZSEgd2ls bCBmaXggaXQgaW4gdGhlIG5leHQgdmVyc2lvbi4KPiAKPiA+ID4gK307Cj4gPiA+ICsKPiA+ID4g IHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIHRwczY1OTRfaTJjX29mX21hdGNoX3Rh YmxlW10gPSB7Cj4gPiA+IC0JeyAuY29tcGF0aWJsZSA9ICJ0aSx0cHM2NTk0LXExIiwgLmRhdGEg PSAodm9pZCAqKVRQUzY1OTQsIH0sCj4gPiA+IC0JeyAuY29tcGF0aWJsZSA9ICJ0aSx0cHM2NTkz LXExIiwgLmRhdGEgPSAodm9pZCAqKVRQUzY1OTMsIH0sCj4gPiA+IC0JeyAuY29tcGF0aWJsZSA9 ICJ0aSxscDg3NjQtcTEiLCAgLmRhdGEgPSAodm9pZCAqKUxQODc2NCwgIH0sCj4gPiA+ICsJeyAu Y29tcGF0aWJsZSA9ICJ0aSx0cHM2NTk0LXExIiwgLmRhdGEgPSAmbWF0Y2hfZGF0YVtUUFM2NTk0 XSwgfSwKPiA+ID4gKwl7IC5jb21wYXRpYmxlID0gInRpLHRwczY1OTMtcTEiLCAuZGF0YSA9ICZt YXRjaF9kYXRhW1RQUzY1OTNdLCB9LAo+ID4gPiArCXsgLmNvbXBhdGlibGUgPSAidGksbHA4NzY0 LXExIiwgIC5kYXRhID0gJm1hdGNoX2RhdGFbTFA4NzY0XSwgfSwKPiA+IAo+ID4gTm90IGtlZW4g b24gdGhpcy4gIFdoeSBkbyB5b3UgcGFzcyB0aGUgcmVnbWFwIGRhdGEgdGhyb3VnaCBoZXJlIGFu ZAo+ID4gbGVhdmUgZXZlcnl0aGluZyBlbHNlIHRvIGJlIG1hdGNoZWQgb24gZGV2aWNlIElEPyAg SXQgd291bGQgYmUgYmV0dGVyIHRvCj4gPiBrZWVwIHBhc3NpbmcgdGhlIGRldmljZSBJRCB0aHJv dWdoIGFuZCBtYXRjaCBldmVyeXRoaW5nIG9mZiBvZiB0aGF0Lgo+ID4gCj4gPiAKPiA+IC0tIAo+ ID4gTGVlIEpvbmVzIFvmnY7nkLzmlq9dCj4gCj4gVGhhbmtzIGZvciB0aGUgZmVlZGJhY2shCj4g Cj4gVGhlc2UgY2hhbmdlcyB3ZXJlIG1hZGUgYmVjYXVzZSBvZiB0aGUgZm9sbG93aW5nIG1lc3Nh Z2U6Cj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvYWxsLzdoY3lzeTZobzYuZnNmQGJheWxpYnJl LmNvbS8KPiAKPiBQbGVhc2UgbGV0IHVzIGtub3cgd2hpY2ggb25lIHRvIGZvbGxvdy4KClJpZ2h0 LCBleGNlcHQgdGhpcyBkb2Vzbid0IGVsaW1pbmF0ZSAiYW55IFwiaWYgKGNoaXBfaWQpXCIgY2hl Y2tpbmciLgpJbnN0ZWFkIHlvdSBoYXZlIGEgaG9kZ2UtcG9kZ2Ugb2YgcGFzc2luZyBhIGxpdHRs ZSBiaXQgb2YgKFJlZ21hcCkgZGF0YQp2aWEgbWF0Y2ggYW5kIHRoZSByZXN0IHZpYSAiaWYgKGNo aXBfaWQpIi4gIFNvIGVpdGhlciBwYXNzIGFsbCBwbGF0Zm9ybQp0eXBlIGRhdGEgdmlhIC5kYXRh IG9yIGp1c3QgdGhlIGNoaXAgSUQuICBNeSBzdWdnZXN0aW9uIDk5JSBvZiB0aGUgdGltZQppcyB0 aGUgbGF0dGVyLgoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=