From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C30A0130A64; Tue, 16 Apr 2024 15:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713281435; cv=none; b=r/LpuU6w/kofVcojAZFLARsVNrsdzE52B8J3mmERVNMsbon1VFIi82fd4ls7/aw/WTjIbLFAQZrOXrcArdUEky1hOkgMuqpI79/qYMaO7tb1X5gxkoZ/zra8aC6H7/4W6EzhvH5SjtAWs2Ze1kSib6F8Lm6YLtSOuOagSq9tr9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713281435; c=relaxed/simple; bh=KTwjHS73Lu4XfLDKXl1LN5UXGSE1ojUHnn6t6gVEtPw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=n9N4UzZaOZM9ET7V3zKjxKPapn0qNTfRFmrfYuy4y8EccEgAYTFyy1ihvP9Sf4hFW0d49zBov08NL+KKf3iu0lShveEpWm1uov6kQpYhQ4I32tnicEOfCmN+DmngNRa86KNOtNyz2zd5yoX/0qFEfwfuR1ngxlQH8lG28wju+ik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=tU6hSUFo; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=4318MZgE; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="tU6hSUFo"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="4318MZgE" Date: Tue, 16 Apr 2024 17:30:30 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1713281432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/LSuDC/ymF8z2X64UmjI9MyUScXW/UhH8vE7V8fGz5U=; b=tU6hSUFohIek7pzKcDEc/CheRfrN8t/vMyCYlmO7waFGMfIvGC1PnoxXYdl7wxT87TTtmE SbCh/Lcq6FFRydhx07E8DTwxP1Y7QZDUPffHSUpaPhP8ZCNraItSxVt5eb8HYBrk33PFVp ppD429FQDr4MVuU+cOgStLLxI4IwYpSjjjZvytWCktqcTV3JpNLHwKx7zsJJMsJCL+vGkx ATo/OTiXxi5WTe8TTVzQFM7zhK6DpSUMxXm+Xuaj4lGM9ukZ64FMjMz65bPpGDtNAnMcXP EH9hV+uk052DzW+m5IpmG33JT7vfXjy1OVK20XDgG2riQAnKkSks5kjpKUL6cA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1713281432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/LSuDC/ymF8z2X64UmjI9MyUScXW/UhH8vE7V8fGz5U=; b=4318MZgEIS6oeebPxlLTTsJKNStlrPvXZ/eIt4FO7nlThv5lb8q9p37CuFAL1bgXqbr1xL /QbtH7UA+6TxrjDQ== From: Nam Cao To: Mike Rapoport Cc: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Christian Brauner , Andreas Dilger , Al Viro , linux-fsdevel , Jan Kara , Linux Kernel Mailing List , linux-riscv@lists.infradead.org, Theodore Ts'o , Ext4 Developers List , Conor Dooley , "Matthew Wilcox (Oracle)" , Anders Roxell , Alexandre Ghiti Subject: Re: riscv32 EXT4 splat, 6.8 regression? Message-ID: <20240416173030.257f0807@namcao> In-Reply-To: <20240416171713.7d76fe7d@namcao> References: <20240416-deppen-gasleitung-8098fcfd6bbd@brauner> <8734rlo9j7.fsf@all.your.base.are.belong.to.us> <20240416171713.7d76fe7d@namcao> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2024-04-16 Nam Cao wrote: > On 2024-04-16 Mike Rapoport wrote: > > Hi, > >=20 > > On Tue, Apr 16, 2024 at 01:02:20PM +0200, Bj=C3=B6rn T=C3=B6pel wrote: > > > Christian Brauner writes: > > >=20 > > > > [Adding Mike who's knowledgeable in this area] > > >=20 > > > >> > Further, it seems like riscv32 indeed inserts a page like that t= o the > > > >> > buddy allocator, when the memblock is free'd: > > > >> >=20 > > > >> > | [] __free_one_page+0x2a4/0x3ea > > > >> > | [] __free_pages_ok+0x158/0x3cc > > > >> > | [] __free_pages_core+0xe8/0x12c > > > >> > | [] memblock_free_pages+0x1a/0x22 > > > >> > | [] memblock_free_all+0x1ee/0x278 > > > >> > | [] mem_init+0x10/0xa4 > > > >> > | [] mm_core_init+0x11a/0x2da > > > >> > | [] start_kernel+0x3c4/0x6de > > > >> >=20 > > > >> > Here, a page with VA 0xfffff000 is a added to the freelist. We w= ere just > > > >> > lucky (unlucky?) that page was used for the page cache. > > > >>=20 > > > >> I just educated myself about memory mapping last night, so the bel= ow > > > >> may be complete nonsense. Take it with a grain of salt. > > > >>=20 > > > >> In riscv's setup_bootmem(), we have this line: > > > >> max_low_pfn =3D max_pfn =3D PFN_DOWN(phys_ram_end); > > > >>=20 > > > >> I think this is the root cause: max_low_pfn indicates the last page > > > >> to be mapped. Problem is: nothing prevents PFN_DOWN(phys_ram_end) = from > > > >> getting mapped to the last page (0xfffff000). If max_low_pfn is ma= pped > > > >> to the last page, we get the reported problem. > > > >>=20 > > > >> There seems to be some code to make sure the last page is not used > > > >> (the call to memblock_set_current_limit() right above this line). = It is > > > >> unclear to me why this still lets the problem slip through. > > > >>=20 > > > >> The fix is simple: never let max_low_pfn gets mapped to the last p= age. > > > >> The below patch fixes the problem for me. But I am not entirely su= re if > > > >> this is the correct fix, further investigation needed. > > > >>=20 > > > >> Best regards, > > > >> Nam > > > >>=20 > > > >> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > > > >> index fa34cf55037b..17cab0a52726 100644 > > > >> --- a/arch/riscv/mm/init.c > > > >> +++ b/arch/riscv/mm/init.c > > > >> @@ -251,7 +251,8 @@ static void __init setup_bootmem(void) > > > >> } > > > >> =20 > > > >> min_low_pfn =3D PFN_UP(phys_ram_base); > > > >> - max_low_pfn =3D max_pfn =3D PFN_DOWN(phys_ram_end); > > > >> + max_low_pfn =3D PFN_DOWN(memblock_get_current_limit()); > > > >> + max_pfn =3D PFN_DOWN(phys_ram_end); > > > >> high_memory =3D (void *)(__va(PFN_PHYS(max_low_pfn))); > > > >> =20 > > > >> dma32_phys_limit =3D min(4UL * SZ_1G, (unsigned long)PFN_PHYS(ma= x_low_pfn)); > > >=20 > > > Yeah, AFAIU memblock_set_current_limit() only limits the allocation f= rom > > > memblock. The "forbidden" page (PA 0xc03ff000 VA 0xfffff000) will sti= ll > > > be allowed in the zone. > > >=20 > > > I think your patch requires memblock_set_current_limit() is > > > unconditionally called, which currently is not done. > > >=20 > > > The hack I tried was (which seems to work): > > >=20 > > > -- > > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > > > index fe8e159394d8..3a1f25d41794 100644 > > > --- a/arch/riscv/mm/init.c > > > +++ b/arch/riscv/mm/init.c > > > @@ -245,8 +245,10 @@ static void __init setup_bootmem(void) > > > */ > > > if (!IS_ENABLED(CONFIG_64BIT)) { > > > max_mapped_addr =3D __pa(~(ulong)0); > > > - if (max_mapped_addr =3D=3D (phys_ram_end - 1)) > > > + if (max_mapped_addr =3D=3D (phys_ram_end - 1)) { > > > memblock_set_current_limit(max_mapped_addr - = 4096); > > > + phys_ram_end -=3D 4096; > > > + } > > > } > >=20 > > You can just memblock_reserve() the last page of the first gigabyte, e.= g. >=20 > "last page of the first gigabyte" - why first gigabyte? Do you mean > last page of *last* gigabyte? >=20 > > if (!IS_ENABLED(CONFIG_64BIT) > > memblock_reserve(SZ_1G - PAGE_SIZE, PAGE_SIZE); > >=20 > > The page will still be mapped, but it will never make it to the page > > allocator. > >=20 > > The nice thing about it is, that memblock lets you to reserve regions t= hat are > > not necessarily populated, so there's no need to check where the actual= RAM > > ends. >=20 > I tried the suggested code, it didn't work. I think there are 2 > mistakes: > - last gigabyte, not first > - memblock_reserve() takes physical addresses as arguments, not > virtual addresses >=20 > The below patch fixes the problem. Is this what you really meant? >=20 > Best regards, > Nam >=20 > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index fa34cf55037b..ac7efdd77be8 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -245,6 +245,7 @@ static void __init setup_bootmem(void) > * be done as soon as the kernel mapping base address is determined. > */ > if (!IS_ENABLED(CONFIG_64BIT)) { > + memblock_reserve(__pa(-PAGE_SIZE), __pa(PAGE_SIZE)); ^ oops, this argument is size, not address. So using __pa is wrong here. Somehow it still worked. > max_mapped_addr =3D __pa(~(ulong)0); > if (max_mapped_addr =3D=3D (phys_ram_end - 1)) > memblock_set_current_limit(max_mapped_addr - 4096); >=20 Fixed version: diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index fa34cf55037b..af4192bc51d0 100644 --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -245,6 +245,7 @@ static void __init setup_bootmem(void) * be done as soon as the kernel mapping base address is determined. */ if (!IS_ENABLED(CONFIG_64BIT)) { + memblock_reserve(__pa(-PAGE_SIZE), PAGE_SIZE); max_mapped_addr =3D __pa(~(ulong)0); if (max_mapped_addr =3D=3D (phys_ram_end - 1)) memblock_set_current_limit(max_mapped_addr - 4096); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B620C04FF6 for ; Tue, 16 Apr 2024 15:30:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RUO1SF/l5HpGlGXJMy5SwaCMkX6L+Ae0DMb7aphgCZA=; b=iOVhgBmw0EFSMC dZ96prqViLj9hx34FAI28uTfYgfU7zNOiI+Fy5gwv4BW6okUUi9aHEM4uwbweY8MuEFBXRz6OMcyb pqWcrEFTySLD7stpbbtedGBwJb08PE6T6lgh6PGYE+MA5pB660seHJGlX9CMlXyvZi6EstyEtWR7W eARdVb1uO1Oc6X8x8iXm6du3x35Kq31TrGYPrwJIm/gCwGO9rEilSl9jyergNZG4EuhAz63XyuT7y 8x6AcWIvMNGY4UQ4X3JZpPZM1IIdwtgT4cIEs6UPjD8CQQJQ3cp+9F80BDdZM2dwjbo2WEXoBHRXs I1R6U87TbybQ0SY9HKbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwkle-0000000Cloa-2tD8; Tue, 16 Apr 2024 15:30:44 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwklV-0000000Clk1-3qxJ for linux-riscv@lists.infradead.org; Tue, 16 Apr 2024 15:30:40 +0000 Date: Tue, 16 Apr 2024 17:30:30 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1713281432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/LSuDC/ymF8z2X64UmjI9MyUScXW/UhH8vE7V8fGz5U=; b=tU6hSUFohIek7pzKcDEc/CheRfrN8t/vMyCYlmO7waFGMfIvGC1PnoxXYdl7wxT87TTtmE SbCh/Lcq6FFRydhx07E8DTwxP1Y7QZDUPffHSUpaPhP8ZCNraItSxVt5eb8HYBrk33PFVp ppD429FQDr4MVuU+cOgStLLxI4IwYpSjjjZvytWCktqcTV3JpNLHwKx7zsJJMsJCL+vGkx ATo/OTiXxi5WTe8TTVzQFM7zhK6DpSUMxXm+Xuaj4lGM9ukZ64FMjMz65bPpGDtNAnMcXP EH9hV+uk052DzW+m5IpmG33JT7vfXjy1OVK20XDgG2riQAnKkSks5kjpKUL6cA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1713281432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/LSuDC/ymF8z2X64UmjI9MyUScXW/UhH8vE7V8fGz5U=; b=4318MZgEIS6oeebPxlLTTsJKNStlrPvXZ/eIt4FO7nlThv5lb8q9p37CuFAL1bgXqbr1xL /QbtH7UA+6TxrjDQ== From: Nam Cao To: Mike Rapoport Cc: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Christian Brauner , Andreas Dilger , Al Viro , linux-fsdevel , Jan Kara , Linux Kernel Mailing List , linux-riscv@lists.infradead.org, Theodore Ts'o , Ext4 Developers List , Conor Dooley , "Matthew Wilcox (Oracle)" , Anders Roxell , Alexandre Ghiti Subject: Re: riscv32 EXT4 splat, 6.8 regression? Message-ID: <20240416173030.257f0807@namcao> In-Reply-To: <20240416171713.7d76fe7d@namcao> References: <20240416-deppen-gasleitung-8098fcfd6bbd@brauner> <8734rlo9j7.fsf@all.your.base.are.belong.to.us> <20240416171713.7d76fe7d@namcao> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240416_083034_349572_58C27864 X-CRM114-Status: GOOD ( 45.40 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wNC0xNiBOYW0gQ2FvIHdyb3RlOgo+IE9uIDIwMjQtMDQtMTYgTWlrZSBSYXBvcG9y dCB3cm90ZToKPiA+IEhpLAo+ID4gCj4gPiBPbiBUdWUsIEFwciAxNiwgMjAyNCBhdCAwMTowMjoy MFBNICswMjAwLCBCasO2cm4gVMO2cGVsIHdyb3RlOgo+ID4gPiBDaHJpc3RpYW4gQnJhdW5lciA8 YnJhdW5lckBrZXJuZWwub3JnPiB3cml0ZXM6Cj4gPiA+IAo+ID4gPiA+IFtBZGRpbmcgTWlrZSB3 aG8ncyBrbm93bGVkZ2VhYmxlIGluIHRoaXMgYXJlYV0KPiA+ID4gCj4gPiA+ID4+ID4gRnVydGhl ciwgaXQgc2VlbXMgbGlrZSByaXNjdjMyIGluZGVlZCBpbnNlcnRzIGEgcGFnZSBsaWtlIHRoYXQg dG8gdGhlCj4gPiA+ID4+ID4gYnVkZHkgYWxsb2NhdG9yLCB3aGVuIHRoZSBtZW1ibG9jayBpcyBm cmVlJ2Q6Cj4gPiA+ID4+ID4gCj4gPiA+ID4+ID4gICB8IFs8YzAyNDk2MWM+XSBfX2ZyZWVfb25l X3BhZ2UrMHgyYTQvMHgzZWEKPiA+ID4gPj4gPiAgIHwgWzxjMDI0YTQ0OD5dIF9fZnJlZV9wYWdl c19vaysweDE1OC8weDNjYwo+ID4gPiA+PiA+ICAgfCBbPGMwMjRiMWE0Pl0gX19mcmVlX3BhZ2Vz X2NvcmUrMHhlOC8weDEyYwo+ID4gPiA+PiA+ICAgfCBbPGMwYzE0MzVhPl0gbWVtYmxvY2tfZnJl ZV9wYWdlcysweDFhLzB4MjIKPiA+ID4gPj4gPiAgIHwgWzxjMGMxNzY3Nj5dIG1lbWJsb2NrX2Zy ZWVfYWxsKzB4MWVlLzB4Mjc4Cj4gPiA+ID4+ID4gICB8IFs8YzBjMDUwYjA+XSBtZW1faW5pdCsw eDEwLzB4YTQKPiA+ID4gPj4gPiAgIHwgWzxjMGMxNDQ3Yz5dIG1tX2NvcmVfaW5pdCsweDExYS8w eDJkYQo+ID4gPiA+PiA+ICAgfCBbPGMwYzAwYmI2Pl0gc3RhcnRfa2VybmVsKzB4M2M0LzB4NmRl Cj4gPiA+ID4+ID4gCj4gPiA+ID4+ID4gSGVyZSwgYSBwYWdlIHdpdGggVkEgMHhmZmZmZjAwMCBp cyBhIGFkZGVkIHRvIHRoZSBmcmVlbGlzdC4gV2Ugd2VyZSBqdXN0Cj4gPiA+ID4+ID4gbHVja3kg KHVubHVja3k/KSB0aGF0IHBhZ2Ugd2FzIHVzZWQgZm9yIHRoZSBwYWdlIGNhY2hlLgo+ID4gPiA+ PiAKPiA+ID4gPj4gSSBqdXN0IGVkdWNhdGVkIG15c2VsZiBhYm91dCBtZW1vcnkgbWFwcGluZyBs YXN0IG5pZ2h0LCBzbyB0aGUgYmVsb3cKPiA+ID4gPj4gbWF5IGJlIGNvbXBsZXRlIG5vbnNlbnNl LiBUYWtlIGl0IHdpdGggYSBncmFpbiBvZiBzYWx0Lgo+ID4gPiA+PiAKPiA+ID4gPj4gSW4gcmlz Y3YncyBzZXR1cF9ib290bWVtKCksIHdlIGhhdmUgdGhpcyBsaW5lOgo+ID4gPiA+PiAJbWF4X2xv d19wZm4gPSBtYXhfcGZuID0gUEZOX0RPV04ocGh5c19yYW1fZW5kKTsKPiA+ID4gPj4gCj4gPiA+ ID4+IEkgdGhpbmsgdGhpcyBpcyB0aGUgcm9vdCBjYXVzZTogbWF4X2xvd19wZm4gaW5kaWNhdGVz IHRoZSBsYXN0IHBhZ2UKPiA+ID4gPj4gdG8gYmUgbWFwcGVkLiBQcm9ibGVtIGlzOiBub3RoaW5n IHByZXZlbnRzIFBGTl9ET1dOKHBoeXNfcmFtX2VuZCkgZnJvbQo+ID4gPiA+PiBnZXR0aW5nIG1h cHBlZCB0byB0aGUgbGFzdCBwYWdlICgweGZmZmZmMDAwKS4gSWYgbWF4X2xvd19wZm4gaXMgbWFw cGVkCj4gPiA+ID4+IHRvIHRoZSBsYXN0IHBhZ2UsIHdlIGdldCB0aGUgcmVwb3J0ZWQgcHJvYmxl bS4KPiA+ID4gPj4gCj4gPiA+ID4+IFRoZXJlIHNlZW1zIHRvIGJlIHNvbWUgY29kZSB0byBtYWtl IHN1cmUgdGhlIGxhc3QgcGFnZSBpcyBub3QgdXNlZAo+ID4gPiA+PiAodGhlIGNhbGwgdG8gbWVt YmxvY2tfc2V0X2N1cnJlbnRfbGltaXQoKSByaWdodCBhYm92ZSB0aGlzIGxpbmUpLiBJdCBpcwo+ ID4gPiA+PiB1bmNsZWFyIHRvIG1lIHdoeSB0aGlzIHN0aWxsIGxldHMgdGhlIHByb2JsZW0gc2xp cCB0aHJvdWdoLgo+ID4gPiA+PiAKPiA+ID4gPj4gVGhlIGZpeCBpcyBzaW1wbGU6IG5ldmVyIGxl dCBtYXhfbG93X3BmbiBnZXRzIG1hcHBlZCB0byB0aGUgbGFzdCBwYWdlLgo+ID4gPiA+PiBUaGUg YmVsb3cgcGF0Y2ggZml4ZXMgdGhlIHByb2JsZW0gZm9yIG1lLiBCdXQgSSBhbSBub3QgZW50aXJl bHkgc3VyZSBpZgo+ID4gPiA+PiB0aGlzIGlzIHRoZSBjb3JyZWN0IGZpeCwgZnVydGhlciBpbnZl c3RpZ2F0aW9uIG5lZWRlZC4KPiA+ID4gPj4gCj4gPiA+ID4+IEJlc3QgcmVnYXJkcywKPiA+ID4g Pj4gTmFtCj4gPiA+ID4+IAo+ID4gPiA+PiBkaWZmIC0tZ2l0IGEvYXJjaC9yaXNjdi9tbS9pbml0 LmMgYi9hcmNoL3Jpc2N2L21tL2luaXQuYwo+ID4gPiA+PiBpbmRleCBmYTM0Y2Y1NTAzN2IuLjE3 Y2FiMGE1MjcyNiAxMDA2NDQKPiA+ID4gPj4gLS0tIGEvYXJjaC9yaXNjdi9tbS9pbml0LmMKPiA+ ID4gPj4gKysrIGIvYXJjaC9yaXNjdi9tbS9pbml0LmMKPiA+ID4gPj4gQEAgLTI1MSw3ICsyNTEs OCBAQCBzdGF0aWMgdm9pZCBfX2luaXQgc2V0dXBfYm9vdG1lbSh2b2lkKQo+ID4gPiA+PiAgCX0K PiA+ID4gPj4gIAo+ID4gPiA+PiAgCW1pbl9sb3dfcGZuID0gUEZOX1VQKHBoeXNfcmFtX2Jhc2Up Owo+ID4gPiA+PiAtCW1heF9sb3dfcGZuID0gbWF4X3BmbiA9IFBGTl9ET1dOKHBoeXNfcmFtX2Vu ZCk7Cj4gPiA+ID4+ICsJbWF4X2xvd19wZm4gPSBQRk5fRE9XTihtZW1ibG9ja19nZXRfY3VycmVu dF9saW1pdCgpKTsKPiA+ID4gPj4gKwltYXhfcGZuID0gUEZOX0RPV04ocGh5c19yYW1fZW5kKTsK PiA+ID4gPj4gIAloaWdoX21lbW9yeSA9ICh2b2lkICopKF9fdmEoUEZOX1BIWVMobWF4X2xvd19w Zm4pKSk7Cj4gPiA+ID4+ICAKPiA+ID4gPj4gIAlkbWEzMl9waHlzX2xpbWl0ID0gbWluKDRVTCAq IFNaXzFHLCAodW5zaWduZWQgbG9uZylQRk5fUEhZUyhtYXhfbG93X3BmbikpOwo+ID4gPiAKPiA+ ID4gWWVhaCwgQUZBSVUgbWVtYmxvY2tfc2V0X2N1cnJlbnRfbGltaXQoKSBvbmx5IGxpbWl0cyB0 aGUgYWxsb2NhdGlvbiBmcm9tCj4gPiA+IG1lbWJsb2NrLiBUaGUgImZvcmJpZGRlbiIgcGFnZSAo UEEgMHhjMDNmZjAwMCBWQSAweGZmZmZmMDAwKSB3aWxsIHN0aWxsCj4gPiA+IGJlIGFsbG93ZWQg aW4gdGhlIHpvbmUuCj4gPiA+IAo+ID4gPiBJIHRoaW5rIHlvdXIgcGF0Y2ggcmVxdWlyZXMgbWVt YmxvY2tfc2V0X2N1cnJlbnRfbGltaXQoKSBpcwo+ID4gPiB1bmNvbmRpdGlvbmFsbHkgY2FsbGVk LCB3aGljaCBjdXJyZW50bHkgaXMgbm90IGRvbmUuCj4gPiA+IAo+ID4gPiBUaGUgaGFjayBJIHRy aWVkIHdhcyAod2hpY2ggc2VlbXMgdG8gd29yayk6Cj4gPiA+IAo+ID4gPiAtLQo+ID4gPiBkaWZm IC0tZ2l0IGEvYXJjaC9yaXNjdi9tbS9pbml0LmMgYi9hcmNoL3Jpc2N2L21tL2luaXQuYwo+ID4g PiBpbmRleCBmZThlMTU5Mzk0ZDguLjNhMWYyNWQ0MTc5NCAxMDA2NDQKPiA+ID4gLS0tIGEvYXJj aC9yaXNjdi9tbS9pbml0LmMKPiA+ID4gKysrIGIvYXJjaC9yaXNjdi9tbS9pbml0LmMKPiA+ID4g QEAgLTI0NSw4ICsyNDUsMTAgQEAgc3RhdGljIHZvaWQgX19pbml0IHNldHVwX2Jvb3RtZW0odm9p ZCkKPiA+ID4gICAgICAgICAgKi8KPiA+ID4gICAgICAgICBpZiAoIUlTX0VOQUJMRUQoQ09ORklH XzY0QklUKSkgewo+ID4gPiAgICAgICAgICAgICAgICAgbWF4X21hcHBlZF9hZGRyID0gX19wYSh+ KHVsb25nKTApOwo+ID4gPiAtICAgICAgICAgICAgICAgaWYgKG1heF9tYXBwZWRfYWRkciA9PSAo cGh5c19yYW1fZW5kIC0gMSkpCj4gPiA+ICsgICAgICAgICAgICAgICBpZiAobWF4X21hcHBlZF9h ZGRyID09IChwaHlzX3JhbV9lbmQgLSAxKSkgewo+ID4gPiAgICAgICAgICAgICAgICAgICAgICAg ICBtZW1ibG9ja19zZXRfY3VycmVudF9saW1pdChtYXhfbWFwcGVkX2FkZHIgLSA0MDk2KTsKPiA+ ID4gKyAgICAgICAgICAgICAgICAgICAgICAgcGh5c19yYW1fZW5kIC09IDQwOTY7Cj4gPiA+ICsg ICAgICAgICAgICAgICB9Cj4gPiA+ICAgICAgICAgfQo+ID4gCj4gPiBZb3UgY2FuIGp1c3QgbWVt YmxvY2tfcmVzZXJ2ZSgpIHRoZSBsYXN0IHBhZ2Ugb2YgdGhlIGZpcnN0IGdpZ2FieXRlLCBlLmcu Cj4gCj4gImxhc3QgcGFnZSBvZiB0aGUgZmlyc3QgZ2lnYWJ5dGUiIC0gd2h5IGZpcnN0IGdpZ2Fi eXRlPyBEbyB5b3UgbWVhbgo+IGxhc3QgcGFnZSBvZiAqbGFzdCogZ2lnYWJ5dGU/Cj4gCj4gPiAJ aWYgKCFJU19FTkFCTEVEKENPTkZJR182NEJJVCkKPiA+IAkJbWVtYmxvY2tfcmVzZXJ2ZShTWl8x RyAtIFBBR0VfU0laRSwgUEFHRV9TSVpFKTsKPiA+IAo+ID4gVGhlIHBhZ2Ugd2lsbCBzdGlsbCBi ZSBtYXBwZWQsIGJ1dCBpdCB3aWxsIG5ldmVyIG1ha2UgaXQgdG8gdGhlIHBhZ2UKPiA+IGFsbG9j YXRvci4KPiA+IAo+ID4gVGhlIG5pY2UgdGhpbmcgYWJvdXQgaXQgaXMsIHRoYXQgbWVtYmxvY2sg bGV0cyB5b3UgdG8gcmVzZXJ2ZSByZWdpb25zIHRoYXQgYXJlCj4gPiBub3QgbmVjZXNzYXJpbHkg cG9wdWxhdGVkLCBzbyB0aGVyZSdzIG5vIG5lZWQgdG8gY2hlY2sgd2hlcmUgdGhlIGFjdHVhbCBS QU0KPiA+IGVuZHMuCj4gCj4gSSB0cmllZCB0aGUgc3VnZ2VzdGVkIGNvZGUsIGl0IGRpZG4ndCB3 b3JrLiBJIHRoaW5rIHRoZXJlIGFyZSAyCj4gbWlzdGFrZXM6Cj4gIC0gbGFzdCBnaWdhYnl0ZSwg bm90IGZpcnN0Cj4gIC0gbWVtYmxvY2tfcmVzZXJ2ZSgpIHRha2VzIHBoeXNpY2FsIGFkZHJlc3Nl cyBhcyBhcmd1bWVudHMsIG5vdAo+ICAgIHZpcnR1YWwgYWRkcmVzc2VzCj4gCj4gVGhlIGJlbG93 IHBhdGNoIGZpeGVzIHRoZSBwcm9ibGVtLiBJcyB0aGlzIHdoYXQgeW91IHJlYWxseSBtZWFudD8K PiAKPiBCZXN0IHJlZ2FyZHMsCj4gTmFtCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvcmlzY3YvbW0v aW5pdC5jIGIvYXJjaC9yaXNjdi9tbS9pbml0LmMKPiBpbmRleCBmYTM0Y2Y1NTAzN2IuLmFjN2Vm ZGQ3N2JlOCAxMDA2NDQKPiAtLS0gYS9hcmNoL3Jpc2N2L21tL2luaXQuYwo+ICsrKyBiL2FyY2gv cmlzY3YvbW0vaW5pdC5jCj4gQEAgLTI0NSw2ICsyNDUsNyBAQCBzdGF0aWMgdm9pZCBfX2luaXQg c2V0dXBfYm9vdG1lbSh2b2lkKQo+ICAJICogYmUgZG9uZSBhcyBzb29uIGFzIHRoZSBrZXJuZWwg bWFwcGluZyBiYXNlIGFkZHJlc3MgaXMgZGV0ZXJtaW5lZC4KPiAgCSAqLwo+ICAJaWYgKCFJU19F TkFCTEVEKENPTkZJR182NEJJVCkpIHsKPiArICAgICAgICAgICAgIG1lbWJsb2NrX3Jlc2VydmUo X19wYSgtUEFHRV9TSVpFKSwgX19wYShQQUdFX1NJWkUpKTsKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXiBvb3BzLCB0aGlzCgkJCWFyZ3VtZW50IGlz IHNpemUsIG5vdCBhZGRyZXNzLiBTbyB1c2luZyBfX3BhIGlzCgkJCXdyb25nIGhlcmUuIFNvbWVo b3cgaXQgc3RpbGwgd29ya2VkLgoKPiAgCQltYXhfbWFwcGVkX2FkZHIgPSBfX3BhKH4odWxvbmcp MCk7Cj4gIAkJaWYgKG1heF9tYXBwZWRfYWRkciA9PSAocGh5c19yYW1fZW5kIC0gMSkpCj4gIAkJ CW1lbWJsb2NrX3NldF9jdXJyZW50X2xpbWl0KG1heF9tYXBwZWRfYWRkciAtIDQwOTYpOwo+IAoK Rml4ZWQgdmVyc2lvbjoKCmRpZmYgLS1naXQgYS9hcmNoL3Jpc2N2L21tL2luaXQuYyBiL2FyY2gv cmlzY3YvbW0vaW5pdC5jCmluZGV4IGZhMzRjZjU1MDM3Yi4uYWY0MTkyYmM1MWQwIDEwMDY0NAot LS0gYS9hcmNoL3Jpc2N2L21tL2luaXQuYworKysgYi9hcmNoL3Jpc2N2L21tL2luaXQuYwpAQCAt MjQ1LDYgKzI0NSw3IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBzZXR1cF9ib290bWVtKHZvaWQpCiAJ ICogYmUgZG9uZSBhcyBzb29uIGFzIHRoZSBrZXJuZWwgbWFwcGluZyBiYXNlIGFkZHJlc3MgaXMg ZGV0ZXJtaW5lZC4KIAkgKi8KIAlpZiAoIUlTX0VOQUJMRUQoQ09ORklHXzY0QklUKSkgeworCQlt ZW1ibG9ja19yZXNlcnZlKF9fcGEoLVBBR0VfU0laRSksIFBBR0VfU0laRSk7CiAJCW1heF9tYXBw ZWRfYWRkciA9IF9fcGEofih1bG9uZykwKTsKIAkJaWYgKG1heF9tYXBwZWRfYWRkciA9PSAocGh5 c19yYW1fZW5kIC0gMSkpCiAJCQltZW1ibG9ja19zZXRfY3VycmVudF9saW1pdChtYXhfbWFwcGVk X2FkZHIgLSA0MDk2KTsKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1yaXNjdgo=