From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
tomi.valkeinen@ideasonboard.com, bingbu.cao@intel.com,
hongju.wang@intel.com, hverkuil@xs4all.nl,
Andrey Konovalov <andrey.konovalov@linaro.org>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Dmitry Perchanov <dmitry.perchanov@intel.com>,
"Ng, Khai Wen" <khai.wen.ng@intel.com>,
Alain Volmat <alain.volmat@foss.st.com>
Subject: [PATCH v9 07/46] media: v4l: Support line-based metadata capture
Date: Tue, 16 Apr 2024 22:32:40 +0300 [thread overview]
Message-ID: <20240416193319.778192-8-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20240416193319.778192-1-sakari.ailus@linux.intel.com>
Many camera sensors, among other devices, transmit embedded data and image
data for each CSI-2 frame. This embedded data typically contains register
configuration of the sensor that has been used to capture the image data
of the same frame.
The embedded data is received by the CSI-2 receiver and has the same
properties as the image data, including that it is line based: it has
width, height and bytesperline (stride).
Add these fields to struct v4l2_meta_format and document them.
Also add V4L2_FMT_FLAG_META_LINE_BASED to tell a given format is
line-based i.e. these fields of struct v4l2_meta_format are valid for it.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
.../userspace-api/media/v4l/dev-meta.rst | 21 +++++++++++++++++++
.../media/v4l/vidioc-enum-fmt.rst | 7 +++++++
.../media/videodev2.h.rst.exceptions | 1 +
drivers/media/v4l2-core/v4l2-ioctl.c | 5 +++--
include/uapi/linux/videodev2.h | 10 +++++++++
5 files changed, 42 insertions(+), 2 deletions(-)
diff --git a/Documentation/userspace-api/media/v4l/dev-meta.rst b/Documentation/userspace-api/media/v4l/dev-meta.rst
index 0e7e1ee1471a..5eee9ab60395 100644
--- a/Documentation/userspace-api/media/v4l/dev-meta.rst
+++ b/Documentation/userspace-api/media/v4l/dev-meta.rst
@@ -47,6 +47,12 @@ member of the ``fmt`` union as needed per the desired operation. Both drivers
and applications must set the remainder of the :c:type:`v4l2_format` structure
to 0.
+Devices that capture metadata by line have the struct v4l2_fmtdesc
+``V4L2_FMT_FLAG_META_LINE_BASED`` flag set for :c:func:`VIDIOC_ENUM_FMT`. Such
+devices can typically also :ref:`capture image data <capture>`. This primarily
+involves devices that receive the data from a different devices such as a camera
+sensor.
+
.. c:type:: v4l2_meta_format
.. tabularcolumns:: |p{1.4cm}|p{2.4cm}|p{13.5cm}|
@@ -65,3 +71,18 @@ to 0.
- ``buffersize``
- Maximum buffer size in bytes required for data. The value is set by the
driver.
+ * - __u32
+ - ``width``
+ - Width of a line of metadata in Data Units. Valid when
+ :c:type`v4l2_fmtdesc` flag ``V4L2_FMT_FLAG_META_LINE_BASED`` is set,
+ otherwise zero. See :c:func:`VIDIOC_ENUM_FMT`.
+ * - __u32
+ - ``height``
+ - Number of rows of metadata. Valid when :c:type`v4l2_fmtdesc` flag
+ ``V4L2_FMT_FLAG_META_LINE_BASED`` is set, otherwise zero. See
+ :c:func:`VIDIOC_ENUM_FMT`.
+ * - __u32
+ - ``bytesperline``
+ - Offset in bytes between the beginning of two consecutive lines. Valid
+ when :c:type`v4l2_fmtdesc` flag ``V4L2_FMT_FLAG_META_LINE_BASED`` is
+ set, otherwise zero. See :c:func:`VIDIOC_ENUM_FMT`.
diff --git a/Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst b/Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst
index 000c154b0f98..a439be1b15d1 100644
--- a/Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst
+++ b/Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst
@@ -227,6 +227,13 @@ the ``mbus_code`` field is handled differently:
The application can ask to configure the quantization of the capture
device when calling the :ref:`VIDIOC_S_FMT <VIDIOC_G_FMT>` ioctl with
:ref:`V4L2_PIX_FMT_FLAG_SET_CSC <v4l2-pix-fmt-flag-set-csc>` set.
+ * - ``V4L2_FMT_FLAG_META_LINE_BASED``
+ - 0x0200
+ - The metadata format is line-based. In this case the ``width``,
+ ``height`` and ``bytesperline`` fields of :c:type:`v4l2_meta_format` are
+ valid. The buffer consists of ``height`` lines, each having ``width``
+ Data Units of data and offset (in bytes) between the beginning of each
+ two consecutive lines is ``bytesperline``.
Return Value
============
diff --git a/Documentation/userspace-api/media/videodev2.h.rst.exceptions b/Documentation/userspace-api/media/videodev2.h.rst.exceptions
index 3e58aac4ef0b..bdc628e8c1d6 100644
--- a/Documentation/userspace-api/media/videodev2.h.rst.exceptions
+++ b/Documentation/userspace-api/media/videodev2.h.rst.exceptions
@@ -215,6 +215,7 @@ replace define V4L2_FMT_FLAG_CSC_XFER_FUNC fmtdesc-flags
replace define V4L2_FMT_FLAG_CSC_YCBCR_ENC fmtdesc-flags
replace define V4L2_FMT_FLAG_CSC_HSV_ENC fmtdesc-flags
replace define V4L2_FMT_FLAG_CSC_QUANTIZATION fmtdesc-flags
+replace define V4L2_FMT_FLAG_META_LINE_BASED fmtdesc-flags
# V4L2 timecode types
replace define V4L2_TC_TYPE_24FPS timecode-type
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
index ae2dca7f2817..2cfc9106857a 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -343,8 +343,9 @@ static void v4l_print_format(const void *arg, bool write_only)
case V4L2_BUF_TYPE_META_OUTPUT:
meta = &p->fmt.meta;
pixelformat = meta->dataformat;
- pr_cont(", dataformat=%p4cc, buffersize=%u\n",
- &pixelformat, meta->buffersize);
+ pr_cont(", dataformat=%p4cc, buffersize=%u, width=%u, height=%u, bytesperline=%u\n",
+ &pixelformat, meta->buffersize, meta->width,
+ meta->height, meta->bytesperline);
break;
}
}
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index c7cf20b5da67..37112dfebd0c 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -877,6 +877,7 @@ struct v4l2_fmtdesc {
#define V4L2_FMT_FLAG_CSC_YCBCR_ENC 0x0080
#define V4L2_FMT_FLAG_CSC_HSV_ENC V4L2_FMT_FLAG_CSC_YCBCR_ENC
#define V4L2_FMT_FLAG_CSC_QUANTIZATION 0x0100
+#define V4L2_FMT_FLAG_META_LINE_BASED 0x0200
/* Frame Size and frame rate enumeration */
/*
@@ -2424,10 +2425,19 @@ struct v4l2_sdr_format {
* struct v4l2_meta_format - metadata format definition
* @dataformat: little endian four character code (fourcc)
* @buffersize: maximum size in bytes required for data
+ * @width: number of data units of data per line (valid for line
+ * based formats only, see format documentation)
+ * @height: number of lines of data per buffer (valid for line based
+ * formats only)
+ * @bytesperline: offset between the beginnings of two adjacent lines in
+ * bytes (valid for line based formats only)
*/
struct v4l2_meta_format {
__u32 dataformat;
__u32 buffersize;
+ __u32 width;
+ __u32 height;
+ __u32 bytesperline;
} __attribute__ ((packed));
/**
--
2.39.2
next prev parent reply other threads:[~2024-04-16 19:33 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 19:32 [PATCH v9 00/46] Generic line based metadata support, internal pads Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 01/46] media: v4l2-subdev: Fix stream handling for crop API Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 02/46] media: v4l2-subdev: Clearly document that the crop API won't be extended Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 03/46] media: Documentation: Add "stream" into glossary Sakari Ailus
2024-04-19 16:02 ` Laurent Pinchart
2024-04-16 19:32 ` [PATCH v9 04/46] media: uapi: Add generic serial metadata mbus formats Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 05/46] media: uapi: Document which mbus format fields are valid for metadata Sakari Ailus
2024-04-19 16:05 ` Laurent Pinchart
2024-04-16 19:32 ` [PATCH v9 06/46] media: uapi: v4l: Add generic 8-bit metadata format definitions Sakari Ailus
2024-04-19 16:26 ` Laurent Pinchart
2024-04-23 7:04 ` Sakari Ailus
2024-04-23 7:32 ` Laurent Pinchart
2024-04-23 9:54 ` Sakari Ailus
2024-04-16 19:32 ` Sakari Ailus [this message]
2024-04-19 16:30 ` [PATCH v9 07/46] media: v4l: Support line-based metadata capture Laurent Pinchart
2024-04-23 7:31 ` Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 08/46] media: Documentation: Additional streams generally don't harm capture Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 09/46] media: Documentation: Document embedded data guidelines for camera sensors Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 10/46] media: Documentation: v4l: Document internal sink pads Sakari Ailus
2024-04-19 18:49 ` Laurent Pinchart
2024-04-23 10:27 ` Sakari Ailus
2024-04-23 12:56 ` Laurent Pinchart
2024-04-23 16:06 ` Sakari Ailus
2025-02-26 9:16 ` Mirela Rabulea
2025-02-26 9:49 ` Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 11/46] media: Documentation: Document S_ROUTING behaviour Sakari Ailus
2024-04-19 17:17 ` Laurent Pinchart
2024-04-23 10:08 ` Sakari Ailus
2024-04-23 12:59 ` Laurent Pinchart
2024-04-23 13:33 ` Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 12/46] media: v4l: subdev: Add a function to lock two sub-device states, use it Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 13/46] media: v4l: subdev: Move G_ROUTING handling below S_ROUTING Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 14/46] media: v4l: subdev: Copy argument back to user also for S_ROUTING Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 15/46] media: v4l: subdev: Add len_routes field to struct v4l2_subdev_routing Sakari Ailus
2024-04-19 22:45 ` Laurent Pinchart
2024-04-23 10:45 ` Sakari Ailus
2024-04-23 12:54 ` Laurent Pinchart
2024-04-23 16:05 ` Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 16/46] media: v4l: subdev: Return routes set using S_ROUTING Sakari Ailus
2024-04-19 22:55 ` Laurent Pinchart
2024-04-23 10:49 ` Sakari Ailus
2024-04-23 11:41 ` Laurent Pinchart
2024-04-16 19:32 ` [PATCH v9 17/46] media: v4l: subdev: Add trivial set_routing support Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 18/46] media: ccs: No need to set streaming to false in power off Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 19/46] media: ccs: Move ccs_pm_get_init function up Sakari Ailus
2024-04-20 7:53 ` Laurent Pinchart
2024-04-16 19:32 ` [PATCH v9 20/46] media: ccs: Rename out label of ccs_start_streaming Sakari Ailus
2024-04-20 8:01 ` Laurent Pinchart
2024-04-16 19:32 ` [PATCH v9 21/46] media: ccs: Use {enable,disable}_streams operations Sakari Ailus
2024-04-20 7:57 ` Laurent Pinchart
2024-04-16 19:32 ` [PATCH v9 22/46] media: ccs: Track streaming state Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 23/46] media: ccs: Move ccs_validate_csi_data_format up Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 24/46] media: ccs: Support frame descriptors Sakari Ailus
2024-04-20 8:00 ` Laurent Pinchart
2024-04-16 19:32 ` [PATCH v9 25/46] media: uapi: v4l: subdev: Enable streams API Sakari Ailus
2024-04-16 19:32 ` [PATCH v9 26/46] media: mc: Add INTERNAL pad flag Sakari Ailus
2024-04-16 19:33 ` [PATCH v9 27/46] media: uapi: ccs: Add media bus code for MIPI CCS embedded data Sakari Ailus
2024-04-20 8:10 ` Laurent Pinchart
2024-10-23 7:35 ` Jacopo Mondi
2024-04-16 19:33 ` [PATCH v9 28/46] media: Documentation: Document non-CCS use of CCS embedded data format Sakari Ailus
2024-04-20 8:12 ` Laurent Pinchart
2024-04-16 19:33 ` [PATCH v9 29/46] media: Documentation: ccs: Document routing Sakari Ailus
2024-04-20 8:31 ` Laurent Pinchart
2024-04-23 11:06 ` Sakari Ailus
2024-04-16 19:33 ` [PATCH v9 30/46] media: ccs: Add support for embedded data stream Sakari Ailus
2024-04-20 8:59 ` Laurent Pinchart
2024-04-23 12:33 ` Sakari Ailus
2024-04-23 12:50 ` Laurent Pinchart
2024-04-23 13:29 ` Sakari Ailus
2024-04-16 19:33 ` [PATCH v9 31/46] media: ccs: Remove ccs_get_crop_compose helper Sakari Ailus
2024-04-20 9:04 ` Laurent Pinchart
2024-04-16 19:33 ` [PATCH v9 32/46] media: ccs: Rely on sub-device state locking Sakari Ailus
2024-04-20 9:16 ` Laurent Pinchart
2025-09-22 7:38 ` Sakari Ailus
2024-04-16 19:33 ` [PATCH v9 33/46] media: ccs: Compute binning configuration from sub-device state Sakari Ailus
2024-04-20 9:19 ` Laurent Pinchart
2024-04-16 19:33 ` [PATCH v9 34/46] media: ccs: Compute scaling " Sakari Ailus
2024-04-20 9:24 ` Laurent Pinchart
2024-04-16 19:33 ` [PATCH v9 35/46] media: ccs: Remove which parameter from ccs_propagate Sakari Ailus
2024-04-16 19:33 ` [PATCH v9 36/46] media: uapi: Add media bus code for ov2740 embedded data Sakari Ailus
2024-04-20 9:29 ` Laurent Pinchart
2025-09-22 7:47 ` Sakari Ailus
2024-04-16 19:33 ` [PATCH v9 37/46] media: ov2740: Fix LINK_FREQ and PIXEL_RATE control value reporting Sakari Ailus
2024-04-20 9:42 ` Laurent Pinchart
2024-04-24 9:15 ` Sakari Ailus
2024-04-16 19:33 ` [PATCH v9 38/46] media: ov2740: Remove shorthand variables Sakari Ailus
2024-04-20 9:30 ` Laurent Pinchart
2024-04-16 19:33 ` [PATCH v9 39/46] media: ov2740: Switch to {enable,disable}_streams Sakari Ailus
2024-04-16 19:33 ` [PATCH v9 40/46] media: ov2740: Track streaming state Sakari Ailus
2024-04-16 19:33 ` [PATCH v9 41/46] media: ov2740: Add support for embedded data Sakari Ailus
2024-04-20 9:38 ` Laurent Pinchart
2024-04-16 19:33 ` [PATCH v9 42/46] media: ov2740: Add generic sensor fwnode properties as controls Sakari Ailus
2024-04-20 9:40 ` Laurent Pinchart
2024-04-23 16:17 ` Sakari Ailus
2024-04-24 8:51 ` Laurent Pinchart
2024-04-16 19:33 ` [PATCH v9 43/46] media: ov2740: Add support for G_SELECTION IOCTL Sakari Ailus
2024-04-20 9:43 ` Laurent Pinchart
2024-04-16 19:33 ` [PATCH v9 44/46] media: v4l: Add V4L2_SUBDEV_ROUTE_FL_IMMUTABLE sub-device routing flag Sakari Ailus
2024-04-20 9:49 ` Laurent Pinchart
2024-04-16 19:33 ` [PATCH v9 45/46] media: ccs: Add IMMUTABLE route flag Sakari Ailus
2024-04-16 19:33 ` [PATCH v9 46/46] media: ov2740: " Sakari Ailus
2024-04-20 10:05 ` [PATCH v9 00/46] Generic line based metadata support, internal pads Laurent Pinchart
2024-09-30 13:20 ` Mirela Rabulea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416193319.778192-8-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=alain.volmat@foss.st.com \
--cc=andrey.konovalov@linaro.org \
--cc=bingbu.cao@intel.com \
--cc=dmitry.perchanov@intel.com \
--cc=hongju.wang@intel.com \
--cc=hverkuil@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=khai.wen.ng@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.