From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F052A132C1F; Tue, 16 Apr 2024 18:09:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713290958; cv=none; b=SqNCjE1JgzJQNA3vD4pAmyt9XcPtjkhjnMjoHeNkdDjFc38rzwMJRxKoKnNGn4ts4FhpZc6bvORWl/ABwTIdUgtJcNxuECZDxglBP3n2Vkije+rHjGuOkADAIwQ0O97TEI1WjSzOZ18C16ugGfY+oSQ+h3J/kTEVwiJhud4ey3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713290958; c=relaxed/simple; bh=H8MrxffkceMumKJooGQ32Ry3ywid0CvWTua4pVRYLN4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qtMhSQ+EUtSTAjMSeTO+QN21B1lK+YV01ciDx5e2DtGEIrDkOzX7fwjUjLfue4dHTpbgjGeVPyZ6hSZKvadiLsUYaSvxdnw9nJ8WV3R2v6ogIyxfSx1uYgvEYiO6PmsZ+srMIa4SZ6iKOjI+t0iMRPA8b9tR7OwwS8H3kZ3qncg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=GMhnFAjb; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=ixQmOQ/Z; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="GMhnFAjb"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ixQmOQ/Z" Date: Tue, 16 Apr 2024 20:09:10 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1713290953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SKLrAI5OCUe/r2J49t7qM8eP1fCwVfsTtu23X+cbhBw=; b=GMhnFAjb5aq0fLq1hjaVwDC+5vKgO0aCNwGaU5Cg54Dwdl9OeS42slUU0vCDSUpV6s95+f So/JFdqMFwQ0NhjaqOe7zQ6d/VA+QxIwi1ucEUpCvWu3Z99MtkGTlNIi+1NEvgulAc7YK4 mGvSc0PTS7Km/W9dDgIwMo0psk4jzZkt8Hjk2JQlw+oovvt5+rRdK1El/jdfj0lNyKmJM8 K3c5LmVS0QcaJ04UQk8GV7B8uhyW95BRdfrKnE8JKF2ILPHxVKa8r24H2DSgA65SfvSj8e eEa7YmcRxOk5ZCcqgm4uc/7pdnlChnyC0eyqwezB7TpQ98nV0HvVanFPYH5acA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1713290953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SKLrAI5OCUe/r2J49t7qM8eP1fCwVfsTtu23X+cbhBw=; b=ixQmOQ/Z45c/M1fP70O0/XH6yLZ1zVX1OS5AAh3Zp3iBkAq1q4nMCxItjJ18ha6HRKoS0G uM/NfWOUolPOHiBA== From: Nam Cao To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Cc: Mike Rapoport , Christian Brauner , Andreas Dilger , Al Viro , linux-fsdevel , Jan Kara , Linux Kernel Mailing List , linux-riscv@lists.infradead.org, Theodore Ts'o , Ext4 Developers List , Conor Dooley , "Matthew Wilcox (Oracle)" , Anders Roxell , Alexandre Ghiti Subject: Re: riscv32 EXT4 splat, 6.8 regression? Message-ID: <20240416200910.294ea07b@namcao> In-Reply-To: <875xwhuqrx.fsf@all.your.base.are.belong.to.us> References: <20240416-deppen-gasleitung-8098fcfd6bbd@brauner> <8734rlo9j7.fsf@all.your.base.are.belong.to.us> <20240416171713.7d76fe7d@namcao> <20240416173030.257f0807@namcao> <87v84h2tee.fsf@all.your.base.are.belong.to.us> <20240416181944.23af44ee@namcao> <875xwhuqrx.fsf@all.your.base.are.belong.to.us> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2024-04-16 Bj=C3=B6rn T=C3=B6pel wrote: > Nam Cao writes: >=20 > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > > index fa34cf55037b..f600cfee0aef 100644 > > --- a/arch/riscv/mm/init.c > > +++ b/arch/riscv/mm/init.c > > @@ -197,7 +197,6 @@ early_param("mem", early_mem); > > static void __init setup_bootmem(void) > > { > > phys_addr_t vmlinux_end =3D __pa_symbol(&_end); > > - phys_addr_t max_mapped_addr; > > phys_addr_t phys_ram_end, vmlinux_start; > > =20 > > if (IS_ENABLED(CONFIG_XIP_KERNEL)) > > @@ -238,17 +237,9 @@ static void __init setup_bootmem(void) > > /* > > * memblock allocator is not aware of the fact that last 4K bytes of > > * the addressable memory can not be mapped because of IS_ERR_VALUE > > - * macro. Make sure that last 4k bytes are not usable by memblock > > - * if end of dram is equal to maximum addressable memory. For 64-bit > > - * kernel, this problem can't happen here as the end of the virtual > > - * address space is occupied by the kernel mapping then this check mu= st > > - * be done as soon as the kernel mapping base address is determined. > > + * macro. Make sure that last 4k bytes are not usable by memblock. > > */ > > - if (!IS_ENABLED(CONFIG_64BIT)) { > > - max_mapped_addr =3D __pa(~(ulong)0); > > - if (max_mapped_addr =3D=3D (phys_ram_end - 1)) > > - memblock_set_current_limit(max_mapped_addr - 4096); > > - } > > + memblock_reserve(__pa(-PAGE_SIZE), PAGE_SIZE); > > =20 > > min_low_pfn =3D PFN_UP(phys_ram_base); > > max_low_pfn =3D max_pfn =3D PFN_DOWN(phys_ram_end); =20 >=20 > Nice! Would you mind submitting this as a proper fix (unless there's a > way to do it non-arch specific like Matthew pointed out). I don't mind, but I am waiting for the discussion on the non-arch solution. Best regards, Nam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BD62C4345F for ; Tue, 16 Apr 2024 18:09:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6FT/QP4xEcbNwxTg6fu1JyHt7bQNosrJF8i2Jmfmrew=; b=VQ8qR57ZxqekLg 3Z02psyeRL4eUd0CWC+8RdnMbjUSPmkKS7ZwmgbFWkSwWEwTe5C9wEJEuR11Oy8BY+3Cg5szfN70/ r2YHN4O/f3TPVi+KeEmY6+BUZtiiOHx35KfX39YXDXF4CKQY0UxXxfvVJeim/Hu/Ss/ZxGLtjcYRT SYT4inXaroialhPMhvhYpXHk7dGVdrYt1Mx5W4iopLAFG31sO9RT6jC5m45QePJAX2ivv12Unl5i0 WdypLPMbIqc3qtnowH7NvKe7iPckKz3SxXkefEtSapGodORGN0QiHp1kbT2/eij9qDQm13ok5gIct J9cwBZklT7AE9qTWs9qA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwnFF-0000000DGcH-31oF; Tue, 16 Apr 2024 18:09:26 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwnF8-0000000DGaG-2WLb for linux-riscv@lists.infradead.org; Tue, 16 Apr 2024 18:09:24 +0000 Date: Tue, 16 Apr 2024 20:09:10 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1713290953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SKLrAI5OCUe/r2J49t7qM8eP1fCwVfsTtu23X+cbhBw=; b=GMhnFAjb5aq0fLq1hjaVwDC+5vKgO0aCNwGaU5Cg54Dwdl9OeS42slUU0vCDSUpV6s95+f So/JFdqMFwQ0NhjaqOe7zQ6d/VA+QxIwi1ucEUpCvWu3Z99MtkGTlNIi+1NEvgulAc7YK4 mGvSc0PTS7Km/W9dDgIwMo0psk4jzZkt8Hjk2JQlw+oovvt5+rRdK1El/jdfj0lNyKmJM8 K3c5LmVS0QcaJ04UQk8GV7B8uhyW95BRdfrKnE8JKF2ILPHxVKa8r24H2DSgA65SfvSj8e eEa7YmcRxOk5ZCcqgm4uc/7pdnlChnyC0eyqwezB7TpQ98nV0HvVanFPYH5acA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1713290953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SKLrAI5OCUe/r2J49t7qM8eP1fCwVfsTtu23X+cbhBw=; b=ixQmOQ/Z45c/M1fP70O0/XH6yLZ1zVX1OS5AAh3Zp3iBkAq1q4nMCxItjJ18ha6HRKoS0G uM/NfWOUolPOHiBA== From: Nam Cao To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Cc: Mike Rapoport , Christian Brauner , Andreas Dilger , Al Viro , linux-fsdevel , Jan Kara , Linux Kernel Mailing List , linux-riscv@lists.infradead.org, Theodore Ts'o , Ext4 Developers List , Conor Dooley , "Matthew Wilcox (Oracle)" , Anders Roxell , Alexandre Ghiti Subject: Re: riscv32 EXT4 splat, 6.8 regression? Message-ID: <20240416200910.294ea07b@namcao> In-Reply-To: <875xwhuqrx.fsf@all.your.base.are.belong.to.us> References: <20240416-deppen-gasleitung-8098fcfd6bbd@brauner> <8734rlo9j7.fsf@all.your.base.are.belong.to.us> <20240416171713.7d76fe7d@namcao> <20240416173030.257f0807@namcao> <87v84h2tee.fsf@all.your.base.are.belong.to.us> <20240416181944.23af44ee@namcao> <875xwhuqrx.fsf@all.your.base.are.belong.to.us> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240416_110919_289989_8121A700 X-CRM114-Status: GOOD ( 17.28 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wNC0xNiBCasO2cm4gVMO2cGVsIHdyb3RlOgo+IE5hbSBDYW8gPG5hbWNhb0BsaW51 dHJvbml4LmRlPiB3cml0ZXM6Cj4gCj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9yaXNjdi9tbS9pbml0 LmMgYi9hcmNoL3Jpc2N2L21tL2luaXQuYwo+ID4gaW5kZXggZmEzNGNmNTUwMzdiLi5mNjAwY2Zl ZTBhZWYgMTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL3Jpc2N2L21tL2luaXQuYwo+ID4gKysrIGIvYXJj aC9yaXNjdi9tbS9pbml0LmMKPiA+IEBAIC0xOTcsNyArMTk3LDYgQEAgZWFybHlfcGFyYW0oIm1l bSIsIGVhcmx5X21lbSk7Cj4gPiAgc3RhdGljIHZvaWQgX19pbml0IHNldHVwX2Jvb3RtZW0odm9p ZCkKPiA+ICB7Cj4gPiAgCXBoeXNfYWRkcl90IHZtbGludXhfZW5kID0gX19wYV9zeW1ib2woJl9l bmQpOwo+ID4gLQlwaHlzX2FkZHJfdCBtYXhfbWFwcGVkX2FkZHI7Cj4gPiAgCXBoeXNfYWRkcl90 IHBoeXNfcmFtX2VuZCwgdm1saW51eF9zdGFydDsKPiA+ICAKPiA+ICAJaWYgKElTX0VOQUJMRUQo Q09ORklHX1hJUF9LRVJORUwpKQo+ID4gQEAgLTIzOCwxNyArMjM3LDkgQEAgc3RhdGljIHZvaWQg X19pbml0IHNldHVwX2Jvb3RtZW0odm9pZCkKPiA+ICAJLyoKPiA+ICAJICogbWVtYmxvY2sgYWxs b2NhdG9yIGlzIG5vdCBhd2FyZSBvZiB0aGUgZmFjdCB0aGF0IGxhc3QgNEsgYnl0ZXMgb2YKPiA+ ICAJICogdGhlIGFkZHJlc3NhYmxlIG1lbW9yeSBjYW4gbm90IGJlIG1hcHBlZCBiZWNhdXNlIG9m IElTX0VSUl9WQUxVRQo+ID4gLQkgKiBtYWNyby4gTWFrZSBzdXJlIHRoYXQgbGFzdCA0ayBieXRl cyBhcmUgbm90IHVzYWJsZSBieSBtZW1ibG9jawo+ID4gLQkgKiBpZiBlbmQgb2YgZHJhbSBpcyBl cXVhbCB0byBtYXhpbXVtIGFkZHJlc3NhYmxlIG1lbW9yeS4gIEZvciA2NC1iaXQKPiA+IC0JICog a2VybmVsLCB0aGlzIHByb2JsZW0gY2FuJ3QgaGFwcGVuIGhlcmUgYXMgdGhlIGVuZCBvZiB0aGUg dmlydHVhbAo+ID4gLQkgKiBhZGRyZXNzIHNwYWNlIGlzIG9jY3VwaWVkIGJ5IHRoZSBrZXJuZWwg bWFwcGluZyB0aGVuIHRoaXMgY2hlY2sgbXVzdAo+ID4gLQkgKiBiZSBkb25lIGFzIHNvb24gYXMg dGhlIGtlcm5lbCBtYXBwaW5nIGJhc2UgYWRkcmVzcyBpcyBkZXRlcm1pbmVkLgo+ID4gKwkgKiBt YWNyby4gTWFrZSBzdXJlIHRoYXQgbGFzdCA0ayBieXRlcyBhcmUgbm90IHVzYWJsZSBieSBtZW1i bG9jay4KPiA+ICAJICovCj4gPiAtCWlmICghSVNfRU5BQkxFRChDT05GSUdfNjRCSVQpKSB7Cj4g PiAtCQltYXhfbWFwcGVkX2FkZHIgPSBfX3BhKH4odWxvbmcpMCk7Cj4gPiAtCQlpZiAobWF4X21h cHBlZF9hZGRyID09IChwaHlzX3JhbV9lbmQgLSAxKSkKPiA+IC0JCQltZW1ibG9ja19zZXRfY3Vy cmVudF9saW1pdChtYXhfbWFwcGVkX2FkZHIgLSA0MDk2KTsKPiA+IC0JfQo+ID4gKwltZW1ibG9j a19yZXNlcnZlKF9fcGEoLVBBR0VfU0laRSksIFBBR0VfU0laRSk7Cj4gPiAgCj4gPiAgCW1pbl9s b3dfcGZuID0gUEZOX1VQKHBoeXNfcmFtX2Jhc2UpOwo+ID4gIAltYXhfbG93X3BmbiA9IG1heF9w Zm4gPSBQRk5fRE9XTihwaHlzX3JhbV9lbmQpOyAgCj4gCj4gTmljZSEgV291bGQgeW91IG1pbmQg c3VibWl0dGluZyB0aGlzIGFzIGEgcHJvcGVyIGZpeCAodW5sZXNzIHRoZXJlJ3MgYQo+IHdheSB0 byBkbyBpdCBub24tYXJjaCBzcGVjaWZpYyBsaWtlIE1hdHRoZXcgcG9pbnRlZCBvdXQpLgoKSSBk b24ndCBtaW5kLCBidXQgSSBhbSB3YWl0aW5nIGZvciB0aGUgZGlzY3Vzc2lvbiBvbiB0aGUgbm9u LWFyY2ggc29sdXRpb24uCgpCZXN0IHJlZ2FyZHMsCk5hbQoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4 LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=