From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Linus Walleij" <linus.walleij@linaro.org>,
"Kent Gibson" <warthog618@gmail.com>,
"Gunnar Thörnqvist" <gunnar@igl.se>
Cc: linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [libgpiod][PATCH v2 1/4] tools: rename timeout to idle_timeout in gpiomon and gpionotify
Date: Tue, 16 Apr 2024 23:52:19 +0200 [thread overview]
Message-ID: <20240416215222.175166-2-brgl@bgdev.pl> (raw)
In-Reply-To: <20240416215222.175166-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Use a more meaningful name for the variable storing the idle timeout
value.
Suggested-by: Kent Gibson <warthog618@gmail.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
tools/gpiomon.c | 8 ++++----
tools/gpionotify.c | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/gpiomon.c b/tools/gpiomon.c
index e3abb2d..40e6ac2 100644
--- a/tools/gpiomon.c
+++ b/tools/gpiomon.c
@@ -30,7 +30,7 @@ struct config {
const char *fmt;
enum gpiod_line_clock event_clock;
int timestamp_fmt;
- int timeout;
+ int idle_timeout;
};
static void print_help(void)
@@ -143,7 +143,7 @@ static int parse_config(int argc, char **argv, struct config *cfg)
memset(cfg, 0, sizeof(*cfg));
cfg->edges = GPIOD_LINE_EDGE_BOTH;
cfg->consumer = "gpiomon";
- cfg->timeout = -1;
+ cfg->idle_timeout = -1;
for (;;) {
optc = getopt_long(argc, argv, shortopts, longopts, &opti);
@@ -176,7 +176,7 @@ static int parse_config(int argc, char **argv, struct config *cfg)
cfg->fmt = optarg;
break;
case 'i':
- cfg->timeout = parse_period_or_die(optarg) / 1000;
+ cfg->idle_timeout = parse_period_or_die(optarg) / 1000;
break;
case 'l':
cfg->active_low = true;
@@ -453,7 +453,7 @@ int main(int argc, char **argv)
for (;;) {
fflush(stdout);
- ret = poll(pollfds, resolver->num_chips, cfg.timeout);
+ ret = poll(pollfds, resolver->num_chips, cfg.idle_timeout);
if (ret < 0)
die_perror("error polling for events");
diff --git a/tools/gpionotify.c b/tools/gpionotify.c
index 2c56590..d2aee15 100644
--- a/tools/gpionotify.c
+++ b/tools/gpionotify.c
@@ -23,7 +23,7 @@ struct config {
const char *chip_id;
const char *fmt;
int timestamp_fmt;
- int timeout;
+ int idle_timeout;
};
static void print_help(void)
@@ -108,7 +108,7 @@ static int parse_config(int argc, char **argv, struct config *cfg)
int opti, optc;
memset(cfg, 0, sizeof(*cfg));
- cfg->timeout = -1;
+ cfg->idle_timeout = -1;
for (;;) {
optc = getopt_long(argc, argv, shortopts, longopts, &opti);
@@ -132,7 +132,7 @@ static int parse_config(int argc, char **argv, struct config *cfg)
cfg->fmt = optarg;
break;
case 'i':
- cfg->timeout = parse_period_or_die(optarg) / 1000;
+ cfg->idle_timeout = parse_period_or_die(optarg) / 1000;
break;
case 'n':
cfg->events_wanted = parse_uint_or_die(optarg);
@@ -422,7 +422,7 @@ int main(int argc, char **argv)
for (;;) {
fflush(stdout);
- ret = poll(pollfds, resolver->num_chips, cfg.timeout);
+ ret = poll(pollfds, resolver->num_chips, cfg.idle_timeout);
if (ret < 0)
die_perror("error polling for events");
--
2.40.1
next prev parent reply other threads:[~2024-04-16 21:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 21:52 [libgpiod][PATCH v2 0/4] tools: timeout handling improvements Bartosz Golaszewski
2024-04-16 21:52 ` Bartosz Golaszewski [this message]
2024-04-16 21:52 ` [libgpiod][PATCH v2 2/4] tools: use ppoll() where higher timeout resolution makes sense Bartosz Golaszewski
2024-04-17 7:23 ` Kent Gibson
2024-04-22 18:15 ` Bartosz Golaszewski
2024-04-22 23:31 ` Kent Gibson
2024-04-16 21:52 ` [libgpiod][PATCH v2 3/4] tools: allow longer time periods Bartosz Golaszewski
2024-04-16 21:52 ` [libgpiod][PATCH v2 4/4] tools: add minutes as a new supported time unit Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416215222.175166-2-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=bartosz.golaszewski@linaro.org \
--cc=gunnar@igl.se \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.