All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Reshma Pattan <reshma.pattan@intel.com>
Subject: [PATCH v3 2/5] latencystats: handle fractional cycles per ns
Date: Wed, 17 Apr 2024 10:07:24 -0700	[thread overview]
Message-ID: <20240417170908.76701-3-stephen@networkplumber.org> (raw)
In-Reply-To: <20240417170908.76701-1-stephen@networkplumber.org>

The timer_hz is not always an integral number of nanoseconds.
For examples, cycles per nanoseconds on my test system is 2.8.
Fix by using floating point where needed.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/latencystats/rte_latencystats.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c
index 9b345bfb33..fe8c3c563a 100644
--- a/lib/latencystats/rte_latencystats.c
+++ b/lib/latencystats/rte_latencystats.c
@@ -19,10 +19,10 @@
 #define NS_PER_SEC 1E9
 
 /** Clock cycles per nano second */
-static uint64_t
+static float
 latencystat_cycles_per_ns(void)
 {
-	return rte_get_timer_hz() / NS_PER_SEC;
+	return (double)rte_get_timer_hz() / NS_PER_SEC;
 }
 
 RTE_LOG_REGISTER_DEFAULT(latencystat_logtype, INFO);
@@ -89,8 +89,7 @@ rte_latencystats_update(void)
 	for (i = 0; i < NUM_LATENCY_STATS; i++) {
 		stats_ptr = RTE_PTR_ADD(glob_stats,
 				lat_stats_strings[i].offset);
-		values[i] = (uint64_t)floor((*stats_ptr)/
-				latencystat_cycles_per_ns());
+		values[i] = floor(*stats_ptr / latencystat_cycles_per_ns());
 	}
 
 	ret = rte_metrics_update_values(RTE_METRICS_GLOBAL,
@@ -112,8 +111,7 @@ rte_latencystats_fill_values(struct rte_metric_value *values)
 		stats_ptr = RTE_PTR_ADD(glob_stats,
 				lat_stats_strings[i].offset);
 		values[i].key = i;
-		values[i].value = (uint64_t)floor((*stats_ptr)/
-						latencystat_cycles_per_ns());
+		values[i].value = floor(*stats_ptr / latencystat_cycles_per_ns());
 	}
 }
 
@@ -237,7 +235,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,
 
 	glob_stats = mz->addr;
 	rte_spinlock_init(&glob_stats->lock);
-	samp_intvl = app_samp_intvl * latencystat_cycles_per_ns();
+	samp_intvl = floor(app_samp_intvl * latencystat_cycles_per_ns());
 
 	/** Register latency stats with stats library */
 	for (i = 0; i < NUM_LATENCY_STATS; i++)
-- 
2.43.0


  parent reply	other threads:[~2024-04-17 17:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0240408195036.182545-1-stephen@networkplumber.org>
2024-04-17 17:07 ` [PATCH v3 0/5] latencystats: cleanups Stephen Hemminger
2024-04-17 17:07   ` [PATCH v3 1/5] latencystats: replace use of VLA Stephen Hemminger
2024-04-17 18:03     ` Morten Brørup
2024-04-17 18:13       ` Stephen Hemminger
2024-04-18  0:00     ` Tyler Retzlaff
2024-04-17 17:07   ` Stephen Hemminger [this message]
2024-04-18  0:03     ` [PATCH v3 2/5] latencystats: handle fractional cycles per ns Tyler Retzlaff
2024-04-17 17:07   ` [PATCH v3 3/5] latencystats: do not use floating point Stephen Hemminger
2024-04-18  0:10     ` Tyler Retzlaff
2024-04-17 17:07   ` [PATCH v3 4/5] latencystats: fix log messages Stephen Hemminger
2024-04-18  0:13     ` Tyler Retzlaff
2024-04-17 17:07   ` [PATCH v3 5/5] latencystats: include file cleanup Stephen Hemminger
2024-04-17 17:30     ` Bruce Richardson
2024-04-17 18:13       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240417170908.76701-3-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.