From: Jakub Kicinski <kuba@kernel.org>
To: Mahesh Bandewar <maheshb@google.com>
Cc: Netdev <netdev@vger.kernel.org>,
Linux <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Richard Cochran <richardcochran@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Sagi Maimon <maimon.sagi@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
John Stultz <jstultz@google.com>,
Mahesh Bandewar <mahesh@bandewar.net>
Subject: Re: [PATCHv1 next] ptp: update gettimex64 to provide ts optionally in mono-raw base.
Date: Wed, 17 Apr 2024 18:24:45 -0700 [thread overview]
Message-ID: <20240417182445.019fb351@kernel.org> (raw)
In-Reply-To: <20240416215942.150202-1-maheshb@google.com>
On Tue, 16 Apr 2024 14:59:42 -0700 Mahesh Bandewar wrote:
> if (extoff->n_samples > PTP_MAX_SAMPLES
> - || extoff->rsv[0] || extoff->rsv[1] || extoff->rsv[2]) {
> + || extoff->rsv[0] || extoff->rsv[1]
> + || (extoff->clockid != CLOCK_REALTIME
> + && extoff->clockid != CLOCK_MONOTONIC_RAW)) {
Since you're touching this condition it's probably a good opportunity
to fox the coding style.
next prev parent reply other threads:[~2024-04-18 1:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 21:59 [PATCHv1 next] ptp: update gettimex64 to provide ts optionally in mono-raw base Mahesh Bandewar
2024-04-18 1:24 ` Jakub Kicinski [this message]
2024-04-18 4:25 ` Mahesh Bandewar (महेश बंडेवार)
2024-04-19 6:28 ` Richard Cochran
2024-04-20 2:58 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417182445.019fb351@kernel.org \
--to=kuba@kernel.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=maimon.sagi@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.