From: Dimitri Fedrau <dima.fedrau@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] pwm: mc33xs2410: add support for direct inputs
Date: Wed, 17 Apr 2024 22:32:21 +0200 [thread overview]
Message-ID: <20240417203221.GB148552@debian> (raw)
In-Reply-To: <dwd6idyv2dvfih57sdfnr6cxztrx6gv3pwuy6rdopjw2lv2z6y@in2sn56t3x5k>
Am Tue, Mar 19, 2024 at 05:38:52PM +0100 schrieb Uwe Kleine-König:
> Hello Dimitri,
>
Hi Uwe,
> On Fri, Mar 01, 2024 at 12:11:24PM +0100, Dimitri Fedrau wrote:
> > Add support for direct inputs, which are used to directly turn-on or
> > turn-off the outputs. Direct inputs have the advantage over the SPI
> > controlled outputs that they aren't limited to the frequency steps.
> > Frequency resolution depends on the input signal, range is still
> > from 0.5Hz to 2.048kHz.
>
> I didn't make a big effort, but I fail to understand the concept here.
> I'll delay giving more feedback till the next review round for this
> driver. Maybe then the description is easier to grasp.
>
I will drop it for now and come back later with a separate patch. I
think this would make it easier for now.
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | https://www.pengutronix.de/ |
Best regards
Dimitri
prev parent reply other threads:[~2024-04-17 20:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 11:11 [PATCH v2 0/3] pwm: add support for NXPs high-side switch MC33XS2410 Dimitri Fedrau
2024-03-01 11:11 ` [PATCH v2 1/3] dt-bindings: pwm: add support for MC33XS2410 Dimitri Fedrau
2024-03-01 12:30 ` Krzysztof Kozlowski
2024-03-01 11:11 ` [PATCH v2 2/3] pwm: add support for NXPs high-side switch MC33XS2410 Dimitri Fedrau
2024-03-19 16:35 ` Uwe Kleine-König
2024-04-17 20:29 ` Dimitri Fedrau
2024-03-01 11:11 ` [PATCH v2 3/3] pwm: mc33xs2410: add support for direct inputs Dimitri Fedrau
2024-03-19 16:38 ` Uwe Kleine-König
2024-04-17 20:32 ` Dimitri Fedrau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417203221.GB148552@debian \
--to=dima.fedrau@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.