From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
John Youn <John.Youn@synopsys.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] usb: xhci-plat: Don't include xhci.h
Date: Wed, 17 Apr 2024 13:08:56 +0200 [thread overview]
Message-ID: <2024041749-cheese-schedule-d21b@gregkh> (raw)
In-Reply-To: <900465dc09f1c8e12c4df98d625b9985965951a8.1713310411.git.Thinh.Nguyen@synopsys.com>
On Tue, Apr 16, 2024 at 11:41:36PM +0000, Thinh Nguyen wrote:
> The xhci_plat.h should not need to include the entire xhci.h header.
> This can cause redefinition in dwc3 if it selectively includes some xHCI
> definitions. This is a prerequisite change for a fix to disable suspend
> during initialization for dwc3.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> ---
> drivers/usb/host/xhci-plat.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-plat.h b/drivers/usb/host/xhci-plat.h
> index 2d15386f2c50..6475130eac4b 100644
> --- a/drivers/usb/host/xhci-plat.h
> +++ b/drivers/usb/host/xhci-plat.h
> @@ -8,7 +8,9 @@
> #ifndef _XHCI_PLAT_H
> #define _XHCI_PLAT_H
>
> -#include "xhci.h" /* for hcd_to_xhci() */
> +struct device;
> +struct platform_device;
> +struct usb_hcd;
>
> struct xhci_plat_priv {
> const char *firmware_name;
> --
> 2.28.0
>
Seems to break the build :(
next prev parent reply other threads:[~2024-04-17 11:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 23:41 [PATCH 0/2] usb: dwc3: Disable susphy during initialization Thinh Nguyen
2024-04-16 23:41 ` [PATCH 1/2] usb: xhci-plat: Don't include xhci.h Thinh Nguyen
2024-04-17 10:58 ` kernel test robot
2024-04-17 11:08 ` Greg Kroah-Hartman [this message]
2024-04-17 21:01 ` Thinh Nguyen
2024-04-16 23:41 ` [PATCH 2/2] usb: dwc3: core: Prevent phy suspend during init Thinh Nguyen
2024-09-25 7:50 ` Roger Quadros
2024-09-26 21:51 ` Thinh Nguyen
2024-09-27 9:52 ` Roger Quadros
2024-10-01 1:00 ` Thinh Nguyen
2024-10-01 7:52 ` Roger Quadros
2024-10-25 19:20 ` Chris Morgan
2024-10-25 19:20 ` Chris Morgan
2024-10-25 22:40 ` Thinh Nguyen
2024-10-25 22:40 ` Thinh Nguyen
[not found] ` <CADcbR4KhWdXpynk2c-tryx1=Eg4LhC4t=C6zcVHAMcMz2hH-8Q@mail.gmail.com>
2024-10-29 22:49 ` Thinh Nguyen
2024-10-30 13:10 ` Roger Quadros
2024-10-30 20:06 ` Chris Morgan
2024-10-31 1:33 ` Thinh Nguyen
2024-11-07 18:50 ` Chris Morgan
2024-11-07 19:02 ` Roger Quadros
2024-11-13 19:30 ` Chris Morgan
2024-11-14 2:35 ` Thinh Nguyen
2024-11-19 19:51 ` Chris Morgan
2024-11-19 22:19 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024041749-cheese-schedule-d21b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=John.Youn@synopsys.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.