From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Dan Jurgens <danielj@nvidia.com>,
Heng Qi <hengqi@linux.alibaba.com>,
Jason Wang <jasowang@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"mst@redhat.com" <mst@redhat.com>,
"xuanzhuo@linux.alibaba.com" <xuanzhuo@linux.alibaba.com>,
"virtualization@lists.linux.dev" <virtualization@lists.linux.dev>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next v4 3/6] virtio_net: Add a lock for the command VQ.
Date: Thu, 18 Apr 2024 09:01:24 -0700 [thread overview]
Message-ID: <20240418090124.03be2187@kernel.org> (raw)
In-Reply-To: <72f6c8a55adac52ad17dfe11a579b5b3d5dc3cec.camel@redhat.com>
On Thu, 18 Apr 2024 17:48:57 +0200 Paolo Abeni wrote:
> > > Side note: the compiler apparently does not like guard() construct, leading to
> > > new warning, here and in later patches. I'm unsure if the code simplification
> > > is worthy.
> >
> > I didn't see any warnings with GCC or clang. This is used other places in the kernel as well.
> > gcc version 13.2.1 20230918 (Red Hat 13.2.1-3) (GCC)
> > clang version 17.0.6 (Fedora 17.0.6-2.fc39)
> >
>
> See:
>
> https://patchwork.kernel.org/project/netdevbpf/patch/20240416193039.272997-4-danielj@nvidia.com/
> https://netdev.bots.linux.dev/static/nipa/845178/13632442/build_32bit/stderr
> https://netdev.bots.linux.dev/static/nipa/845178/13632442/build_allmodconfig_warn/stderr
These are sparse errors, I think, but I agree that there's little gain
here and clearly a cost of wasted time, since the standard kernel
tooling has not caught with with this ugly invention.
next prev parent reply other threads:[~2024-04-18 16:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 19:30 [PATCH net-next v4 0/6] Remove RTNL lock protection of CVQ Daniel Jurgens
2024-04-16 19:30 ` [PATCH net-next v4 1/6] virtio_net: Store RSS setting in virtnet_info Daniel Jurgens
2024-04-16 19:30 ` [PATCH net-next v4 2/6] virtio_net: Remove command data from control_buf Daniel Jurgens
2024-04-16 19:30 ` [PATCH net-next v4 3/6] virtio_net: Add a lock for the command VQ Daniel Jurgens
2024-04-18 6:42 ` Jason Wang
2024-04-18 7:36 ` Heng Qi
2024-04-18 10:56 ` Paolo Abeni
2024-04-18 15:38 ` Dan Jurgens
2024-04-18 15:48 ` Paolo Abeni
2024-04-18 16:01 ` Jakub Kicinski [this message]
2024-04-18 16:12 ` Heng Qi
2024-04-19 0:28 ` Jason Wang
2024-04-18 16:06 ` Heng Qi
2024-04-16 19:30 ` [PATCH net-next v4 4/6] virtio_net: Do DIM update for specified queue only Daniel Jurgens
2024-04-16 19:30 ` [PATCH net-next v4 5/6] virtio_net: Add a lock for per queue RX coalesce Daniel Jurgens
2024-04-16 19:30 ` [PATCH net-next v4 6/6] virtio_net: Remove rtnl lock protection of command buffers Daniel Jurgens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418090124.03be2187@kernel.org \
--to=kuba@kernel.org \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=jiri@nvidia.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.