From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v1 1/2] gpiolib: acpi: Add fwnode name to the GPIO interrupt label
Date: Thu, 18 Apr 2024 12:33:59 +0300 [thread overview]
Message-ID: <20240418093359.GQ112498@black.fi.intel.com> (raw)
In-Reply-To: <ZiDmoT9gn7cFaYyV@smile.fi.intel.com>
On Thu, Apr 18, 2024 at 12:23:45PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 18, 2024 at 07:49:07AM +0300, Mika Westerberg wrote:
> > On Wed, Apr 17, 2024 at 01:37:27PM +0300, Andy Shevchenko wrote:
> > > It's ambiguous to have a device-related index in the GPIO interrupt
> > > label as most of the devices will have it the same or very similar.
> > > Extend label with fwnode name for better granularity. It significantly
> > > reduces the scope of searching among devices.
> >
> > Can you add an example here how it looks like before and after the
> > patch?
>
> Sure:
>
> Before:
>
> GpioInt() 0
> GpioInt() 0
>
> After:
>
> NIO1 GpioInt(0)
> URT0 GpioInt(0)
>
> Assuming I update this when applying, can you give your tag?
Sure. For both,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2024-04-18 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 10:37 [PATCH v1 0/2] gpiolib: acpi: Improve IRQ labeling Andy Shevchenko
2024-04-17 10:37 ` [PATCH v1 1/2] gpiolib: acpi: Add fwnode name to the GPIO interrupt label Andy Shevchenko
2024-04-18 4:49 ` Mika Westerberg
2024-04-18 9:23 ` Andy Shevchenko
2024-04-18 9:33 ` Mika Westerberg [this message]
2024-04-18 10:00 ` Andy Shevchenko
2024-04-17 10:37 ` [PATCH v1 2/2] gpiolib: acpi: Set label for IRQ only lines Andy Shevchenko
2024-04-18 4:49 ` Mika Westerberg
2024-04-18 9:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418093359.GQ112498@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.