From: Philip Yang <Philip.Yang@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: <Felix.Kuehling@amd.com>, <christian.koenig@amd.com>,
<Arunpravin.PaneerSelvam@amd.com>,
Philip Yang <Philip.Yang@amd.com>
Subject: [PATCH v2 4/6] drm/amdkfd: Increase KFD bo restore wait time
Date: Thu, 18 Apr 2024 09:58:01 -0400 [thread overview]
Message-ID: <20240418135803.17365-5-Philip.Yang@amd.com> (raw)
In-Reply-To: <20240418135803.17365-1-Philip.Yang@amd.com>
TTM allocate contiguous VRAM may takes more than 1 second to evict BOs
for larger size RDMA buffer. Because KFD restore bo worker reserves all
KFD BOs, then TTM cannot hold the remainning KFD BOs lock to evict them,
this causes TTM failed to alloc contiguous VRAM.
Increase the KFD restore BO wait time to 2 seconds, long enough for RDMA
pin BO to alloc the contiguous VRAM.
Signed-off-by: Philip Yang <Philip.Yang@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
index a81ef232fdef..c205e2d3acf9 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
@@ -698,7 +698,7 @@ struct qcm_process_device {
/* KFD Memory Eviction */
/* Approx. wait time before attempting to restore evicted BOs */
-#define PROCESS_RESTORE_TIME_MS 100
+#define PROCESS_RESTORE_TIME_MS 2000
/* Approx. back off time if restore fails due to lack of memory */
#define PROCESS_BACK_OFF_TIME_MS 100
/* Approx. time before evicting the process again */
--
2.43.2
next prev parent reply other threads:[~2024-04-18 13:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 13:57 [PATCH v2 0/6] Best effort contiguous VRAM allocation Philip Yang
2024-04-18 13:57 ` [PATCH v2 1/6] drm/amdgpu: Support " Philip Yang
2024-04-18 14:37 ` Christian König
2024-04-18 20:50 ` Philip Yang
2024-04-18 13:57 ` [PATCH v2 2/6] drm/amdgpu: Evict BOs from same process for contiguous allocation Philip Yang
2024-04-18 13:58 ` [PATCH v2 3/6] drm/amdkfd: Evict BO itself " Philip Yang
2024-04-18 13:58 ` Philip Yang [this message]
2024-04-18 13:58 ` [PATCH v2 5/6] drm/amdgpu: Skip dma map resource for null RDMA device Philip Yang
2024-04-18 13:58 ` [PATCH v2 6/6] drm/amdkfd: Bump kfd version for contiguous VRAM allocation Philip Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418135803.17365-5-Philip.Yang@amd.com \
--to=philip.yang@amd.com \
--cc=Arunpravin.PaneerSelvam@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.