All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, Ido Schimmel <idosch@nvidia.com>,
	mlxsw@nvidia.com, Tim 'mithro' Ansell <me@mith.ro>
Subject: Re: [PATCH net v2 2/3] mlxsw: core_env: Fix driver initialization with old firmware
Date: Thu, 18 Apr 2024 18:55:34 +0100	[thread overview]
Message-ID: <20240418175534.GJ3975545@kernel.org> (raw)
In-Reply-To: <0afa8b2e8bac178f5f88211344429176dcc72281.1713446092.git.petrm@nvidia.com>

On Thu, Apr 18, 2024 at 03:46:07PM +0200, Petr Machata wrote:
> From: Ido Schimmel <idosch@nvidia.com>
> 
> The driver queries the Management Capabilities Mask (MCAM) register
> during initialization to understand if it can read up to 128 bytes from
> transceiver modules.
> 
> However, not all firmware versions support this register, leading to the
> driver failing to load.
> 
> Fix by treating an error in the register query as an indication that the
> feature is not supported.
> 
> Fixes: 1f4aea1f72da ("mlxsw: core_env: Read transceiver module EEPROM in 128 bytes chunks")
> Cc: Simon Horman <horms@kernel.org>
> Reported-by: Tim 'mithro' Ansell <me@mith.ro>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> Reviewed-by: Petr Machata <petrm@nvidia.com>
> Signed-off-by: Petr Machata <petrm@nvidia.com>
> ---
> 
> Notes:
>     v2:
>     - Make mlxsw_env_max_module_eeprom_len_query() void

Thanks for the update.

Reviewed-by: Simon Horman <horms@kernel.org>


  reply	other threads:[~2024-04-18 17:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 13:46 [PATCH net v2 0/3] mlxsw: Fixes Petr Machata
2024-04-18 13:46 ` [PATCH net v2 1/3] mlxsw: core: Unregister EMAD trap using FORWARD action Petr Machata
2024-04-18 13:46 ` [PATCH net v2 2/3] mlxsw: core_env: Fix driver initialization with old firmware Petr Machata
2024-04-18 17:55   ` Simon Horman [this message]
2024-04-18 13:46 ` [PATCH net v2 3/3] mlxsw: pci: " Petr Machata
2024-04-20  3:50 ` [PATCH net v2 0/3] mlxsw: Fixes patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240418175534.GJ3975545@kernel.org \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=me@mith.ro \
    --cc=mlxsw@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.