From: Jun Gu <jun.gu@easystack.cn>
To: kuba@kernel.org
Cc: dev@openvswitch.org, echaudro@redhat.com, jun.gu@easystack.cn,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH net-next v4] net: openvswitch: Check vport netdev name
Date: Fri, 19 Apr 2024 14:14:25 +0800 [thread overview]
Message-ID: <20240419061425.132723-1-jun.gu@easystack.cn> (raw)
Ensure that the provided netdev name is not one of its aliases to
prevent unnecessary creation and destruction of the vport by
ovs-vswitchd.
Signed-off-by: Jun Gu <jun.gu@easystack.cn>
Acked-by: Eelco Chaudron <echaudro@redhat.com>
---
net/openvswitch/vport-netdev.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c
index 903537a5da22..618edc346c0f 100644
--- a/net/openvswitch/vport-netdev.c
+++ b/net/openvswitch/vport-netdev.c
@@ -78,7 +78,10 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name)
int err;
vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name);
- if (!vport->dev) {
+ /* Ensure that the device exists and that the provided
+ * name is not one of its aliases.
+ */
+ if (!vport->dev || strcmp(name, ovs_vport_name(vport))) {
err = -ENODEV;
goto error_free_vport;
}
--
2.25.1
next reply other threads:[~2024-04-19 12:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 6:14 Jun Gu [this message]
2024-04-23 0:38 ` [PATCH net-next v4] net: openvswitch: Check vport netdev name Jakub Kicinski
2024-04-23 2:34 ` Jun Gu
2024-04-23 0:53 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2024-04-17 10:48 [PATCH net-next v3] net: openvswitch: Check vport net device name Eelco Chaudron
2024-04-18 2:32 ` [PATCH net-next v4] net: openvswitch: Check vport netdev name jun.gu
2024-04-18 15:38 ` Jakub Kicinski
2024-04-19 4:31 ` Jun Gu
2024-04-20 3:01 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419061425.132723-1-jun.gu@easystack.cn \
--to=jun.gu@easystack.cn \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.