From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E692EC4345F for ; Fri, 19 Apr 2024 12:26:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9810D82171; Fri, 19 Apr 2024 12:26:07 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 3zh4jo41ue74; Fri, 19 Apr 2024 12:26:07 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0F0E78217B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1713529567; bh=DgmsLIH3Q6ggnVrR+r+LrWBb8lm/zGJY/FVQaMN0Dic=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Ymbq+6uuU5ZX3eO2zg/qtt4mEy9Yza/6x0YvGyPPxqTSa+s3Kj3Sxvm1Tdlpc2BMM gQt9WD67qev74JSZUSnk3JrVuDC8kBEpKHkgFEHUbTw3DZ2FHbbpr33uiES7YmSxij E5pEEB3SfBCxJsK639adBP3Qrw6aTIBWLBGlPTXhbFHDH4Cw6sGB9NxigEQe+okfRv mOsSp9maJdaZeTDNtSKuplWqv34QC2MHFxHt4mJEaXrvjnWn5tzzf661VL539cAQxH lm9LWwpwKqmypbetIot/FHg44c3whGYRre4wooLAzgNwRRmPi2+lgOck5MuIB9Lgb7 VpfNVNkSUwUYQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 0F0E78217B; Fri, 19 Apr 2024 12:26:07 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 9F39E1BF308 for ; Fri, 19 Apr 2024 12:26:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 94E408217B for ; Fri, 19 Apr 2024 12:26:05 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id sBcruxux4uPK for ; Fri, 19 Apr 2024 12:26:03 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 3296E82171 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3296E82171 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp1.osuosl.org (Postfix) with ESMTPS id 3296E82171 for ; Fri, 19 Apr 2024 12:26:03 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5439DCE19D4; Fri, 19 Apr 2024 12:25:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48C05C072AA; Fri, 19 Apr 2024 12:25:56 +0000 (UTC) Date: Fri, 19 Apr 2024 13:25:53 +0100 From: Simon Horman To: =?utf-8?Q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= Message-ID: <20240419122553.GX3975545@kernel.org> References: <20240416144331.15336-1-ast@fiberby.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240416144331.15336-1-ast@fiberby.net> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713529558; bh=aNT6Y/Xt7MC+J2M7UeIANbRkSx6dQV+zx46InVO37JU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bVOnq3iHBHsZyHnICpIF8td3agRFAUFGhEF/b+DyrwF+BuU9Moz4FttY6DSXZc2rS okYaqIeb/MmMKrZgtTAoEFDjWFA2by7oqhTVCWtfYDpBYh4Zl7X9zryV+sGNLiBQCl KGg9DrcfD2yCTONwtr9Mvqv1Zp9OFEdgANS3QCDtH1Zw+pK9GpKCGhHE2ZI6S1Ggtf 8meMKrFLtaKhK0i2X/1PRiURZaAtTZ9r7Ew8/RZB77WHgL4PzlDt3ExTGJzEKOboSs FtPQxllyRVMaez6RaoI+Li/7lgjeMx/d1FSRxMHkvUCevJfK7ujMv1bd8MSRh15x9Y neugzmu1b/ZRQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=bVOnq3iH Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: flower: validate control flags X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Nguyen , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Apr 16, 2024 at 02:43:30PM +0000, Asbjørn Sloth Tønnesen wrote: > This driver currently doesn't support any control flags. > > Use flow_rule_has_control_flags() to check for control flags, > such as can be set through `tc flower ... ip_flags frag`. > > In case any control flags are masked, flow_rule_has_control_flags() > sets a NL extended error message, and we return -EOPNOTSUPP. > > Only compile-tested. > > Signed-off-by: Asbjørn Sloth Tønnesen Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0615B7F7C7; Fri, 19 Apr 2024 12:25:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713529559; cv=none; b=dnMu5FK34VKwCclav6CB9eag+wJX2opGAu0hZ+iU9livpA030HOtByImPpQpmndbJCbPO1qdQTsRMmEV5En4BgpWRfHNkwLNHMEAj4Z4Xf3XAWjUVTUXfSYax13TukrRtiqucPqKWT9SWPZBXmoakqxzBfPYB26s1i1U/M2pKBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713529559; c=relaxed/simple; bh=aNT6Y/Xt7MC+J2M7UeIANbRkSx6dQV+zx46InVO37JU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qHjz8asqofXkso95PHJSWGFjyaq8aM27jlyatRXKJwx5ijQaOlDNY4QDpiTjV/JS2G1mH5OEjvxKsdTXhP7JAjyRA8smIibtldHvCb1J71sxZVl8wcjrE7jRMkRR42pigaaQgeNkkwQzKptOr2j5+UA1bbmQ9Fixz4uSUPLmrzk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bVOnq3iH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bVOnq3iH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48C05C072AA; Fri, 19 Apr 2024 12:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713529558; bh=aNT6Y/Xt7MC+J2M7UeIANbRkSx6dQV+zx46InVO37JU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bVOnq3iHBHsZyHnICpIF8td3agRFAUFGhEF/b+DyrwF+BuU9Moz4FttY6DSXZc2rS okYaqIeb/MmMKrZgtTAoEFDjWFA2by7oqhTVCWtfYDpBYh4Zl7X9zryV+sGNLiBQCl KGg9DrcfD2yCTONwtr9Mvqv1Zp9OFEdgANS3QCDtH1Zw+pK9GpKCGhHE2ZI6S1Ggtf 8meMKrFLtaKhK0i2X/1PRiURZaAtTZ9r7Ew8/RZB77WHgL4PzlDt3ExTGJzEKOboSs FtPQxllyRVMaez6RaoI+Li/7lgjeMx/d1FSRxMHkvUCevJfK7ujMv1bd8MSRh15x9Y neugzmu1b/ZRQ== Date: Fri, 19 Apr 2024 13:25:53 +0100 From: Simon Horman To: =?utf-8?Q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jesse Brandeburg , Tony Nguyen Subject: Re: [PATCH iwl-next] ice: flower: validate control flags Message-ID: <20240419122553.GX3975545@kernel.org> References: <20240416144331.15336-1-ast@fiberby.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240416144331.15336-1-ast@fiberby.net> On Tue, Apr 16, 2024 at 02:43:30PM +0000, Asbjørn Sloth Tønnesen wrote: > This driver currently doesn't support any control flags. > > Use flow_rule_has_control_flags() to check for control flags, > such as can be set through `tc flower ... ip_flags frag`. > > In case any control flags are masked, flow_rule_has_control_flags() > sets a NL extended error message, and we return -EOPNOTSUPP. > > Only compile-tested. > > Signed-off-by: Asbjørn Sloth Tønnesen Reviewed-by: Simon Horman