Re: Regression in lm90 driver regarding GMT g781

[Aleksander Mazur <deweloper@wp.pl>]

Dnia 2024-04-20, o godz. 11:14:06
Guenter Roeck <linux@roeck-us.net> napisał(a):

> On Sat, Apr 20, 2024 at 06:34:27PM +0200, Aleksander Mazur wrote:
> > Hello,
> > 
> > I have a Wyse C00X thin client which is apparently equipped with GMT g781.
> > It is (or used to be) supported by lm90 driver. (I have a log from 2020
> > where it was simply working fine; it was kernel version 5.6.0 then.)
> > Now, with 6.8.7, I get following error:
> >   
> > > lm90 0-004c: Failed to enable regulator: -ENODEV  
> > 
> > However, when I just turned this message into a warning and let the driver
> > continue, it seems to work fine, providing temp1 and temp2 as previously.
> > 
> > Do you have an idea what could cause such a regression, and if this change
> > (I mean: simply not returning error from devm_regulator_get_enable) is safe?
> >   
> 
> Do you have CONFIG_REGULATOR enabled in your system ?
> 
> Guenter

No, it's disabled (and it was disabled in 5.6.0 as well).

Shouldn't devm_regulator_get_enable*() stubs return success instead of -ENODEV?

-- 
Aleksander Mazur