Re: [meta-arago][master/scarthgap][PATCH] meta-arago-distro: recipes-core: Add no-fstab-update option to WIC_CREATE_EXTRA_ARG

[Denys Dmytriyenko <denis@denix.org>]

On Sat, Apr 20, 2024 at 06:23:18PM +0530, Chirag Shilwant wrote:
> - Ideally running `ls /boot/` in filesystem should list contents from /rootfs/boot partition
> but currently it lists the contents of /boot partition of the WIC Image.
> 
> Eg - Incase of AM64x,
> ```
>     root@am64xx-evm:~# ls /boot/
>     EFI  Image  tiboot3-am64x-gp-evm.bin  tiboot3-am64x_sr2-hs-evm.bin  tiboot3-am64x_sr2-hs-fs-evm.bin  tiboot3.bin  tispl.bin  u-boot.img  uEnv.txt

Will this change affect EFI? As there's EFI directory in that partition.


> 
> ```
> 
> - To fix this issue, add --no-fstab-update flag to WIC_CREATE_EXTRA_ARG in arago-image.inc
> to prevent WIC image from adding an additional entry in /etc/fstab.

This flag is global and will prevent all other partitions from populating 
/etc/fstab properly. Sure, meta-ti only has /boot and / defined, but other 
layers could have own wic files with e.g. /home or /data partitions. Mounting 
those will require a custom /etc/fstab instead of wic creating corresponding 
entries automatically.


> Signed-off-by: Chirag Shilwant <c-shilwant@ti.com>
> ---
>  meta-arago-distro/recipes-core/images/arago-image.inc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta-arago-distro/recipes-core/images/arago-image.inc
> index 00308b57..2a34a709 100644
> --- a/meta-arago-distro/recipes-core/images/arago-image.inc
> +++ b/meta-arago-distro/recipes-core/images/arago-image.inc
> @@ -31,4 +31,6 @@ BAD_RECOMMENDATIONS += " \
>  "
>  BAD_RECOMMENDATIONS += "${@oe.utils.conditional("INIT_MANAGER", "sysvinit", "", "busybox-syslog", d)}"
>  
> +WIC_CREATE_EXTRA_ARGS += " --no-fstab-update"
> +
>  inherit core-image remove-net-rules
> -- 
> 2.34.1