From: Greg KH <gregkh@linuxfoundation.org>
To: Chris Wulff <Chris.Wulff@biamp.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget: f_uac1: Expose all string descriptors through configfs.
Date: Mon, 22 Apr 2024 06:53:01 +0200 [thread overview]
Message-ID: <2024042213-tidings-epileptic-d67f@gregkh> (raw)
In-Reply-To: <CO1PR17MB5419329D1584AD5AED65C703E1132@CO1PR17MB5419.namprd17.prod.outlook.com>
On Sun, Apr 21, 2024 at 03:41:23PM +0000, Chris Wulff wrote:
>
> > Any specific reason you didn't cc: the maintainer here? Or the
> > developers who touched the file last? scripts/get_maintainer.pl is your
> > friend :)
>
> Thanks for the script reference. I looked in MAINTAINERS and didn't see one for the file(s) I am patching. As luck would have it, the first person on the list is you :). I will CC the emails from the script in the future. I am struggling a bit with our Outlook 365 server as it doesn't allow SMTP mail with any kind of basic authentication so I am unable to directly use git send-email.
You might want to have your email client wrap lines at a sane length as
well :)
> > > diff --git a/drivers/usb/gadget/function/f_uac1.c b/drivers/usb/gadget/function/f_uac1.c
> > > index 7de74a3dd392..100169d6dca7 100644
> > > --- a/drivers/usb/gadget/function/f_uac1.c
> > > +++ b/drivers/usb/gadget/function/f_uac1.c
> > > @@ -377,24 +377,10 @@ enum {
> > > STR_AS_OUT_IF_ALT1,
> > > STR_AS_IN_IF_ALT0,
> > > STR_AS_IN_IF_ALT1,
> > > + NUM_STR_DESCRIPTORS,
> >
> > Does this require a change to the Documentation/ABI/ files as well?
>
> I will add the additional configfs strings to Documentation/ABI/testing/configfs-usb-gadget-uac1 and Documentation/usb/gadget-testing.rst
> Are you aware of any other documentation that I might need to update? Those are the ones I've found so far.
That's a good start and probably is all that is needed for now, thanks.
greg k-h
prev parent reply other threads:[~2024-04-22 4:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 20:23 [PATCH] usb: gadget: f_uac1: Expose all string descriptors through configfs Chris Wulff
2024-04-21 10:16 ` Greg KH
2024-04-21 15:41 ` Chris Wulff
2024-04-22 4:53 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024042213-tidings-epileptic-d67f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Chris.Wulff@biamp.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.