From: Jakub Kicinski <kuba@kernel.org>
To: Sai Krishna <saikrishnag@marvell.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<sgoutham@marvell.com>, <gakula@marvell.com>,
<hkelam@marvell.com>, <sbhatta@marvell.com>
Subject: Re: [net-next PATCH v2] octeontx2-pf: Add ucast filter count configurability via devlink.
Date: Mon, 22 Apr 2024 14:18:45 -0700 [thread overview]
Message-ID: <20240422141845.108b9c87@kernel.org> (raw)
In-Reply-To: <20240418190031.1115865-1-saikrishnag@marvell.com>
On Fri, 19 Apr 2024 00:30:31 +0530 Sai Krishna wrote:
> + DEVLINK_PARAM_DRIVER(OTX2_DEVLINK_PARAM_ID_UCAST_FLT_CNT,
> + "unicast_filter_count", DEVLINK_PARAM_TYPE_U8,
> + BIT(DEVLINK_PARAM_CMODE_RUNTIME),
> + otx2_dl_ucast_flt_cnt_get, otx2_dl_ucast_flt_cnt_set,
> + otx2_dl_ucast_flt_cnt_validate),
All devlink params must be documented (Documentation/networking/devlink)
including the explanation of the tradeoffs involved in changing the
setting.
--
pw-bot: cr
next prev parent reply other threads:[~2024-04-22 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 19:00 [net-next PATCH v2] octeontx2-pf: Add ucast filter count configurability via devlink Sai Krishna
2024-04-19 12:31 ` Simon Horman
2024-04-22 21:18 ` Jakub Kicinski [this message]
2024-04-24 8:32 ` Sai Krishna Gajula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422141845.108b9c87@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saikrishnag@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.