From: Salvatore Dipietro <dipiets@amazon.com>
To: <edumazet@google.com>
Cc: <alisaidi@amazon.com>, <benh@amazon.com>, <blakgeof@amazon.com>,
<davem@davemloft.net>, <dipietro.salvatore@gmail.com>,
<dipiets@amazon.com>, <dsahern@kernel.org>, <kuba@kernel.org>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>
Subject: Re: [PATCH v3] tcp: Add memory barrier to tcp_push()
Date: Mon, 22 Apr 2024 09:16:56 -0700 [thread overview]
Message-ID: <20240422161656.60331-1-dipiets@amazon.com> (raw)
In-Reply-To: <CANn89iK69pB9y5eZTNjV6rH-2y3B2iAT2dnu13WfUPyPTBkTkw@mail.gmail.com>
We have tested the proposed solution and it doesn't introduce any regression in our benchmark.
Moreover, looking to the assembly code, the `test_and_set_bit` generates an `ldsetal` and `dmb ish` instructions which are correct for the ARM architecture.
We do not see any concern with the proposed patch.
next prev parent reply other threads:[~2024-04-22 16:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 18:20 [PATCH] tcp: disable tcp_autocorking for socket when TCP_NODELAY flag is set Salvatore Dipietro
2023-12-09 11:03 ` Eric Dumazet
2023-12-11 15:58 ` Hazem Mohamed Abuelfotoh
2023-12-12 10:41 ` Paolo Abeni
2023-12-12 11:29 ` Eric Dumazet
2023-12-12 10:57 ` Paolo Abeni
2023-12-13 14:10 ` Eric Dumazet
2023-12-13 19:00 ` Jakub Kicinski
2023-12-13 19:29 ` Eric Dumazet
2023-12-13 21:30 ` Salvatore Dipietro
2023-12-14 8:40 ` Eric Dumazet
2023-12-14 9:05 ` Eric Dumazet
2023-12-14 14:08 ` Eric Dumazet
2023-12-14 15:52 ` Geoff Blake
2023-12-14 16:07 ` Eric Dumazet
2024-01-17 21:26 ` [PATCH v2] tcp: Add memory barrier to tcp_push() Salvatore Dipietro
2024-01-17 21:58 ` Eric Dumazet
2024-01-17 23:16 ` [PATCH v3] " Salvatore Dipietro
2024-01-18 10:38 ` Paolo Abeni
2024-01-18 10:42 ` Eric Dumazet
2024-01-18 16:40 ` Jakub Kicinski
2024-01-18 17:46 ` Geoff Blake
2024-01-18 18:30 ` Paolo Abeni
2024-01-18 19:30 ` Geoff Blake
2024-01-19 13:33 ` Eric Dumazet
2024-04-17 7:33 ` Eric Dumazet
2024-04-22 16:16 ` Salvatore Dipietro [this message]
2023-12-13 10:40 ` [PATCH] tcp: disable tcp_autocorking for socket when TCP_NODELAY flag is set patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422161656.60331-1-dipiets@amazon.com \
--to=dipiets@amazon.com \
--cc=alisaidi@amazon.com \
--cc=benh@amazon.com \
--cc=blakgeof@amazon.com \
--cc=davem@davemloft.net \
--cc=dipietro.salvatore@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.