Re: [PATCH v4] lib/hash: add defer queue reclaim API

[Stephen Hemminger <stephen@networkplumber.org>]

On Mon, 15 Apr 2024 11:26:02 +0000
Abdullah Ömer Yamaç <aomeryamac@gmail.com> wrote:

> +	ret = rte_rcu_qsbr_dq_reclaim(h->dq, h->hash_rcu_cfg->max_reclaim_size,
> +								  freed, pending, available);

Indention here is odd. I would expect "freed," to line up right under h->dq.
Since rte_rcu_qsbrs_dq_reclaim logs error on invalid parameters, this function should as well.

Total indent fixes:

diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
index 4a44aadd9a..e1ea810024 100644
--- a/lib/hash/rte_cuckoo_hash.c
+++ b/lib/hash/rte_cuckoo_hash.c
@@ -1590,21 +1590,20 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg)
 
 int
 rte_hash_rcu_qsbr_dq_reclaim(struct rte_hash *h, unsigned int *freed,
-					unsigned int *pending, unsigned int *available)
+			     unsigned int *pending, unsigned int *available)
 {
 	int ret;
 
 	if (h == NULL || h->hash_rcu_cfg == NULL) {
+		HASH_LOG(ERR, "Invalid input parameter");
 		rte_errno = EINVAL;
 		return 1;
 	}
 
 	ret = rte_rcu_qsbr_dq_reclaim(h->dq, h->hash_rcu_cfg->max_reclaim_size,
-								  freed, pending, available);
+				      freed, pending, available);
 	if (ret != 0) {
-		HASH_LOG(ERR,
-				 "%s: could not reclaim the defer queue in hash table",
-				 __func__);
+		HASH_LOG(ERR, "%s: could not reclaim the defer queue in hash table", __func__);
 		return 1;
 	}