From: Philip Yang <Philip.Yang@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: <Felix.Kuehling@amd.com>, <christian.koenig@amd.com>,
<Arunpravin.PaneerSelvam@amd.com>,
Philip Yang <Philip.Yang@amd.com>
Subject: [PATCH v5 4/6] drm/amdkfd: Evict BO itself for contiguous allocation
Date: Tue, 23 Apr 2024 11:28:58 -0400 [thread overview]
Message-ID: <20240423152900.533-5-Philip.Yang@amd.com> (raw)
In-Reply-To: <20240423152900.533-1-Philip.Yang@amd.com>
If the BO pages pinned for RDMA is not contiguous on VRAM, evict it to
system memory first to free the VRAM space, then allocate contiguous
VRAM space, and then move it from system memory back to VRAM.
Signed-off-by: Philip Yang <Philip.Yang@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
index ef9154043757..5d118e5580ce 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
@@ -1470,13 +1470,27 @@ static int amdgpu_amdkfd_gpuvm_pin_bo(struct amdgpu_bo *bo, u32 domain)
if (unlikely(ret))
return ret;
+ if (bo->flags & AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS) {
+ /*
+ * If bo is not contiguous on VRAM, move to system memory first to ensure
+ * we can get contiguous VRAM space after evicting other BOs.
+ */
+ if (!(bo->tbo.resource->placement & TTM_PL_FLAG_CONTIGUOUS)) {
+ ret = amdgpu_amdkfd_bo_validate(bo, AMDGPU_GEM_DOMAIN_GTT, false);
+ if (unlikely(ret)) {
+ pr_debug("validate bo 0x%p to GTT failed %d\n", &bo->tbo, ret);
+ goto out;
+ }
+ }
+ }
+
ret = amdgpu_bo_pin_restricted(bo, domain, 0, 0);
if (ret)
pr_err("Error in Pinning BO to domain: %d\n", domain);
amdgpu_bo_sync_wait(bo, AMDGPU_FENCE_OWNER_KFD, false);
+out:
amdgpu_bo_unreserve(bo);
-
return ret;
}
--
2.43.2
next prev parent reply other threads:[~2024-04-23 15:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 15:28 [PATCH v5 0/6] Best effort contiguous VRAM allocation Philip Yang
2024-04-23 15:28 ` [PATCH v5 1/6] drm/amdgpu: Support " Philip Yang
2024-04-23 22:17 ` Felix Kuehling
2024-04-24 13:58 ` Philip Yang
2024-04-23 15:28 ` [PATCH v5 2/6] drm/amdgpu: Handle sg size limit for contiguous allocation Philip Yang
2024-04-24 6:14 ` Christian König
2024-04-23 15:28 ` [PATCH v5 3/6] drm/amdgpu: Evict BOs from same process " Philip Yang
2024-04-23 22:16 ` Felix Kuehling
2024-04-23 15:28 ` Philip Yang [this message]
2024-04-23 22:15 ` [PATCH v5 4/6] drm/amdkfd: Evict BO itself " Felix Kuehling
2024-04-24 13:41 ` Philip Yang
2024-04-23 15:28 ` [PATCH v5 5/6] drm/amdkfd: Increase KFD bo restore wait time Philip Yang
2024-04-23 22:06 ` Felix Kuehling
2024-04-23 15:29 ` [PATCH v5 6/6] drm/amdkfd: Bump kfd version for contiguous VRAM allocation Philip Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423152900.533-5-Philip.Yang@amd.com \
--to=philip.yang@amd.com \
--cc=Arunpravin.PaneerSelvam@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.