From: Simon Horman <horms@kernel.org>
To: Gregor Herburger <gregor.herburger@ew.tq-group.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Thomas Kopp <thomas.kopp@microchip.com>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux@ew.tq-group.com, alexander.stein@ew.tq-group.com
Subject: Re: [PATCH 2/4] can: mcp251xfd: mcp251xfd_regmap_crc_write(): workaround for errata 5
Date: Tue, 23 Apr 2024 17:46:16 +0100 [thread overview]
Message-ID: <20240423164616.GX42092@kernel.org> (raw)
In-Reply-To: <20240417-mcp251xfd-gpio-feature-v1-2-bc0c61fd0c80@ew.tq-group.com>
On Wed, Apr 17, 2024 at 03:43:55PM +0200, Gregor Herburger wrote:
> According to Errata DS80000789E 5 writing IOCON register using one SPI
> write command clears LAT0/LAT1.
>
> Errata Fix/Work Around suggests to write registers with single byte write
> instructions. However, it seems that every write to the second byte
> causes the overrite of LAT0/LAT1.
nit: overwrite
Flagged by ./scripts/checkpatch.pl --codespell
>
> Never write byte 2 of IOCON register to avoid clearing of LAT0/LAT1.
>
> Signed-off-by: Gregor Herburger <gregor.herburger@ew.tq-group.com>
...
next prev parent reply other threads:[~2024-04-23 16:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 13:43 [PATCH 0/4] can: mcp251xfd: add gpio functionality Gregor Herburger
2024-04-17 13:43 ` [PATCH 1/4] can: mcp251xfd: stop timestamp before sending chip to sleep Gregor Herburger
2024-04-24 8:24 ` Marc Kleine-Budde
2024-04-25 5:14 ` Gregor Herburger
2024-04-24 11:54 ` Marc Kleine-Budde
2024-04-25 5:17 ` Gregor Herburger
2024-04-25 6:29 ` Marc Kleine-Budde
2024-04-25 9:44 ` Gregor Herburger
2024-04-17 13:43 ` [PATCH 2/4] can: mcp251xfd: mcp251xfd_regmap_crc_write(): workaround for errata 5 Gregor Herburger
2024-04-23 16:46 ` Simon Horman [this message]
2024-04-24 10:54 ` Vincent MAILHOL
2024-04-24 11:51 ` Marc Kleine-Budde
2024-04-25 5:37 ` Gregor Herburger
2024-04-17 13:43 ` [PATCH 3/4] can: mcp251xfd: add gpio functionality Gregor Herburger
2024-04-24 8:15 ` Marc Kleine-Budde
2024-04-24 9:10 ` Marc Kleine-Budde
2024-04-24 9:15 ` Marc Kleine-Budde
2024-04-24 9:35 ` Marc Kleine-Budde
2024-04-24 13:01 ` Marc Kleine-Budde
2024-04-17 13:43 ` [PATCH 4/4] dt-binding: can: mcp251xfd: add gpio-controller property Gregor Herburger
2024-04-17 14:46 ` Rob Herring
2024-04-19 16:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423164616.GX42092@kernel.org \
--to=horms@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gregor.herburger@ew.tq-group.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=mailhol.vincent@wanadoo.fr \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=thomas.kopp@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.