From: Simon Horman <horms@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: linux-kernel@vger.kernel.org,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
Lee Jones <lee@kernel.org>, Jiawen Wu <jiawenwu@trustnetic.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Andrew Lunn <andrew@lunn.ch>,
Duanqiang Wen <duanqiangwen@net-swift.com>,
"open list:SYNOPSYS DESIGNWARE I2C DRIVER"
<linux-i2c@vger.kernel.org>,
"open list:WANGXUN ETHERNET DRIVER" <netdev@vger.kernel.org>
Subject: Re: [PATCH 4/4] net: txgbe: Utilize i2c-designware.h
Date: Wed, 24 Apr 2024 18:34:19 +0100 [thread overview]
Message-ID: <20240424173419.GO42092@kernel.org> (raw)
In-Reply-To: <59cbfcf1-d5c4-470b-8c81-67432d6ffc11@broadcom.com>
On Wed, Apr 24, 2024 at 09:22:49AM -0700, Florian Fainelli wrote:
> On 4/24/24 09:14, Simon Horman wrote:
> > On Tue, Apr 23, 2024 at 04:36:22PM -0700, Florian Fainelli wrote:
> > > Rather than open code the i2c_designware string, utilize the newly
> > > defined constant in i2c-designware.h.
> > >
> > > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> >
> > Hi Florian,
> >
> > FYI, this conflicts with:
> >
> > c644920ce922 ("net: txgbe: fix i2c dev name cannot match clkdev")
> >
> > But a patch-set has been submitted which reverts that commit:
> >
> > https://lore.kernel.org/all/20240422084109.3201-1-duanqiangwen@net-swift.com/
>
> That's right, I mentioned in the cover letter this was based on top of
> Duanqiang's couple patches. Thanks Simon!
Thanks Florian,
Sorry for missing that.
next prev parent reply other threads:[~2024-04-24 17:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 23:36 [PATCH 0/4] Define i2c_designware in a header file Florian Fainelli
2024-04-23 23:36 ` [PATCH 1/4] i2c: designware: Create shared header hosting driver name Florian Fainelli
2024-04-23 23:59 ` Andy Shevchenko
2024-04-24 1:22 ` Florian Fainelli
2024-04-24 12:18 ` Andrew Lunn
2024-04-24 12:45 ` Andy Shevchenko
2024-04-25 8:33 ` Jarkko Nikula
2024-04-25 9:20 ` Andy Shevchenko
2024-04-23 23:36 ` [PATCH 2/4] mfd: intel-lpss: Utilize i2c-designware.h Florian Fainelli
2024-04-24 0:00 ` Andy Shevchenko
2024-04-24 3:20 ` Florian Fainelli
2024-05-02 7:17 ` Lee Jones
2024-05-02 16:19 ` Florian Fainelli
2024-05-02 16:42 ` Lee Jones
2024-04-23 23:36 ` [PATCH 3/4] mfd: intel_quark_i2c_gpio: " Florian Fainelli
2024-04-24 0:01 ` Andy Shevchenko
2024-04-24 1:28 ` Florian Fainelli
2024-04-24 12:37 ` Andy Shevchenko
2024-04-24 16:35 ` Florian Fainelli
2024-04-23 23:36 ` [PATCH 4/4] net: txgbe: " Florian Fainelli
2024-04-24 16:14 ` Simon Horman
2024-04-24 16:22 ` Florian Fainelli
2024-04-24 17:34 ` Simon Horman [this message]
2024-04-23 23:56 ` [PATCH 0/4] Define i2c_designware in a header file Andy Shevchenko
2024-04-24 1:21 ` Florian Fainelli
2024-04-24 14:26 ` Andy Shevchenko
2024-04-24 16:26 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424173419.GO42092@kernel.org \
--to=horms@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=duanqiangwen@net-swift.com \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=jsd@semihalf.com \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=mengyuanlou@net-swift.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.