From: Peter Zijlstra <peterz@infradead.org>
To: hupu@oppo.com
Cc: mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/fair.c: Fix the calculation method of 'lag'
Date: Thu, 25 Apr 2024 13:51:25 +0200 [thread overview]
Message-ID: <20240425115125.GZ40213@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20240424085533.GS40213@noisy.programming.kicks-ass.net>
On Thu, Apr 25, 2024 at 07:44:59PM +0800, hupu@oppo.com wrote:
> > > From: hupu <hupu@oppo.com>
> > >
> > > I think the 'lag' calculation here is inaccurate.
> > >
> > > Assume that delta needs to be subtracted from v_i to ensure that the
> > > vlag of task i after placement is the same as before.
> >
> > Why ?!? v_i is the unkown, it makes no sense to complicate things by
> > adding extra unknowns.
> >
> > > At this time, the
> > > vlag of task i after placement should be:
> > > vl'_i = V' - (v_i - delta)
> >
> > But but but, you can't have V' without knowing v_i.
> >
>
> Thank you for your patient guidance. I overlooked a important fact that
> v_i is unknown in the process of proof. Below is the complete proof
> process, and it turns out that you are correct.
*phew*, thanks for checking!
prev parent reply other threads:[~2024-04-25 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 11:44 [PATCH] sched/fair.c: Fix the calculation method of 'lag' to ensure that the vlag of the task after placement is the same as before hupu
2024-04-24 8:55 ` Peter Zijlstra
2024-04-25 11:44 ` [PATCH] sched/fair.c: Fix the calculation method of 'lag' hupu
2024-04-25 11:51 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425115125.GZ40213@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=hupu@oppo.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.