From: Chintan Vankar <c-vankar@ti.com>
To: "Marek Behún" <kabel@kernel.org>,
"Michal Simek" <michal.simek@amd.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"MD Danish Anwar" <danishanwar@ti.com>,
"Udit Kumar" <u-kumar1@ti.com>,
"Matthias Schiffer" <matthias.schiffer@ew.tq-group.com>,
"Andreas Dannenberg" <dannenberg@ti.com>,
"Devarsh Thakkar" <devarsht@ti.com>,
"Bin Meng" <bmeng@tinylab.org>,
"Sean Anderson" <seanga2@gmail.com>,
"Kishon Vijay Abraham I" <kishon@ti.com>,
"Nikhil M Jain" <n-jain1@ti.com>,
"Wadim Egorov" <w.egorov@phytec.de>,
"Joao Paulo Goncalves" <joao.goncalves@toradex.com>,
"Mattijs Korpershoek" <mkorpershoek@baylibre.com>,
"Chintan Vankar" <c-vankar@ti.com>, "Dhruva Gole" <d-gole@ti.com>,
"Francesco Dolcini" <francesco.dolcini@toradex.com>,
"Andrew Davis" <afd@ti.com>, "Roger Quadros" <rogerq@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Neha Malcom Francis" <n-francis@ti.com>,
"Simon Glass" <sjg@chromium.org>,
"Siddharth Vadapalli" <s-vadapalli@ti.com>,
"Nishanth Menon" <nm@ti.com>, "Tom Rini" <trini@konsulko.com>
Cc: <u-boot@lists.denx.de>
Subject: [PATCH v2 04/10] soc: ti: k3-navss-ringacc: Fix reset ring API
Date: Thu, 25 Apr 2024 17:38:16 +0530 [thread overview]
Message-ID: <20240425120822.2048012-5-c-vankar@ti.com> (raw)
In-Reply-To: <20240425120822.2048012-1-c-vankar@ti.com>
From: Vignesh Raghavendra <vigneshr@ti.com>
Expectation of k3_ringacc_ring_reset_raw() is to reset the ring to
requested size and not to 0. Fix this.
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Signed-off-by: Chintan Vankar <c-vankar@ti.com>
---
Link to v1:
https://lore.kernel.org/r/20240112064759.1801600-5-s-vadapalli@ti.com/
Changes from v1 to v2:
- No changes.
drivers/soc/ti/k3-navss-ringacc-u-boot.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/ti/k3-navss-ringacc-u-boot.c b/drivers/soc/ti/k3-navss-ringacc-u-boot.c
index f958239c2a..5d650b9de7 100644
--- a/drivers/soc/ti/k3-navss-ringacc-u-boot.c
+++ b/drivers/soc/ti/k3-navss-ringacc-u-boot.c
@@ -25,9 +25,16 @@ struct k3_nav_ring_cfg_regs {
#define KNAV_RINGACC_CFG_RING_SIZE_ELSIZE_MASK GENMASK(26, 24)
#define KNAV_RINGACC_CFG_RING_SIZE_ELSIZE_SHIFT (24)
+#define KNAV_RINGACC_CFG_RING_SIZE_MASK GENMASK(15, 0)
+
static void k3_ringacc_ring_reset_raw(struct k3_nav_ring *ring)
{
- writel(0, &ring->cfg->size);
+ u32 reg;
+
+ reg = readl(&ring->cfg->size);
+ reg &= KNAV_RINGACC_CFG_RING_SIZE_MASK;
+ reg |= ring->size;
+ writel(reg, &ring->cfg->size);
}
static void k3_ringacc_ring_reconfig_qmode_raw(struct k3_nav_ring *ring, enum k3_nav_ring_mode mode)
--
2.34.1
next prev parent reply other threads:[~2024-04-25 12:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 12:08 [PATCH v2 00/10] Add support for Ethernet Boot on SK-AM62 Chintan Vankar
2024-04-25 12:08 ` [PATCH v2 01/10] common: spl: spl: Init DRAM size in R5/A53 SPL Chintan Vankar
2024-04-25 12:08 ` [PATCH v2 02/10] firmware: ti_sci: Add No-OP for "RX_FL_CFG" Chintan Vankar
2024-04-25 12:08 ` [PATCH v2 03/10] soc: ti: k3-navss-ringacc: Initialize base address of ring cfg registers Chintan Vankar
2024-04-25 12:08 ` Chintan Vankar [this message]
2024-04-25 12:08 ` [PATCH v2 05/10] dma: ti: k3-udma: Add support for native configuration of chan/flow Chintan Vankar
2024-04-25 12:08 ` [PATCH v2 06/10] arm: mach-k3: am625_init: Probe AM65 CPSW NUSS Chintan Vankar
2024-04-25 12:27 ` Roger Quadros
2024-04-25 12:59 ` Chintan Vankar
2024-05-20 12:12 ` Roger Quadros
2024-05-21 5:34 ` Chintan Vankar
2024-05-22 20:18 ` Roger Quadros
2024-04-25 12:08 ` [PATCH v2 07/10] configs: am62: Add configs for enabling ETHBOOT in R5SPL Chintan Vankar
2024-04-25 12:08 ` [PATCH v2 08/10] configs: am62: Enable configs required for Ethboot Chintan Vankar
2024-04-25 12:08 ` [PATCH v2 09/10] arm: dts: k3-am625-r5-sk: Enable DM services for main_pktdma Chintan Vankar
2024-04-25 12:08 ` [PATCH v2 10/10] arch: arm: dts: k3-am62-sk-u-boot: Add missing "bootph-all" property to phy_gmii_sel node Chintan Vankar
2024-04-25 12:31 ` Roger Quadros
2024-04-25 12:36 ` Chintan Vankar
2024-05-20 6:04 ` Chintan Vankar
2024-05-20 12:13 ` Roger Quadros
2024-05-21 5:36 ` Chintan Vankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425120822.2048012-5-c-vankar@ti.com \
--to=c-vankar@ti.com \
--cc=afd@ti.com \
--cc=bmeng@tinylab.org \
--cc=d-gole@ti.com \
--cc=danishanwar@ti.com \
--cc=dannenberg@ti.com \
--cc=devarsht@ti.com \
--cc=francesco.dolcini@toradex.com \
--cc=joao.goncalves@toradex.com \
--cc=kabel@kernel.org \
--cc=kishon@ti.com \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=michal.simek@amd.com \
--cc=mkorpershoek@baylibre.com \
--cc=mripard@kernel.org \
--cc=n-francis@ti.com \
--cc=n-jain1@ti.com \
--cc=nm@ti.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
--cc=w.egorov@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.