From: Jakub Kicinski <kuba@kernel.org>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: netdev@vger.kernel.org, virtualization@lists.linux.dev,
"Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 2/3] virtio_net: fix possible dim status unrecoverable
Date: Thu, 25 Apr 2024 19:21:50 -0700 [thread overview]
Message-ID: <20240425192150.0685d4b3@kernel.org> (raw)
In-Reply-To: <20240425125855.87025-3-hengqi@linux.alibaba.com>
On Thu, 25 Apr 2024 20:58:54 +0800 Heng Qi wrote:
> When the dim worker is scheduled, if it no longer needs to issue
> commands, dim may not be able to return to the working state later.
>
> For example, the following single queue scenario:
> 1. The dim worker of rxq0 is scheduled, and the dim status is
> changed to DIM_APPLY_NEW_PROFILE;
> 2. dim is disabled or parameters have not been modified;
> 3. virtnet_rx_dim_work exits directly;
>
> Then, even if net_dim is invoked again, it cannot work because the
> state is not restored to DIM_START_MEASURE.
>
> Fixes: 6208799553a8 ("virtio-net: support rx netdim")
> Signed-off-by: Heng Qi <hengqi@linux.alibaba.com>
This sounds like a legitimate bug fix so it needs to be sent separately
to the net tree (subject tagged with [PATCH net]) and then you'll have
to wait until the following Thursday for the net tree to get merged
into net-next. At which point you can send the improvements.
(Without the wait there would be a conflict between the trees).
Right now the series does not apply to net-next anyway.
--
pw-bot: cr
next prev parent reply other threads:[~2024-04-26 2:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 12:58 [PATCH net-next 0/3] virtio_net: enable the irq for ctrlq Heng Qi
2024-04-25 12:58 ` [PATCH net-next 1/3] virtio_net: enable irq for the control vq Heng Qi
2024-05-07 3:15 ` Jason Wang
2024-05-07 3:55 ` Heng Qi
2024-05-07 6:24 ` Jason Wang
2024-05-07 6:27 ` Heng Qi
2024-05-08 2:19 ` Jason Wang
2024-05-08 3:43 ` Heng Qi
2024-04-25 12:58 ` [PATCH net-next 2/3] virtio_net: fix possible dim status unrecoverable Heng Qi
2024-04-26 2:21 ` Jakub Kicinski [this message]
2024-04-26 2:55 ` Heng Qi
2024-04-25 12:58 ` [PATCH net-next 3/3] virtio_net: improve dim command request efficiency Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425192150.0685d4b3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.