From: Kees Cook <keescook@chromium.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Kees Cook <keescook@chromium.org>,
Kent Overstreet <kent.overstreet@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: [PATCH] alloc_tag: Tighten file permissions on /proc/allocinfo
Date: Thu, 25 Apr 2024 13:08:50 -0700 [thread overview]
Message-ID: <20240425200844.work.184-kees@kernel.org> (raw)
The /proc/allocinfo file exposes a tremendous about of information about
kernel build details, memory allocations (obviously), and potentially
even image layout (due to ordering). As this is intended to be consumed
by system owners (like /proc/slabinfo), use the same file permissions as
there: 0400.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
---
lib/alloc_tag.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c
index 26af9982ddc4..531dbe2f5456 100644
--- a/lib/alloc_tag.c
+++ b/lib/alloc_tag.c
@@ -129,7 +129,7 @@ size_t alloc_tag_top_users(struct codetag_bytes *tags, size_t count, bool can_sl
static void __init procfs_init(void)
{
- proc_create_seq("allocinfo", 0444, NULL, &allocinfo_seq_op);
+ proc_create_seq("allocinfo", 0400, NULL, &allocinfo_seq_op);
}
static bool alloc_tag_module_unload(struct codetag_type *cttype,
--
2.34.1
next reply other threads:[~2024-04-25 20:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 20:08 Kees Cook [this message]
2024-04-25 20:45 ` [PATCH] alloc_tag: Tighten file permissions on /proc/allocinfo Kent Overstreet
2024-04-25 20:51 ` Matthew Wilcox
2024-04-25 21:04 ` Kent Overstreet
2024-04-25 21:21 ` Suren Baghdasaryan
2024-04-25 21:25 ` Kent Overstreet
2024-04-25 21:38 ` Andrew Morton
2024-04-25 21:45 ` Kent Overstreet
2024-04-26 8:32 ` Pavel Machek
2024-04-26 8:46 ` Kent Overstreet
2024-04-25 22:42 ` Kees Cook
2024-04-25 23:02 ` Kent Overstreet
2024-04-25 23:47 ` Andrew Morton
2024-04-26 0:27 ` Kent Overstreet
2024-04-26 0:43 ` Kees Cook
2024-04-26 0:58 ` Kent Overstreet
2024-04-26 3:25 ` Matthew Wilcox
2024-04-26 3:35 ` Kent Overstreet
2024-04-26 8:34 ` Pavel Machek
2024-04-26 0:39 ` Kees Cook
2024-04-25 20:57 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425200844.work.184-kees@kernel.org \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.