From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACD52C4345F for ; Fri, 26 Apr 2024 06:23:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C27CB10E7EC; Fri, 26 Apr 2024 06:23:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Z5N+I5U8"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1194610E7EC for ; Fri, 26 Apr 2024 06:23:13 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D152961FD9; Fri, 26 Apr 2024 06:23:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24992C113CE; Fri, 26 Apr 2024 06:23:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714112592; bh=Nfb+0TFJqYbN3lblUgp8OR/OnwjY43BbHiskkc20XKA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z5N+I5U8LvRKBICc8IVwHVEKZ9uhgtL1KyjLcG4G5dLxUSFeZ6FI4SVkd8+945Dqw iZjmEMKwP+I3BGg9NpbvZzPGK8bafNtVRdFURirdw/HhKGHh8MJwpu/+GypLP15Pea 7FB6I+AWZe6zryD34I/tToNOSL9IZ87XnFsabqhfzmgD2dmnDhtSeOhk2PR46SQNOw 6TVh8VPfwu0bahqvN0KHOSp6M8Nu+2dSOxa6dgS+2b7deV4MYjH2HeE01OhRJ18SrW TSnAm9wlC/BEPzM5k3YyTSohkuNRIxEpWcKsS+rK8oi2I3vqx09OIfjhvHTd+l9JKZ LdZYfpQubMZGQ== Date: Fri, 26 Apr 2024 08:23:02 +0200 From: Maxime Ripard To: Sui Jingfeng Cc: Andy Shevchenko , Neil Armstrong , Randy Dunlap , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter Subject: Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs Message-ID: <20240426-married-augmented-mantis-ff7edd@penduick> References: <20240425142706.2440113-2-andriy.shevchenko@linux.intel.com> <2599705c-0a64-4742-b1d7-330e9fde6e7a@linux.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="o5swtcdrnu6wvo4w" Content-Disposition: inline In-Reply-To: <2599705c-0a64-4742-b1d7-330e9fde6e7a@linux.dev> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --o5swtcdrnu6wvo4w Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: > On 2024/4/26 03:10, Andy Shevchenko wrote: > > On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: > > > On 2024/4/25 22:26, Andy Shevchenko wrote: > > > > It seems driver missed the point of proper use of device property A= PIs. > > > > Correct this by updating headers and calls respectively. > > > You are using the 'seems' here exactly saying that you are not 100% s= ure. > > >=20 > > > Please allow me to tell you the truth: This patch again has ZERO effe= ct. > > > It fix nothing. And this patch is has the risks to be wrong. > > Huh?! Really, stop commenting the stuff you do not understand. >=20 > I'm actually a professional display drivers developer at the downstream > in the past, despite my contribution to upstream is less. But I believe > that all panel driver developers know what I'm talking about. So please > have take a look at my replies. Most of the interactions you had in this series has been uncalled for. You might be against a patch, but there's no need to go to such length. As far as I'm concerned, this patch is fine to me in itself, and I don't see anything that would prevent us from merging it. Maxime --o5swtcdrnu6wvo4w Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCZitIOwAKCRAnX84Zoj2+ dr1eAX4kt8+oP9QDw8OZ8+bOs5hSPHT1YEkFlVR2do4H+X5sKSBcmsIVc9BIk8Lo EZj+dEkBewWPb+S0DuTK2+irs3efvEm8uRMkhJ/XSFB+Wk1eivIEh2L7b3yDHUKM UmIpp971tQ== =k4n4 -----END PGP SIGNATURE----- --o5swtcdrnu6wvo4w--