From: Jason Gunthorpe <jgg@nvidia.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Konstantin Taranov <kotaranov@microsoft.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Long Li <longli@microsoft.com>,
Ajay Sharma <sharmaajay@microsoft.com>
Subject: Re: [PATCH v1 1/1] RDMA/mana_ib: Fix compilation error
Date: Fri, 26 Apr 2024 13:58:08 -0300 [thread overview]
Message-ID: <20240426165808.GA941030@nvidia.com> (raw)
In-Reply-To: <ZivbYdt2HxDpMxC5@smile.fi.intel.com>
On Fri, Apr 26, 2024 at 07:50:41PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 26, 2024 at 01:37:19PM -0300, Jason Gunthorpe wrote:
> > On Tue, Apr 23, 2024 at 11:42:58PM +0300, Andy Shevchenko wrote:
> > > The compilation with CONFIG_WERROR=y is broken:
> > >
> > > .../hw/mana/device.c:88:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
> > > if (!upper_ndev) {
> > > ^~~~~~~~~~~
> > >
> > > Fix this by assigning the ret to -ENODEV in respective condition.
> > >
> > > Fixes: 8b184e4f1c32 ("RDMA/mana_ib: Enable RoCE on port 1")
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > drivers/infiniband/hw/mana/device.c | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > This was fixed in
>
> Hmm... The below patch had been sent _after_ mine. What's wrong with
> mine patch?
It wasn't
Your's:
Date: Tue, 23 Apr 2024 23:42:58 +0300 [thread overview]
Konstantin's:
Date: Tue, 23 Apr 2024 07:15:51 -0700 [thread overview]
He beat you by 6 hours, which is why I took his, yours didn't exist at
the time I took it.
Jason
prev parent reply other threads:[~2024-04-26 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 20:42 [PATCH v1 1/1] RDMA/mana_ib: Fix compilation error Andy Shevchenko
2024-04-23 23:58 ` Long Li
2024-04-26 16:37 ` Jason Gunthorpe
2024-04-26 16:50 ` Andy Shevchenko
2024-04-26 16:56 ` Andy Shevchenko
2024-04-26 16:58 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426165808.GA941030@nvidia.com \
--to=jgg@nvidia.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=kotaranov@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=sharmaajay@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.